)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fd8cdf694e68ea7e34dd709a7efc66674eb1ea13","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                    \"Error: %s\", e)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def list_all_block_devices(block_type\u003d\u0027disk\u0027, include_dependents\u003dFalse):"},{"line_number":115,"context_line":"    \"\"\"List all physical block devices"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    The switches we use for lsblk: P for KEY\u003d\"value\" output, b for size output"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fd172d45","line":114,"updated":"2018-09-05 18:20:57.000000000","message":"fwiw, I have a patch that makes this non-optional because ATARAID is a dependent device and otherwise we can\u0027t detect it. https://review.openstack.org/#/c/592639/4/ironic_python_agent/hardware.py","commit_id":"82d693d82a34d5db9d6c6fb43cd1a0910c7ed01a"},{"author":{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},"change_message_id":"47baba896f958fa8e818d55a2ecb90461e5d6950","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                    \"Error: %s\", e)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def list_all_block_devices(block_type\u003d\u0027disk\u0027, include_dependents\u003dFalse):"},{"line_number":115,"context_line":"    \"\"\"List all physical block devices"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    The switches we use for lsblk: P for KEY\u003d\"value\" output, b for size output"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c39a92c3","line":114,"in_reply_to":"3f79a3b5_fd172d45","updated":"2018-09-05 19:30:45.000000000","message":"Non-optional is fine with me.  I merely added the option because excluding \"-d\" is required for lsblk to output disk partitions and I assumed that \"-d\" was required for something else (otherwise why would it be there, right ;).","commit_id":"82d693d82a34d5db9d6c6fb43cd1a0910c7ed01a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fd8cdf694e68ea7e34dd709a7efc66674eb1ea13","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        block_devices \u003d list_all_block_devices()"},{"line_number":727,"context_line":"        if include_partitions:"},{"line_number":728,"context_line":"            block_devices.extend("},{"line_number":729,"context_line":"                list_all_block_devices(block_type\u003d\u0027part\u0027,"},{"line_number":730,"context_line":"                                       include_dependents\u003dTrue)"},{"line_number":731,"context_line":"            )"},{"line_number":732,"context_line":"        return block_devices"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9d7079a6","line":729,"updated":"2018-09-05 18:20:57.000000000","message":"Okay, this makes more sense.","commit_id":"82d693d82a34d5db9d6c6fb43cd1a0910c7ed01a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"55a0ef80412a4944c74ae1e1af8ea505a16083e6","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    def get_cpus(self):"},{"line_number":340,"context_line":"        raise errors.IncompatibleHardwareMethodError"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def list_block_devices(self):"},{"line_number":343,"context_line":"        raise errors.IncompatibleHardwareMethodError"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def get_memory(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ea10e15a","line":342,"updated":"2018-10-24 10:22:03.000000000","message":"please update this with the new argument (it also needs mentioning in the release notes, as it\u0027s a hardware manager API change)","commit_id":"8c3f9a2a0a1e54d499260a162bb189f5f08c268e"},{"author":{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},"change_message_id":"b2bb87b8a2c38279f551703e6dc21a33c4c5f35a","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    def get_cpus(self):"},{"line_number":340,"context_line":"        raise errors.IncompatibleHardwareMethodError"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def list_block_devices(self):"},{"line_number":343,"context_line":"        raise errors.IncompatibleHardwareMethodError"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def get_memory(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_fea90e26","line":342,"in_reply_to":"3f79a3b5_ea10e15a","updated":"2018-10-30 17:50:10.000000000","message":"Done\n\n1. Added `include_partitions\u003dFalse` to parameter list.\n2. Added docstring with method and parameter description.","commit_id":"8c3f9a2a0a1e54d499260a162bb189f5f08c268e"}],"releasenotes/notes/erase_metadata_from_partitions-4f1902533d530b8f.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"55a0ef80412a4944c74ae1e1af8ea505a16083e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Erase metadata on disk partitions, not just disk block devices, because a"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_8a092d33","line":1,"updated":"2018-10-24 10:22:03.000000000","message":"as mentioned above, we need to mention the change in the list_block_devices hardware manager API","commit_id":"8c3f9a2a0a1e54d499260a162bb189f5f08c268e"},{"author":{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},"change_message_id":"b2bb87b8a2c38279f551703e6dc21a33c4c5f35a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Erase metadata on disk partitions, not just disk block devices, because a"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_f1337ff7","line":1,"in_reply_to":"3f79a3b5_8a092d33","updated":"2018-10-30 17:50:10.000000000","message":"Done\n\n1. Described the Hardware Manager API change.","commit_id":"8c3f9a2a0a1e54d499260a162bb189f5f08c268e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"55a0ef80412a4944c74ae1e1af8ea505a16083e6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    Ironic node will cause the Linux kernel to inspect the partition, discover"},{"line_number":7,"context_line":"    the metadata, and recreate the associated storage entities (eg LVM, RAID),"},{"line_number":8,"context_line":"    usually to the surprise of the current user, making it difficult to use the"},{"line_number":9,"context_line":"    partition until the new storage entities are deleted."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_aa066920","line":9,"updated":"2018-10-24 10:22:03.000000000","message":"nit: could you please split this once sentence into several?","commit_id":"8c3f9a2a0a1e54d499260a162bb189f5f08c268e"},{"author":{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},"change_message_id":"b2bb87b8a2c38279f551703e6dc21a33c4c5f35a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    Ironic node will cause the Linux kernel to inspect the partition, discover"},{"line_number":7,"context_line":"    the metadata, and recreate the associated storage entities (eg LVM, RAID),"},{"line_number":8,"context_line":"    usually to the surprise of the current user, making it difficult to use the"},{"line_number":9,"context_line":"    partition until the new storage entities are deleted."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_d12a0377","line":9,"in_reply_to":"3f79a3b5_aa066920","updated":"2018-10-30 17:50:10.000000000","message":"Done\n\n1. Rewrote using multiple smaller sentences.\n2. Reduced technical detail and instead linked to story.","commit_id":"8c3f9a2a0a1e54d499260a162bb189f5f08c268e"}]}