)]}'
{"imagebuild/tinyipa/build_files/dhcp.sh":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"36c907af4130ed1de4221b9943e2c86495cdc6b7","unresolved":false,"context_lines":[{"line_number":4,"context_line":". /etc/init.d/tc-functions"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# This waits until all devices have registered"},{"line_number":7,"context_line":"/sbin/udevadm settle --timeout\u003d30"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"NETDEVICES\u003d\"$(awk -F: \u0027/eth.:|tr.:/{print $1}\u0027 /proc/net/dev 2\u003e/dev/null)\""},{"line_number":10,"context_line":"for DEVICE in $NETDEVICES; do"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_8bc84f56","line":7,"updated":"2018-10-11 17:31:08.000000000","message":"This doesn\u0027t feel connected to dhcp and network connectivity, and could extend our deployment times towards where they could fail in some tests. I\u0027m only for this if we\u0027re able to identify data that provides evidence that this resolves the grenade test issue.","commit_id":"8f9517961b9951caedaa04286954e620822399d3"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"492b6e037d2611c655ebf761223e69bce15678ba","unresolved":false,"context_lines":[{"line_number":4,"context_line":". /etc/init.d/tc-functions"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# This waits until all devices have registered"},{"line_number":7,"context_line":"/sbin/udevadm settle --timeout\u003d30"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"NETDEVICES\u003d\"$(awk -F: \u0027/eth.:|tr.:/{print $1}\u0027 /proc/net/dev 2\u003e/dev/null)\""},{"line_number":10,"context_line":"for DEVICE in $NETDEVICES; do"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_3d113eb0","line":7,"in_reply_to":"3f79a3b5_8bc84f56","updated":"2018-10-11 18:31:04.000000000","message":"Agreed, I can create a patch that output the result of $NETDEVICES without changing the udev settle timeout, the echo command in the loop and not sending udhcpc output to /dev/null.\n\n\nAlso if this does solve the grenade job\u0027s, we may want to add a conditional like:\n\n  NETDEVICES\u003d\"$(awk -F: \u0027/eth.:|tr.:/{print $1}\u0027 /proc/net/dev 2\u003e/dev/null)\"\n  if [ -z $NETDEVICES ]; then\n      /sbin/udevadm settle --timeout\u003d25\n      NETDEVICES\u003d\"$(awk -F: \u0027/eth.:|tr.:/{print $1}\u0027 /proc/net/dev 2\u003e/dev/null)\"\n  fi\n\nBy doing this we only extend the job runtime in the cases where no network interfaces are ready. Non grenade job\u0027s using the virtio driver\u0027s wont be affected.","commit_id":"8f9517961b9951caedaa04286954e620822399d3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b74e815cb7121d5b36f2ae13a0cb7bcfb04c8788","unresolved":false,"context_lines":[{"line_number":4,"context_line":". /etc/init.d/tc-functions"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# This waits until all devices have registered"},{"line_number":7,"context_line":"/sbin/udevadm settle --timeout\u003d20"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"NETDEVICES\u003d\"$(awk -F: \u0027/eth.:|tr.:/{print $1}\u0027 /proc/net/dev 2\u003e/dev/null)\""},{"line_number":10,"context_line":"echo \"$0: Discovered network devices: $NETDEVICES\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"3f79a3b5_5d7724a0","line":7,"updated":"2018-10-15 10:45:21.000000000","message":"Let\u0027s make it configurable with a pattern? like %TIMEOUT% which can be replaced in finalise-tinyipa.sh?","commit_id":"a53e10be70e9e9e1ffc12a41d4477a68eb47ee0d"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"27107f5ce4acee695dc8a2d22690370582b752fb","unresolved":false,"context_lines":[{"line_number":4,"context_line":". /etc/init.d/tc-functions"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# This waits until all devices have registered"},{"line_number":7,"context_line":"/sbin/udevadm settle --timeout\u003d20"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"NETDEVICES\u003d\"$(awk -F: \u0027/eth.:|tr.:/{print $1}\u0027 /proc/net/dev 2\u003e/dev/null)\""},{"line_number":10,"context_line":"echo \"$0: Discovered network devices: $NETDEVICES\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"3f79a3b5_2d2a3377","line":7,"in_reply_to":"3f79a3b5_5d7724a0","updated":"2018-10-15 15:31:41.000000000","message":"Done","commit_id":"a53e10be70e9e9e1ffc12a41d4477a68eb47ee0d"}]}