)]}'
{"id":"openstack%2Fironic-python-agent~611861","triplet_id":"openstack%2Fironic-python-agent~master~I0e3306a4d4584ca28e03608e9f7270b770960a39","project":"openstack/ironic-python-agent","branch":"master","topic":"fix-bmc-address-discovery","hashtags":[],"change_id":"I0e3306a4d4584ca28e03608e9f7270b770960a39","subject":"Fix BMC IP address detection on CoreOS images","status":"MERGED","created":"2018-10-19 13:06:14.000000000","updated":"2018-10-20 11:06:13.000000000","submitted":"2018-10-20 11:06:13.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"611861-1540033573876-53572886","meta_rev_id":"f37bcd27b46e9ec00f929e532b8ac319bc09d9ec","_number":611861,"virtual_id_number":611861,"owner":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2018-10-20 11:06:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":2,"date":"2018-10-19 17:34:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-10-20 10:03:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-10-20 10:03:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-10-19 17:34:51.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2018-10-20 10:03:50.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2018-10-20 11:06:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"046405ced7f49de1c3862f0e219401c62044e749","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2018-10-19 13:06:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a48983f8d3f2c8e3bb00716113c8006f2a137eef","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2018-10-19 13:23:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0ff44c023b8794a32d24393c7fa77220ca4deff2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-19 14:58:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/61/611861/2/check/openstack-tox-pep8/0ed15b9/ : SUCCESS in 3m 42s\n- openstack-tox-py27 http://logs.openstack.org/61/611861/2/check/openstack-tox-py27/0cd324f/ : SUCCESS in 3m 18s\n- openstack-tox-py35 http://logs.openstack.org/61/611861/2/check/openstack-tox-py35/bbbc5b9/ : SUCCESS in 3m 48s\n- openstack-tox-py36 http://logs.openstack.org/61/611861/2/check/openstack-tox-py36/f0f27ed/ : SUCCESS in 3m 23s\n- openstack-tox-docs http://logs.openstack.org/61/611861/2/check/openstack-tox-docs/a10bae8/html/ : SUCCESS in 3m 31s\n- build-openstack-releasenotes http://logs.openstack.org/61/611861/2/check/build-openstack-releasenotes/523d8d6/html/ : SUCCESS in 2m 45s\n- ipa-tempest-dsvm-partition-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/61/611861/2/check/ipa-tempest-dsvm-partition-bios-ipmi-direct-tinyipa-src/6dd98f1/ : SUCCESS in 56m 44s\n- ipa-tempest-dsvm-partition-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/61/611861/2/check/ipa-tempest-dsvm-partition-bios-ipmi-iscsi-tinyipa-src/3bfbf71/ : SUCCESS in 54m 00s\n- ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/61/611861/2/check/ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-tinyipa-src/59ad3a8/ : SUCCESS in 52m 37s\n- ipa-tempest-dsvm-wholedisk-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/61/611861/2/check/ipa-tempest-dsvm-wholedisk-bios-ipmi-iscsi-tinyipa-src/8c27889/ : SUCCESS in 58m 25s\n- ipa-tempest-dsvm-ironic-inspector-src http://logs.openstack.org/61/611861/2/check/ipa-tempest-dsvm-ironic-inspector-src/80a9722/ : SUCCESS in 1h 11m 52s (non-voting)\n- ipa-tempest-dsvm-partition-bios-ipmi-direct-coreos-src http://logs.openstack.org/61/611861/2/check/ipa-tempest-dsvm-partition-bios-ipmi-direct-coreos-src/7c74435/ : SUCCESS in 58m 13s (non-voting)\n- ipa-tempest-dsvm-partition-bios-ipmi-iscsi-coreos-src http://logs.openstack.org/61/611861/2/check/ipa-tempest-dsvm-partition-bios-ipmi-iscsi-coreos-src/b5ed669/ : SUCCESS in 55m 49s (non-voting)\n- ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-coreos-src http://logs.openstack.org/61/611861/2/check/ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-coreos-src/ded85e5/ : SUCCESS in 52m 59s (non-voting)\n- ipa-tempest-dsvm-wholedisk-bios-ipmi-iscsi-coreos-src http://logs.openstack.org/61/611861/2/check/ipa-tempest-dsvm-wholedisk-bios-ipmi-iscsi-coreos-src/32a431e/ : SUCCESS in 54m 53s (non-voting)\n- openstack-tox-functional http://logs.openstack.org/61/611861/2/check/openstack-tox-functional/e7881b1/ : SUCCESS in 3m 45s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/61/611861/2/check/openstack-tox-lower-constraints/a8436c6/ : SUCCESS in 4m 20s","accounts_in_message":[],"_revision_number":2},{"id":"ef86f043618e23d0b491b7354d64dc7701991a1f","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2018-10-19 17:34:51.000000000","message":"Patch Set 2: Code-Review+2\n\n\\o/","accounts_in_message":[],"_revision_number":2},{"id":"136f41fb040d44585b1d6cc919bef1fc0c8ec6d2","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2018-10-20 10:03:50.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"e9850a70c37752ab6cd48e088eaed7d2397042ec","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-20 10:04:05.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"21c019eda999222496672778b3306aa1b8dab96d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-20 11:06:13.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"b5bfa7ce85c5c37c47c373c17dc9398308dfcc99","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-20 11:06:13.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/61/611861/2/gate/openstack-tox-pep8/7ba6be7/ : SUCCESS in 4m 00s\n- openstack-tox-py27 http://logs.openstack.org/61/611861/2/gate/openstack-tox-py27/a08b98e/ : SUCCESS in 4m 41s\n- openstack-tox-py35 http://logs.openstack.org/61/611861/2/gate/openstack-tox-py35/fd36320/ : SUCCESS in 3m 10s\n- openstack-tox-py36 http://logs.openstack.org/61/611861/2/gate/openstack-tox-py36/281a11c/ : SUCCESS in 3m 28s\n- openstack-tox-docs http://logs.openstack.org/61/611861/2/gate/openstack-tox-docs/0643d41/html/ : SUCCESS in 3m 04s\n- build-openstack-releasenotes http://logs.openstack.org/61/611861/2/gate/build-openstack-releasenotes/3ea6a8b/html/ : SUCCESS in 2m 19s\n- ipa-tempest-dsvm-partition-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/61/611861/2/gate/ipa-tempest-dsvm-partition-bios-ipmi-direct-tinyipa-src/4e55f8c/ : SUCCESS in 50m 41s\n- ipa-tempest-dsvm-partition-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/61/611861/2/gate/ipa-tempest-dsvm-partition-bios-ipmi-iscsi-tinyipa-src/7afc14c/ : SUCCESS in 49m 16s\n- ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/61/611861/2/gate/ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-tinyipa-src/c84fd84/ : SUCCESS in 56m 17s\n- ipa-tempest-dsvm-wholedisk-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/61/611861/2/gate/ipa-tempest-dsvm-wholedisk-bios-ipmi-iscsi-tinyipa-src/68dcd76/ : SUCCESS in 53m 08s\n- openstack-tox-lower-constraints http://logs.openstack.org/61/611861/2/gate/openstack-tox-lower-constraints/756b7c2/ : SUCCESS in 2m 55s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8eecadb0a8a36eb541b96d6d2fcce12dbb121181","revisions":{"4aa433d251148cd761b63e39b73727a7e0cbc2ad":{"kind":"REWORK","_number":1,"created":"2018-10-19 13:06:14.000000000","uploader":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"ref":"refs/changes/61/611861/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/61/611861/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/611861/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/611861/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/611861/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/611861/1"}}},"commit":{"parents":[{"commit":"c6ea17d413ec5e379e7eb9dcef39f5181a36380c","subject":"Add missing dependencies to CoreOS IPA docker image","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c6ea17d413ec5e379e7eb9dcef39f5181a36380c"}]}],"author":{"name":"Pierre Riteau","email":"pierre@stackhpc.com","date":"2018-10-19 12:43:43.000000000","tz":60},"committer":{"name":"Pierre Riteau","email":"pierre@stackhpc.com","date":"2018-10-19 12:43:43.000000000","tz":60},"subject":"Fix BMC IP address detection on CoreOS images","message":"Fix BMC IP address detection on CoreOS images\n\nOn CoreOS images, IPA runs in a Debian Jessie chroot which uses mawk as\nits default awk implementation. However, mawk doesn\u0027t support POSIX\ncharacter classes such as [:space:], which means get_bmc_address() fails\nto parse the BMC IP address from the output of ipmitool.\n\nThis patch replaces the use of [[:space:]] by [ \\t] which is equivalent\nfor the purpose of parsing the output of ipmitool. Note that matching on\ntab characters is not strictly required as the packaged version of\nipmitool only uses space characters, but is left in case tabs are used\nin other versions.\n\nChange-Id: I0e3306a4d4584ca28e03608e9f7270b770960a39\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4aa433d251148cd761b63e39b73727a7e0cbc2ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4aa433d251148cd761b63e39b73727a7e0cbc2ad"}]},"branch":"refs/heads/master"},"8eecadb0a8a36eb541b96d6d2fcce12dbb121181":{"kind":"REWORK","_number":2,"created":"2018-10-19 13:23:40.000000000","uploader":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"ref":"refs/changes/61/611861/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/61/611861/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/611861/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/611861/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/611861/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/611861/2"}}},"commit":{"parents":[{"commit":"c6ea17d413ec5e379e7eb9dcef39f5181a36380c","subject":"Add missing dependencies to CoreOS IPA docker image","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c6ea17d413ec5e379e7eb9dcef39f5181a36380c"}]}],"author":{"name":"Pierre Riteau","email":"pierre@stackhpc.com","date":"2018-10-19 13:22:05.000000000","tz":60},"committer":{"name":"Pierre Riteau","email":"pierre@stackhpc.com","date":"2018-10-19 13:22:05.000000000","tz":60},"subject":"Fix BMC IP address detection on CoreOS images","message":"Fix BMC IP address detection on CoreOS images\n\nOn CoreOS images, IPA runs in a Debian Jessie chroot which uses mawk as\nits default awk implementation. However, mawk doesn\u0027t support POSIX\ncharacter classes such as [:space:], which means get_bmc_address() fails\nto parse the BMC IP address from the output of ipmitool.\n\nThis patch replaces the use of [[:space:]] by [ \\t] which is equivalent\nfor the purpose of parsing the output of ipmitool. Note that matching on\ntab characters is not strictly required as the packaged version of\nipmitool only uses space characters, but is left in case tabs are used\nin other versions.\n\nChange-Id: I0e3306a4d4584ca28e03608e9f7270b770960a39\nStory: #2004121\nTask: #27571\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8eecadb0a8a36eb541b96d6d2fcce12dbb121181"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8eecadb0a8a36eb541b96d6d2fcce12dbb121181"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}