)]}'
{"ironic_python_agent/agent.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"93fa552230ed8cd23f93a6339e9fb5ee1f3a6330","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            invoke_kwds\u003d{\u0027agent\u0027: self},"},{"line_number":179,"context_line":"        )"},{"line_number":180,"context_line":"        self.api_url \u003d api_url"},{"line_number":181,"context_line":"        if self.api_url \u003d\u003d \u0027mdns\u0027:"},{"line_number":182,"context_line":"            self.api_url, params \u003d mdns.get_endpoint(\u0027baremetal\u0027)"},{"line_number":183,"context_line":"            config.override(params)"},{"line_number":184,"context_line":"        if self.api_url:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_63f2a49c","line":181,"updated":"2019-05-29 10:55:55.000000000","message":"This means the image either needs to be tuned to explicitly do this.  thought we were going to take an approach \"if not defined, try mdns\" ?","commit_id":"a829870cb9e6f0732f5ec3c99d427af011fa9c47"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8329117a02b9edff08f4bd905b8e4a3f58cea0c4","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            invoke_kwds\u003d{\u0027agent\u0027: self},"},{"line_number":179,"context_line":"        )"},{"line_number":180,"context_line":"        self.api_url \u003d api_url"},{"line_number":181,"context_line":"        if self.api_url \u003d\u003d \u0027mdns\u0027:"},{"line_number":182,"context_line":"            self.api_url, params \u003d mdns.get_endpoint(\u0027baremetal\u0027)"},{"line_number":183,"context_line":"            config.override(params)"},{"line_number":184,"context_line":"        if self.api_url:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_f45888fa","line":181,"in_reply_to":"bfb3d3c7_63f2a49c","updated":"2019-05-29 13:34:00.000000000","message":"Right, I\u0027ve re-read the RFE and it\u0027s there. I\u0027ll change it when I finish the local testing.","commit_id":"a829870cb9e6f0732f5ec3c99d427af011fa9c47"}],"ironic_python_agent/config.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"dcc4d13e7da79c460ff37a1565a621be47d5b563","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    LOG.debug(\u0027Overriding configuration with %s\u0027, params)"},{"line_number":240,"context_line":"    for key, value in params.items():"},{"line_number":241,"context_line":"        if key.startswith(\u0027ipa_\u0027):"},{"line_number":242,"context_line":"            key \u003d key[4:]"},{"line_number":243,"context_line":"        else:"},{"line_number":244,"context_line":"            LOG.warning(\u0027Skipping unknown configuration option %s\u0027, key)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_b2f2f96e","line":241,"range":{"start_line":241,"start_character":27,"end_line":241,"end_character":31},"updated":"2019-05-31 07:02:09.000000000","message":"This should be \u0027ipa-\u0027? We expect config names as \u0027ipa-\u0027. See [1] \nBut I observe, in last Ironic patch which enable \u0027mdns\u0027 we set the variable as \u0027ipa_\u0027 [2]. Was it deliberate or oversight?\nAlso in Ironic, at [2] can we pass everything in \u0027pxe_append_params\u0027 to zeroconf registration instead of just debug flag? This code will take care of filtering out kernel params and apply IPA configs.   \n\n[1] https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/config.py\n[2] https://github.com/openstack/ironic/blob/master/ironic/conductor/base_manager.py#L580-L582","commit_id":"5c5328ccaabd0e6dfe8c4658b4ff738adcaba768"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c7b8c251066951df371f636a944fb862e3643f7b","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    LOG.debug(\u0027Overriding configuration with %s\u0027, params)"},{"line_number":240,"context_line":"    for key, value in params.items():"},{"line_number":241,"context_line":"        if key.startswith(\u0027ipa_\u0027):"},{"line_number":242,"context_line":"            key \u003d key[4:]"},{"line_number":243,"context_line":"        else:"},{"line_number":244,"context_line":"            LOG.warning(\u0027Skipping unknown configuration option %s\u0027, key)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_2d76ae71","line":241,"range":{"start_line":241,"start_character":27,"end_line":241,"end_character":31},"in_reply_to":"bfb3d3c7_b2f2f96e","updated":"2019-05-31 07:26:38.000000000","message":"The `ipa-` prefix is specific to kernel options, it\u0027s not related to how we treat options here. We could support dashes, but it would mean doing s/-/_/ below, which is simply more code. The canonical names of the options have underscores.\n\n\u003e can we pass everything in \u0027pxe_append_params\u0027 to zeroconf registration\n\nStrictly speaking, it\u0027s not PXE. So at the very least we need to rename this parameter. Currently you can use [mdns]params as per RFE https://storyboard.openstack.org/#!/story/2005393","commit_id":"5c5328ccaabd0e6dfe8c4658b4ff738adcaba768"}],"ironic_python_agent/inspector.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"93fa552230ed8cd23f93a6339e9fb5ee1f3a6330","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        LOG.info(\u0027Inspection is disabled, skipping\u0027)"},{"line_number":65,"context_line":"        return"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    if CONF.inspection_callback_url \u003d\u003d \u0027mdns\u0027:"},{"line_number":68,"context_line":"        LOG.debug(\u0027Fetching the inspection URL from mDNS\u0027)"},{"line_number":69,"context_line":"        url, params \u003d mdns.get_endpoint(\u0027baremetal-introspection\u0027)"},{"line_number":70,"context_line":"        # We expect a proper catalog URL, which doesn\u0027t include any path."}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_e333f460","line":67,"updated":"2019-05-29 10:55:55.000000000","message":"Ditto for this, fallback to instead of explicit decision?","commit_id":"a829870cb9e6f0732f5ec3c99d427af011fa9c47"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a401092e1edd9ca51d4c21ee548a9f0bbdbccdf7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        LOG.info(\u0027Inspection is disabled, skipping\u0027)"},{"line_number":65,"context_line":"        return"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    if CONF.inspection_callback_url \u003d\u003d \u0027mdns\u0027:"},{"line_number":68,"context_line":"        LOG.debug(\u0027Fetching the inspection URL from mDNS\u0027)"},{"line_number":69,"context_line":"        url, params \u003d mdns.get_endpoint(\u0027baremetal-introspection\u0027)"},{"line_number":70,"context_line":"        # We expect a proper catalog URL, which doesn\u0027t include any path."}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_da532d6a","line":67,"in_reply_to":"bfb3d3c7_145c3ceb","updated":"2019-05-29 15:00:12.000000000","message":"I think we should always try and check in.... I think","commit_id":"a829870cb9e6f0732f5ec3c99d427af011fa9c47"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8329117a02b9edff08f4bd905b8e4a3f58cea0c4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        LOG.info(\u0027Inspection is disabled, skipping\u0027)"},{"line_number":65,"context_line":"        return"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    if CONF.inspection_callback_url \u003d\u003d \u0027mdns\u0027:"},{"line_number":68,"context_line":"        LOG.debug(\u0027Fetching the inspection URL from mDNS\u0027)"},{"line_number":69,"context_line":"        url, params \u003d mdns.get_endpoint(\u0027baremetal-introspection\u0027)"},{"line_number":70,"context_line":"        # We expect a proper catalog URL, which doesn\u0027t include any path."}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_145c3ceb","line":67,"in_reply_to":"bfb3d3c7_e333f460","updated":"2019-05-29 13:34:00.000000000","message":"Currently no endpoint means \"inspection disabled\". Are we sure we want to change that?","commit_id":"a829870cb9e6f0732f5ec3c99d427af011fa9c47"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1af27355c3c669917fbd5703040fe7a4b7e96bed","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        CONF.set_override(\u0027inspection_callback_url\u0027,"},{"line_number":72,"context_line":"                          url.rstrip(\u0027/\u0027) + \u0027/v1/continue\u0027)"},{"line_number":73,"context_line":"        config.override(params)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    collector_names \u003d [x.strip() for x in CONF.inspection_collectors.split(\u0027,\u0027)"},{"line_number":76,"context_line":"                       if x.strip()]"},{"line_number":77,"context_line":"    LOG.info(\u0027inspection is enabled with collectors %s\u0027, collector_names)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_ab0ff185","line":74,"updated":"2019-05-30 20:25:29.000000000","message":"Note to other reviewers: Dmitry is going to think about auto-fallback if not defined to attempt to use mdns, which has an added bonus of being able to use singular image builds without special configuration being edited or passed. I\u0027m okay with coming back to that after the initial patch.","commit_id":"5c5328ccaabd0e6dfe8c4658b4ff738adcaba768"}]}