)]}'
{"id":"openstack%2Fironic-python-agent~654431","triplet_id":"openstack%2Fironic-python-agent~stable%2Fstein~I92c5bfa65ba149687f61172c2a89ff38660a58cf","project":"openstack/ironic-python-agent","branch":"stable/stein","topic":"opendev-u-c-stein","hashtags":[],"change_id":"I92c5bfa65ba149687f61172c2a89ff38660a58cf","subject":"Fetch upper constraints from opendev.org","status":"MERGED","created":"2019-04-22 11:50:52.000000000","updated":"2019-04-29 14:22:43.000000000","submitted":"2019-04-29 14:22:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"654431-1556547763204-332a2ac9","meta_rev_id":"9906f16a9d9f46bfc56e2b33977221df8f6996d3","_number":654431,"virtual_id_number":654431,"owner":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-04-25 10:34:43.000000000","_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":2,"date":"2019-04-29 14:22:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":0,"_account_id":23999,"name":"Kostiantyn Ovchynnykov","email":"kovchynnykov@mirantis.com"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2019-04-29 14:04:44.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"date":"2019-04-23 10:37:25.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-04-22 13:38:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":1,"date":"2019-04-22 12:23:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23999,"name":"Kostiantyn Ovchynnykov","email":"kovchynnykov@mirantis.com"},{"value":2,"date":"2019-04-25 11:54:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":0,"date":"2019-04-23 09:03:46.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":1,"date":"2019-04-29 14:04:44.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":0,"_account_id":23999,"name":"Kostiantyn Ovchynnykov","email":"kovchynnykov@mirantis.com"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":0,"_account_id":23999,"name":"Kostiantyn Ovchynnykov","email":"kovchynnykov@mirantis.com"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":23999,"name":"Kostiantyn Ovchynnykov","email":"kovchynnykov@mirantis.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-22 12:23:40.000000000","updated_by":{"_account_id":23999,"name":"Kostiantyn Ovchynnykov","email":"kovchynnykov@mirantis.com"},"reviewer":{"_account_id":23999,"name":"Kostiantyn Ovchynnykov","email":"kovchynnykov@mirantis.com"},"state":"REVIEWER"},{"updated":"2019-04-22 13:38:33.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2019-04-23 09:03:46.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2019-04-23 10:37:25.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2019-04-25 11:54:11.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-04-29 14:04:44.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2019-04-29 14:22:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e7b26cee78076493a632bdbad73e89a7810bbdfe","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2019-04-22 11:50:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3b6ce8e4f43952233c1fbd2f7b0edfa4cf793106","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-22 11:59:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/31/654431/1/check/openstack-tox-pep8/49949d6/ : SUCCESS in 2m 50s\n- openstack-tox-py27 http://logs.openstack.org/31/654431/1/check/openstack-tox-py27/9e67305/ : SUCCESS in 3m 04s\n- openstack-tox-py35 http://logs.openstack.org/31/654431/1/check/openstack-tox-py35/c3646d6/ : SUCCESS in 3m 09s\n- openstack-tox-py36 http://logs.openstack.org/31/654431/1/check/openstack-tox-py36/a3ceaef/ : SUCCESS in 3m 02s\n- openstack-tox-cover http://logs.openstack.org/31/654431/1/check/openstack-tox-cover/8783b32/cover/ : SUCCESS in 3m 04s\n- openstack-tox-docs http://logs.openstack.org/31/654431/1/check/openstack-tox-docs/a093b22/html/ : SUCCESS in 2m 45s\n- build-openstack-releasenotes http://logs.openstack.org/31/654431/1/check/build-openstack-releasenotes/237b2a9/html/ : SUCCESS in 2m 40s\n- openstack-tox-functional http://logs.openstack.org/31/654431/1/check/openstack-tox-functional/73d4f57/ : SUCCESS in 3m 06s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/31/654431/1/check/openstack-tox-lower-constraints/469e8a4/ : SUCCESS in 3m 10s","accounts_in_message":[],"_revision_number":1},{"id":"3b0129c61a02ceff2fa486ede29917d353e29971","author":{"_account_id":23999,"name":"Kostiantyn Ovchynnykov","email":"kovchynnykov@mirantis.com"},"date":"2019-04-22 12:23:40.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"067970b103f3430d66d75064762e3b2c80fcb292","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2019-04-22 13:38:33.000000000","message":"Patch Set 1: Code-Review+1\n\nThanks!","accounts_in_message":[],"_revision_number":1},{"id":"586dd53ef06d19f4c641f840253635f604846d6a","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-04-23 09:03:39.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5e3592144dfbea4ce377e6e630da4ce232602954","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-04-23 09:08:11.000000000","message":"Patch Set 1:\n\nI\u0027m clearly missing some context, but the commit message talks about generate_upper_constraints.sh, while the commit modifies tox.ini. The value in tox.ini is expected, and should not, ideally, be changed.","accounts_in_message":[],"_revision_number":1},{"id":"6cf013888ece153df0107eeb7894df9ace3509ed","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-04-23 09:34:27.000000000","message":"Patch Set 1:\n\nimagebuild/common/generate_upper_constraints.sh takes the url from tox.ini but curl can\u0027t process the redirect correctly, so changing the url in tox.ini seems like the only viable solution.\nI also believe this is a legitimate change and consistent with the migration to the new repo location.","accounts_in_message":[],"_revision_number":1},{"id":"73ce201c8be01c1fdbd3859c3d98573b37493201","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-04-23 09:41:19.000000000","message":"Patch Set 1:\n\nhttps://releases.openstack.org/constraints/upper/stein is the correct upper-constraints location, that is designed to hide from us cases like moving repositories. If we don\u0027t handle redirects, we need to fix our code, not revert the change that the release team made..","accounts_in_message":[],"_revision_number":1},{"id":"f43ac7fb7eb3a17bc79880b60db51e550e3e4b67","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-04-23 10:22:47.000000000","message":"Patch Set 1:\n\nif that is a common url and supposed to work in all cases, then I agree with you\nIn that case we probably need to consider reverting this change on master:\nhttps://review.opendev.org/654430","accounts_in_message":[],"_revision_number":1},{"id":"bb19d9e73985681917cff8646adc7a55fd981759","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-04-23 10:37:25.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"d47f92c74d0f0738c81adc3a98dbe025df4d7b0f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-04-25 09:46:05.000000000","message":"Patch Set 1: Code-Review-1\n\nAfter IRC discussions, I think this particular link is correct, and we should fix our scripts to allow redirects.","accounts_in_message":[],"_revision_number":1},{"id":"6d8c8187d6c412bdc0b820c4251a9cb88e4868e7","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2019-04-25 10:34:43.000000000","message":"Patch Set 1:\n\nthis link is actually now doing 2 redirects (with different HTTP status):\n\n  $ curl --head https://releases.openstack.org/constraints/upper/master\n  HTTP/1.1 301 Moved Permanently\n  Location: http://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h\u003dmaster\n  \n  $ curl --head http://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h\u003dmaster\n  HTTP/1.1 302 Found\n  Location: https://opendev.org/openstack/requirements/raw/branch/master/upper-constraints.txt\n\nSince we\u0027ll have to make a patch anyway, why not set the correct direct link?\n\nI could add -L to curl invocation too, but using a canonical authoritative link is still proper IMO.","accounts_in_message":[],"_revision_number":1},{"id":"dff952395b296697abada50760356e534cd9b13b","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-04-25 11:54:11.000000000","message":"Patch Set 1: Code-Review+2\n\nOkay, I guess it won\u0027t hurt (unless we migrate again, lol)","accounts_in_message":[],"_revision_number":1},{"id":"28e1b2200f8789756f9affff2d9e68d102eda444","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2019-04-29 14:04:44.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"392bcd3225da57c1229ba2f5efb38f08fe58f9fa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-29 14:04:58.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"dbee9067caf2fafe84e4277139b36890caca4293","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-29 14:22:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/31/654431/1/gate/openstack-tox-pep8/c0db96d/ : SUCCESS in 2m 57s\n- openstack-tox-py27 http://logs.openstack.org/31/654431/1/gate/openstack-tox-py27/8be992d/ : SUCCESS in 3m 44s\n- openstack-tox-py35 http://logs.openstack.org/31/654431/1/gate/openstack-tox-py35/5f577f8/ : SUCCESS in 3m 31s\n- openstack-tox-py36 http://logs.openstack.org/31/654431/1/gate/openstack-tox-py36/bc1916f/ : SUCCESS in 2m 59s\n- openstack-tox-docs http://logs.openstack.org/31/654431/1/gate/openstack-tox-docs/028f9e5/html/ : SUCCESS in 3m 19s\n- build-openstack-releasenotes http://logs.openstack.org/31/654431/1/gate/build-openstack-releasenotes/8d907a5/html/ : SUCCESS in 2m 44s\n- openstack-tox-lower-constraints http://logs.openstack.org/31/654431/1/gate/openstack-tox-lower-constraints/fc8242c/ : SUCCESS in 3m 42s","accounts_in_message":[],"_revision_number":1},{"id":"8eccff536eb124be59570961c9909f574ec967fd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-29 14:22:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fb14edb1c20c52611f0b9669e7fc630082952430","revisions":{"fb14edb1c20c52611f0b9669e7fc630082952430":{"kind":"REWORK","_number":1,"created":"2019-04-22 11:50:52.000000000","uploader":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"ref":"refs/changes/31/654431/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/31/654431/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/31/654431/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/31/654431/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/31/654431/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/31/654431/1"}}},"commit":{"parents":[{"commit":"fa9c7612fbfb3effdfd4f3e5cddca085d77efa88","subject":"Update UPPER_CONSTRAINTS_FILE for stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fa9c7612fbfb3effdfd4f3e5cddca085d77efa88"}]}],"author":{"name":"Pavlo Shchelokovskyy","email":"shchelokovskyy@gmail.com","date":"2019-04-22 11:42:59.000000000","tz":180},"committer":{"name":"Pavlo Shchelokovskyy","email":"shchelokovskyy@gmail.com","date":"2019-04-22 11:50:16.000000000","tz":180},"subject":"Fetch upper constraints from opendev.org","message":"Fetch upper constraints from opendev.org\n\nthe imagebuild/common/generate_upper_constraints.sh\nis currently failing as the curl command in this file does not\nhandle redirects.\n\nInstead of allowing redirects, use the proper current link to the\nupper constraints file.\n\nChange-Id: I92c5bfa65ba149687f61172c2a89ff38660a58cf\n(cherry picked from commit 93dae93d52c8eec10d4e94f16b460443075ec129)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fb14edb1c20c52611f0b9669e7fc630082952430"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fb14edb1c20c52611f0b9669e7fc630082952430"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
