)]}'
{"ironic_python_agent/inspector.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"844d3c9faabc2a2b37d8a6b20cfba5eda1b2448b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                         verify\u003dverify, cert\u003dcert)"},{"line_number":119,"context_line":"    if resp.status_code \u003e\u003d 400:"},{"line_number":120,"context_line":"        LOG.error(\u0027inspector %s error %d: %s, proceeding with lookup\u0027,"},{"line_number":121,"context_line":"                  CONF.inspection_callback_url,"},{"line_number":122,"context_line":"                  resp.status_code, resp.content.decode(\u0027utf-8\u0027))"},{"line_number":123,"context_line":"        return"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_f46745e8","line":121,"range":{"start_line":121,"start_character":18,"end_line":121,"end_character":46},"updated":"2019-05-14 00:09:40.000000000","message":"It seems this info already printed in L109, the default logging level can show the url.","commit_id":"a2d25de6397ef3232a921fe074747ea2c518debf"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"214baf3dc4ad197da66ccf6154829146e6431b4d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                         verify\u003dverify, cert\u003dcert)"},{"line_number":119,"context_line":"    if resp.status_code \u003e\u003d 400:"},{"line_number":120,"context_line":"        LOG.error(\u0027inspector %s error %d: %s, proceeding with lookup\u0027,"},{"line_number":121,"context_line":"                  CONF.inspection_callback_url,"},{"line_number":122,"context_line":"                  resp.status_code, resp.content.decode(\u0027utf-8\u0027))"},{"line_number":123,"context_line":"        return"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_cc062dcf","line":121,"range":{"start_line":121,"start_character":18,"end_line":121,"end_character":46},"in_reply_to":"dfbec78f_8c06f51b","updated":"2019-05-14 13:09:08.000000000","message":"OK, if the info and error message could be separated, this seems reasonable.","commit_id":"a2d25de6397ef3232a921fe074747ea2c518debf"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"7aec6a626fbe338499848dd8bb1d9a9bfb689a37","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                         verify\u003dverify, cert\u003dcert)"},{"line_number":119,"context_line":"    if resp.status_code \u003e\u003d 400:"},{"line_number":120,"context_line":"        LOG.error(\u0027inspector %s error %d: %s, proceeding with lookup\u0027,"},{"line_number":121,"context_line":"                  CONF.inspection_callback_url,"},{"line_number":122,"context_line":"                  resp.status_code, resp.content.decode(\u0027utf-8\u0027))"},{"line_number":123,"context_line":"        return"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_8c06f51b","line":121,"range":{"start_line":121,"start_character":18,"end_line":121,"end_character":46},"in_reply_to":"dfbec78f_f46745e8","updated":"2019-05-14 12:53:18.000000000","message":"Yes, you\u0027re right. As I said in the commit message, the fact that the URL is not in the actual error message means that it can be harder to debug (for example, the info message can become separated from the error in the logs).\n\nI could remove the info line above, if you think that would be better.","commit_id":"a2d25de6397ef3232a921fe074747ea2c518debf"}]}