)]}'
{"id":"openstack%2Fironic-python-agent~663720","triplet_id":"openstack%2Fironic-python-agent~master~If6484847a16f938c80523f0b7ec6ae52ea9cf598","project":"openstack/ironic-python-agent","branch":"master","topic":"software_raid_create_delete_followup","hashtags":[],"change_id":"If6484847a16f938c80523f0b7ec6ae52ea9cf598","subject":"Software RAID: Don\u0027t preformat log strings","status":"MERGED","created":"2019-06-06 16:34:41.000000000","updated":"2019-06-08 12:32:53.000000000","submitted":"2019-06-08 12:32:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"663720-1559997173660-48a02ede","meta_rev_id":"85ed209364f68e4dddee22983d0ab4476015d30b","_number":663720,"virtual_id_number":663720,"owner":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-06-08 12:32:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-08 11:04:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2019-06-07 21:50:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-08 11:04:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-07 21:50:37.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2019-06-08 11:04:22.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-06-08 12:32:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"085b34db81bd05f2b768253c499b98818f581652","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2019-06-06 16:34:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"60c3dcdc56757ce400d3285f9f28b684adb925dc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-06 18:27:20.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/20/663720/1/check/openstack-tox-pep8/b15f71d/ : SUCCESS in 2m 41s\n- openstack-tox-py27 http://logs.openstack.org/20/663720/1/check/openstack-tox-py27/1abaa6d/ : FAILURE in 3m 20s\n- openstack-tox-py36 http://logs.openstack.org/20/663720/1/check/openstack-tox-py36/c7f880b/ : SUCCESS in 3m 32s\n- openstack-tox-cover http://logs.openstack.org/20/663720/1/check/openstack-tox-cover/676be08/ : FAILURE in 4m 04s\n- openstack-tox-docs http://logs.openstack.org/20/663720/1/check/openstack-tox-docs/586afc7/html/ : SUCCESS in 4m 23s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/20/663720/1/check/ipa-tempest-partition-bios-ipmi-direct-tinyipa-src/5645b63/ : SUCCESS in 1h 00m 47s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/20/663720/1/check/ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src/187d025/ : SUCCESS in 58m 58s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/20/663720/1/check/ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src/1ee1e80/ : SUCCESS in 1h 06m 26s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/20/663720/1/check/ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src/d9c21e3/ : SUCCESS in 1h 03m 31s\n- ipa-tempest-ironic-inspector-src http://logs.openstack.org/20/663720/1/check/ipa-tempest-ironic-inspector-src/8efd3db/ : SUCCESS in 1h 40m 49s (non-voting)\n- ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-coreos-src http://logs.openstack.org/20/663720/1/check/ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-coreos-src/6f93ab6/ : FAILURE in 57m 26s (non-voting)\n- openstack-tox-functional http://logs.openstack.org/20/663720/1/check/openstack-tox-functional/87920f9/ : SUCCESS in 4m 01s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/20/663720/1/check/openstack-tox-lower-constraints/e96fb28/ : SUCCESS in 3m 04s\n- ipa-tox-bandit http://logs.openstack.org/20/663720/1/check/ipa-tox-bandit/1c991b5/ : FAILURE in 3m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"baff040eca071dd388ce8a46190e970d75018ed4","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2019-06-07 12:55:22.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"efff6be708c46a6d9156f969be153cb74108ca36","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-07 15:18:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/20/663720/2/check/openstack-tox-pep8/651d1a2/ : SUCCESS in 3m 37s\n- openstack-tox-py27 http://logs.openstack.org/20/663720/2/check/openstack-tox-py27/4aeff91/ : SUCCESS in 3m 26s\n- openstack-tox-py36 http://logs.openstack.org/20/663720/2/check/openstack-tox-py36/be94775/ : SUCCESS in 3m 29s\n- openstack-tox-cover http://logs.openstack.org/20/663720/2/check/openstack-tox-cover/fddbc8f/cover/ : SUCCESS in 3m 51s\n- openstack-tox-docs http://logs.openstack.org/20/663720/2/check/openstack-tox-docs/36b204b/html/ : SUCCESS in 3m 24s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/20/663720/2/check/ipa-tempest-partition-bios-ipmi-direct-tinyipa-src/316683a/ : SUCCESS in 1h 04m 44s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/20/663720/2/check/ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src/3926fb2/ : SUCCESS in 1h 07m 08s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/20/663720/2/check/ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src/9ad4b50/ : SUCCESS in 1h 03m 52s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/20/663720/2/check/ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src/058bf32/ : SUCCESS in 1h 04m 45s\n- ipa-tempest-ironic-inspector-src http://logs.openstack.org/20/663720/2/check/ipa-tempest-ironic-inspector-src/c7f4719/ : SUCCESS in 1h 46m 02s (non-voting)\n- ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-coreos-src http://logs.openstack.org/20/663720/2/check/ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-coreos-src/23e2fb3/ : FAILURE in 57m 38s (non-voting)\n- openstack-tox-functional http://logs.openstack.org/20/663720/2/check/openstack-tox-functional/dc6f07d/ : SUCCESS in 4m 04s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/20/663720/2/check/openstack-tox-lower-constraints/2581533/ : SUCCESS in 3m 29s\n- ipa-tox-bandit http://logs.openstack.org/20/663720/2/check/ipa-tox-bandit/7a92b53/ : FAILURE in 3m 37s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"9ba4a8f6785c40022952c1a686618aa471be8cce","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2019-06-07 21:50:37.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"01d3ed18c2defa48dc903c36a0a2c4cd12cf0696","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-06-08 11:04:22.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"075e1af3969b0ad9bb3ea1664e19d90b0137d490","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-08 11:04:34.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"8aed2af085151f62caf6ba7c6bcb0bd5adc5cf92","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-08 12:32:53.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/20/663720/2/gate/openstack-tox-pep8/dfe9ec8/ : SUCCESS in 3m 18s\n- openstack-tox-py27 http://logs.openstack.org/20/663720/2/gate/openstack-tox-py27/81613b9/ : SUCCESS in 3m 23s\n- openstack-tox-py36 http://logs.openstack.org/20/663720/2/gate/openstack-tox-py36/4be1c30/ : SUCCESS in 3m 30s\n- openstack-tox-docs http://logs.openstack.org/20/663720/2/gate/openstack-tox-docs/6d624cc/html/ : SUCCESS in 3m 12s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/20/663720/2/gate/ipa-tempest-partition-bios-ipmi-direct-tinyipa-src/9e06c7e/ : SUCCESS in 59m 07s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/20/663720/2/gate/ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src/c577f4c/ : SUCCESS in 1h 01m 23s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/20/663720/2/gate/ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src/36e6537/ : SUCCESS in 1h 03m 06s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/20/663720/2/gate/ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src/3f623ca/ : SUCCESS in 1h 00m 44s\n- openstack-tox-lower-constraints http://logs.openstack.org/20/663720/2/gate/openstack-tox-lower-constraints/6b0ff0d/ : SUCCESS in 3m 49s","accounts_in_message":[],"_revision_number":2},{"id":"e982eb2c0dd825b21cd90e29fcff08ec0d69c538","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-08 12:32:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5140c3bda21089548734552e8b28adfaa549447c","revisions":{"78feaaa153e4016fe3cfd3d354471631090b9ab6":{"kind":"REWORK","_number":1,"created":"2019-06-06 16:34:41.000000000","uploader":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"ref":"refs/changes/20/663720/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/20/663720/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/20/663720/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/20/663720/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/20/663720/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/20/663720/1"}}},"commit":{"parents":[{"commit":"2e5fb1b5310534f79f704e0128ab46eccf55b30d","subject":"Merge \"Incorporate bandit support in CI\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2e5fb1b5310534f79f704e0128ab46eccf55b30d"}]}],"author":{"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","date":"2019-06-06 15:31:59.000000000","tz":120},"committer":{"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","date":"2019-06-06 16:33:08.000000000","tz":120},"subject":"Software RAID: Don\u0027t preformat log strings","message":"Software RAID: Don\u0027t preformat log strings\n\nRemove the preformatting of log messages to avoid any formatting\nis done when the corresponding log level not enabled.\n\nAdditional nits addressed:\n- make the supported RAID levels a top-level frozenset\n- remove unused return value from validate_configuration\n\nFollow-up to Id20302537f7994982c7584af546a7e7520e9612b\n\nChange-Id: If6484847a16f938c80523f0b7ec6ae52ea9cf598\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/78feaaa153e4016fe3cfd3d354471631090b9ab6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/78feaaa153e4016fe3cfd3d354471631090b9ab6"}]},"branch":"refs/heads/master"},"5140c3bda21089548734552e8b28adfaa549447c":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-06-07 12:55:22.000000000","uploader":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"ref":"refs/changes/20/663720/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/20/663720/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/20/663720/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/20/663720/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/20/663720/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/20/663720/2"}}},"commit":{"parents":[{"commit":"fea7f86e38b9c68b5378a3bbffd649084b5d0cdf","subject":"Software RAID: Fix race in test for get_holder_disks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fea7f86e38b9c68b5378a3bbffd649084b5d0cdf"}]}],"author":{"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","date":"2019-06-06 15:31:59.000000000","tz":120},"committer":{"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","date":"2019-06-07 12:53:47.000000000","tz":120},"subject":"Software RAID: Don\u0027t preformat log strings","message":"Software RAID: Don\u0027t preformat log strings\n\nRemove the preformatting of log messages to avoid any formatting\nis done when the corresponding log level not enabled.\n\nAdditional nits addressed:\n- make the supported RAID levels a top-level frozenset\n- remove unused return value from validate_configuration\n\nFollow-up to Id20302537f7994982c7584af546a7e7520e9612b\n\nChange-Id: If6484847a16f938c80523f0b7ec6ae52ea9cf598\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5140c3bda21089548734552e8b28adfaa549447c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5140c3bda21089548734552e8b28adfaa549447c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}