)]}'
{"id":"openstack%2Fironic-python-agent~663921","triplet_id":"openstack%2Fironic-python-agent~master~Id54d0ade7084363cb3e53752205db9a9d99d0195","project":"openstack/ironic-python-agent","branch":"master","topic":"software_raid_fix_race_in_test","hashtags":[],"change_id":"Id54d0ade7084363cb3e53752205db9a9d99d0195","subject":"Software RAID: Fix race in test for get_holder_disks","status":"MERGED","created":"2019-06-07 12:27:53.000000000","updated":"2019-06-07 16:23:43.000000000","submitted":"2019-06-07 16:23:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"663921-1559924623757-20b3d2df","meta_rev_id":"9a05158c4e4b679df17feff766d6456880c543b5","_number":663921,"virtual_id_number":663921,"owner":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":2,"date":"2019-06-07 16:23:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":2,"date":"2019-06-07 15:11:44.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-07 12:49:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":1,"date":"2019-06-07 15:11:44.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-07 12:49:20.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-06-07 15:11:44.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2019-06-07 16:23:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"05b7fc18963f51dab64b741d2957e0fa930a9a1f","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2019-06-07 12:27:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4e14e14c302f3a6a9642f08cd99e6eebc54d50b5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-07 12:41:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/21/663921/1/check/openstack-tox-pep8/6e26128/ : SUCCESS in 3m 17s\n- openstack-tox-py27 http://logs.openstack.org/21/663921/1/check/openstack-tox-py27/8217d4f/ : SUCCESS in 3m 53s\n- openstack-tox-py36 http://logs.openstack.org/21/663921/1/check/openstack-tox-py36/754789e/ : SUCCESS in 3m 06s\n- openstack-tox-cover http://logs.openstack.org/21/663921/1/check/openstack-tox-cover/4864012/cover/ : SUCCESS in 3m 49s\n- openstack-tox-docs http://logs.openstack.org/21/663921/1/check/openstack-tox-docs/fdda328/html/ : SUCCESS in 3m 26s\n- openstack-tox-functional http://logs.openstack.org/21/663921/1/check/openstack-tox-functional/b0f8b38/ : SUCCESS in 3m 16s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/21/663921/1/check/openstack-tox-lower-constraints/de04c07/ : SUCCESS in 3m 03s","accounts_in_message":[],"_revision_number":1},{"id":"9f1bc0f091b85f29d95b2fcb8777c3ab176a37d8","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-06-07 12:49:20.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ad487a28c11e83e8e6222368c64211895e6ae1cc","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2019-06-07 15:11:44.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nNice catch, thanks Arne!","accounts_in_message":[],"_revision_number":1},{"id":"e8b9e3374237aee5fa53f2e87eb758af15c50215","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-07 15:11:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"af61dbb8f60dc39e92ff04046f285acd3d7a2533","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-07 16:23:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"df5be33962faba8ea67287b6f05da356e9957600","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-07 16:23:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/21/663921/1/gate/openstack-tox-pep8/0fa001e/ : SUCCESS in 2m 49s\n- openstack-tox-py27 http://logs.openstack.org/21/663921/1/gate/openstack-tox-py27/7cee23f/ : SUCCESS in 3m 19s\n- openstack-tox-py36 http://logs.openstack.org/21/663921/1/gate/openstack-tox-py36/6705e0e/ : SUCCESS in 3m 23s\n- openstack-tox-docs http://logs.openstack.org/21/663921/1/gate/openstack-tox-docs/c46c8a8/html/ : SUCCESS in 3m 23s\n- openstack-tox-lower-constraints http://logs.openstack.org/21/663921/1/gate/openstack-tox-lower-constraints/7364d94/ : SUCCESS in 4m 00s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fea7f86e38b9c68b5378a3bbffd649084b5d0cdf","revisions":{"fea7f86e38b9c68b5378a3bbffd649084b5d0cdf":{"kind":"REWORK","_number":1,"created":"2019-06-07 12:27:53.000000000","uploader":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"ref":"refs/changes/21/663921/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/21/663921/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/21/663921/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/21/663921/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/21/663921/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/21/663921/1"}}},"commit":{"parents":[{"commit":"9bf743a768816def4691280c357d55e2d883eae1","subject":"Merge \"Software RAID: Fix shell commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9bf743a768816def4691280c357d55e2d883eae1"}]}],"author":{"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","date":"2019-06-07 12:22:38.000000000","tz":120},"committer":{"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","date":"2019-06-07 12:22:38.000000000","tz":120},"subject":"Software RAID: Fix race in test for get_holder_disks","message":"Software RAID: Fix race in test for get_holder_disks\n\nThe explicit creation of a mock object in one test disturbed\nthe execution of another test (which mock\u0027ed the same object).\nUse a decorator instead.\n\nFollowup to Id20302537f7994982c7584af546a7e7520e9612b\n\nChange-Id: Id54d0ade7084363cb3e53752205db9a9d99d0195\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fea7f86e38b9c68b5378a3bbffd649084b5d0cdf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fea7f86e38b9c68b5378a3bbffd649084b5d0cdf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}