)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a2cb0dd2f0ef4a65cb9355a26c626e017bf5a82a","unresolved":false,"context_lines":[{"line_number":748,"context_line":"            vendor\u003d_get_device_info(interface_name, \u0027net\u0027, \u0027vendor\u0027),"},{"line_number":749,"context_line":"            product\u003d_get_device_info(interface_name, \u0027net\u0027, \u0027device\u0027),"},{"line_number":750,"context_line":"            biosdevname\u003dself.get_bios_given_nic_name(interface_name),"},{"line_number":751,"context_line":"            hostname\u003dnetutils.get_hostname())"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    def get_ipv4_addr(self, interface_id):"},{"line_number":754,"context_line":"        return netutils.get_ipv4_addr(interface_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_663c3dc8","line":751,"updated":"2019-06-07 16:20:41.000000000","message":"super reasonable if your not actively managing the networking directly via something like neutron.","commit_id":"c8bc32d92999ed66c141b09fd2edb436d6501e15"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"47cda73f153c38369f024f7d1cb846e267751109","unresolved":false,"context_lines":[{"line_number":393,"context_line":"    serializable_fields \u003d (\u0027name\u0027, \u0027mac_address\u0027, \u0027ipv4_address\u0027,"},{"line_number":394,"context_line":"                           \u0027ipv6_address\u0027, \u0027has_carrier\u0027, \u0027lldp\u0027,"},{"line_number":395,"context_line":"                           \u0027vendor\u0027, \u0027product\u0027, \u0027client_id\u0027,"},{"line_number":396,"context_line":"                           \u0027biosdevname\u0027, \u0027hostname\u0027)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def __init__(self, name, mac_addr, ipv4_address\u003dNone, ipv6_address\u003dNone,"},{"line_number":399,"context_line":"                 has_carrier\u003dTrue, lldp\u003dNone, vendor\u003dNone, product\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_9d59738f","line":396,"updated":"2019-06-08 11:03:12.000000000","message":"I don\u0027t think it belongs in NetworkInterface since it\u0027s not interface-specific.","commit_id":"bb5d274dc5d2f8199be76772306ec04e8d4f600e"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"ee1b360dd0fd16980ff93efba8a996a10333ca46","unresolved":false,"context_lines":[{"line_number":393,"context_line":"    serializable_fields \u003d (\u0027name\u0027, \u0027mac_address\u0027, \u0027ipv4_address\u0027,"},{"line_number":394,"context_line":"                           \u0027ipv6_address\u0027, \u0027has_carrier\u0027, \u0027lldp\u0027,"},{"line_number":395,"context_line":"                           \u0027vendor\u0027, \u0027product\u0027, \u0027client_id\u0027,"},{"line_number":396,"context_line":"                           \u0027biosdevname\u0027, \u0027hostname\u0027)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def __init__(self, name, mac_addr, ipv4_address\u003dNone, ipv6_address\u003dNone,"},{"line_number":399,"context_line":"                 has_carrier\u003dTrue, lldp\u003dNone, vendor\u003dNone, product\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_26b63840","line":396,"in_reply_to":"9fb8cfa7_9d59738f","updated":"2019-06-09 01:36:28.000000000","message":"Done","commit_id":"bb5d274dc5d2f8199be76772306ec04e8d4f600e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"47cda73f153c38369f024f7d1cb846e267751109","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        hardware_info[\u0027bmc_address\u0027] \u003d self.get_bmc_address()"},{"line_number":601,"context_line":"        hardware_info[\u0027bmc_v6address\u0027] \u003d self.get_bmc_v6address()"},{"line_number":602,"context_line":"        hardware_info[\u0027system_vendor\u0027] \u003d self.get_system_vendor_info()"},{"line_number":603,"context_line":"        hardware_info[\u0027boot\u0027] \u003d self.get_boot_info()"},{"line_number":604,"context_line":"        return hardware_info"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"    def get_clean_steps(self, node, ports):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_bd5eb773","line":603,"updated":"2019-06-08 11:03:12.000000000","message":"... we may just have it as a top-level item here","commit_id":"bb5d274dc5d2f8199be76772306ec04e8d4f600e"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"ee1b360dd0fd16980ff93efba8a996a10333ca46","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        hardware_info[\u0027bmc_address\u0027] \u003d self.get_bmc_address()"},{"line_number":601,"context_line":"        hardware_info[\u0027bmc_v6address\u0027] \u003d self.get_bmc_v6address()"},{"line_number":602,"context_line":"        hardware_info[\u0027system_vendor\u0027] \u003d self.get_system_vendor_info()"},{"line_number":603,"context_line":"        hardware_info[\u0027boot\u0027] \u003d self.get_boot_info()"},{"line_number":604,"context_line":"        return hardware_info"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"    def get_clean_steps(self, node, ports):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_46b32c4e","line":603,"in_reply_to":"9fb8cfa7_bd5eb773","updated":"2019-06-09 01:36:28.000000000","message":"Done","commit_id":"bb5d274dc5d2f8199be76772306ec04e8d4f600e"}],"ironic_python_agent/netutils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a2cb0dd2f0ef4a65cb9355a26c626e017bf5a82a","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        return None"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"# Other options... "},{"line_number":234,"context_line":"# 1. import os; os.uname()[1]"},{"line_number":235,"context_line":"# 2. import platform; platform.node()"},{"line_number":236,"context_line":"def get_hostname():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_46181974","line":233,"updated":"2019-06-07 16:20:41.000000000","message":"nit: whitespace","commit_id":"c8bc32d92999ed66c141b09fd2edb436d6501e15"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a2cb0dd2f0ef4a65cb9355a26c626e017bf5a82a","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"# Other options... "},{"line_number":234,"context_line":"# 1. import os; os.uname()[1]"},{"line_number":235,"context_line":"# 2. import platform; platform.node()"},{"line_number":236,"context_line":"def get_hostname():"},{"line_number":237,"context_line":"    return socket.gethostname()"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_e6282d87","line":235,"updated":"2019-06-07 16:20:41.000000000","message":"Huh?","commit_id":"c8bc32d92999ed66c141b09fd2edb436d6501e15"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9d5c90b8c4051df3e341bb74ca96f9b9478624bb","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"# Other options... "},{"line_number":234,"context_line":"# 1. import os; os.uname()[1]"},{"line_number":235,"context_line":"# 2. import platform; platform.node()"},{"line_number":236,"context_line":"def get_hostname():"},{"line_number":237,"context_line":"    return socket.gethostname()"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_294936cf","line":235,"in_reply_to":"9fb8cfa7_e6282d87","updated":"2019-06-07 17:31:06.000000000","message":"https://docs.python.org/3/library/platform.html#platform.node","commit_id":"c8bc32d92999ed66c141b09fd2edb436d6501e15"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"47cda73f153c38369f024f7d1cb846e267751109","unresolved":false,"context_lines":[{"line_number":233,"context_line":"# Other options..."},{"line_number":234,"context_line":"# 1. import os; os.uname()[1]"},{"line_number":235,"context_line":"# 2. import platform; platform.node()"},{"line_number":236,"context_line":"def get_hostname():"},{"line_number":237,"context_line":"    return socket.gethostname()"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_5d577b59","line":236,"updated":"2019-06-08 11:03:12.000000000","message":"nit: this helper function is not really needed","commit_id":"bb5d274dc5d2f8199be76772306ec04e8d4f600e"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"ee1b360dd0fd16980ff93efba8a996a10333ca46","unresolved":false,"context_lines":[{"line_number":233,"context_line":"# Other options..."},{"line_number":234,"context_line":"# 1. import os; os.uname()[1]"},{"line_number":235,"context_line":"# 2. import platform; platform.node()"},{"line_number":236,"context_line":"def get_hostname():"},{"line_number":237,"context_line":"    return socket.gethostname()"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_86ada4ea","line":236,"in_reply_to":"9fb8cfa7_5d577b59","updated":"2019-06-09 01:36:28.000000000","message":"If it\u0027s all the same to you, I\u0027m going to leave it in. It would negate the need to add a new import to either of the affected source files.","commit_id":"bb5d274dc5d2f8199be76772306ec04e8d4f600e"}],"ironic_python_agent/tests/unit/test_hardware.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"efa5b6fd66af94e71189592d6dc61de99e7d6242","unresolved":false,"context_lines":[{"line_number":1382,"context_line":"        self.assertEqual(3952 * 1024 * 1024, mem.total)"},{"line_number":1383,"context_line":"        self.assertIsNone(mem.physical_mb)"},{"line_number":1384,"context_line":""},{"line_number":1385,"context_line":"    @mock.patch(\u0027netutil.get_hostname\u0027, autospec\u003dTrue)"},{"line_number":1386,"context_line":"    def test_list_hardware_info(self, mocked_get_hostname):"},{"line_number":1387,"context_line":"        self.hardware.list_network_interfaces \u003d mock.Mock()"},{"line_number":1388,"context_line":"        self.hardware.list_network_interfaces.return_value \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_2b702adc","line":1385,"range":{"start_line":1385,"start_character":17,"end_line":1385,"end_character":24},"updated":"2019-06-11 00:39:49.000000000","message":"netutils","commit_id":"2ead422331ea21424e205b2d6b94d58dca88eb14"}],"releasenotes/notes/add-hostname-8bbf24712b6a4919.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2b7a646e44973a8fe14150a14993399809fcdfcc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add the hostname to the introspection data. This will likely be the"},{"line_number":5,"context_line":"    hostname as set by the DHCP server."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_d1d9e156","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":20},"updated":"2019-06-12 07:18:23.000000000","message":"nit: ``hostname``\nalso maybe add \"of the inspected host\" or something like that","commit_id":"e40ef67a2cc8a0e220a5384f4c8d9670ea634d13"}]}