)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6905a765becb7cb1903823d354c74cf4812e9cf6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Using the same method from pyudev.Devices is now recommended."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also increasing minimum version of pyudev to 0.18 since we\u0027re"},{"line_number":14,"context_line":"using an exception that is incompatible with prior versions (L313)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0637585241c81a36f69aef8017f1134f5c526eb1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_e31b6818","line":14,"updated":"2019-07-09 08:14:05.000000000","message":"not because of the exception (it\u0027s handled gracefully), but because the Devices class was introduced in 0.18","commit_id":"af62063ca9f5f8900503859772a54ff32875f0bf"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ea8c9463441ebdd15337b4d7c16c814eea4d83b3","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        name \u003d os.path.join(\u0027/dev\u0027, device[\u0027KNAME\u0027])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        try:"},{"line_number":311,"context_line":"            udev \u003d pyudev.Devices.from_device_file(context, name)"},{"line_number":312,"context_line":"        # pyudev started raising another error in 0.18"},{"line_number":313,"context_line":"        except (ValueError, EnvironmentError, pyudev.DeviceNotFoundError) as e:"},{"line_number":314,"context_line":"            LOG.warning(\"Device %(dev)s is inaccessible, skipping... \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_c3ec2c2b","line":311,"updated":"2019-07-09 08:06:52.000000000","message":"It seems that Devices were added in 0.18, so we need to bump the requirements (or handle both versions)","commit_id":"7e6bfcb78eb2112fbdbb8109b28ef69f8ec505f2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ea8c9463441ebdd15337b4d7c16c814eea4d83b3","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        try:"},{"line_number":311,"context_line":"            udev \u003d pyudev.Devices.from_device_file(context, name)"},{"line_number":312,"context_line":"        # pyudev started raising another error in 0.18"},{"line_number":313,"context_line":"        except (ValueError, EnvironmentError, pyudev.DeviceNotFoundError) as e:"},{"line_number":314,"context_line":"            LOG.warning(\"Device %(dev)s is inaccessible, skipping... \""},{"line_number":315,"context_line":"                        \"Error: %(error)s\", {\u0027dev\u0027: name, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_63f3f80b","line":312,"updated":"2019-07-09 08:06:52.000000000","message":".. and then we can remove this hack","commit_id":"7e6bfcb78eb2112fbdbb8109b28ef69f8ec505f2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6905a765becb7cb1903823d354c74cf4812e9cf6","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        try:"},{"line_number":311,"context_line":"            udev \u003d pyudev.Devices.from_device_file(context, name)"},{"line_number":312,"context_line":"        # pyudev started raising another error in 0.18"},{"line_number":313,"context_line":"        except (ValueError, EnvironmentError, pyudev.DeviceNotFoundError) as e:"},{"line_number":314,"context_line":"            LOG.warning(\"Device %(dev)s is inaccessible, skipping... \""},{"line_number":315,"context_line":"                        \"Error: %(error)s\", {\u0027dev\u0027: name, \u0027error\u0027: e})"},{"line_number":316,"context_line":"            extra \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_431d9c0d","line":313,"updated":"2019-07-09 08:14:05.000000000","message":"nit: We can now remove ValueError and EnvironmentError, they were needed for \u003c 0.18","commit_id":"af62063ca9f5f8900503859772a54ff32875f0bf"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d61df80c5148d7dfc8c1007ccb73412086235e0d","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        try:"},{"line_number":311,"context_line":"            udev \u003d pyudev.Devices.from_device_file(context, name)"},{"line_number":312,"context_line":"        # pyudev started raising another error in 0.18"},{"line_number":313,"context_line":"        except pyudev.DeviceNotFoundByFileError as e:"},{"line_number":314,"context_line":"            LOG.warning(\"Device %(dev)s is inaccessible, skipping... \""},{"line_number":315,"context_line":"                        \"Error: %(error)s\", {\u0027dev\u0027: name, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_387e8e19","line":312,"updated":"2019-07-09 10:28:59.000000000","message":"nit: this comment should be removed","commit_id":"2c036ee7e1fc6e65814f658bc32550593da684a8"}]}