)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c46bec5cbcd23b228f80b8e83f4d52e9d6ab3735","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Creates and Reorders the Boot Entry"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of large UEFI systems, when we provision wholedisk images using"},{"line_number":10,"context_line":"boot-option as local, OS deoesn\u0027t boot as the boot entry is not present."},{"line_number":11,"context_line":"So using efibootmgr command we can create the boot entry and reorder"},{"line_number":12,"context_line":"so that OS will boot after we provision the wholedisk images."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_5615193c","line":10,"range":{"start_line":10,"start_character":25,"end_line":10,"end_character":33},"updated":"2019-08-15 03:03:18.000000000","message":"s/ deoesn\u0027t / does not /","commit_id":"854d9c7d70fd5b40d02fba62267b44651afe28a9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c46bec5cbcd23b228f80b8e83f4d52e9d6ab3735","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of large UEFI systems, when we provision wholedisk images using"},{"line_number":10,"context_line":"boot-option as local, OS deoesn\u0027t boot as the boot entry is not present."},{"line_number":11,"context_line":"So using efibootmgr command we can create the boot entry and reorder"},{"line_number":12,"context_line":"so that OS will boot after we provision the wholedisk images."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: I3a5c9337424649f4250af008a101a4a6437ae5cc"},{"line_number":15,"context_line":"Change-Id: I02a1c033d2fa1fdf063594efc7977cfdbe05fb6a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_f62765b5","line":12,"range":{"start_line":11,"start_character":57,"end_line":12,"end_character":61},"updated":"2019-08-15 03:03:18.000000000","message":"Can this be:\ns/ \u0027and reorder so that OS will boot after we provision the wholedisk images.\u0027 / \u0027for the disk where image has been written.\u0027/","commit_id":"854d9c7d70fd5b40d02fba62267b44651afe28a9"}],"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c46bec5cbcd23b228f80b8e83f4d52e9d6ab3735","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        efi_partition \u003d _get_partition(device, uuid\u003defi_system_part_uuid)"},{"line_number":277,"context_line":"        partition \u003d re.findall(r\u0027\\d+\u0027, efi_partition)"},{"line_number":278,"context_line":"        partition_number \u003d partition[0]"},{"line_number":279,"context_line":"        # Trying to delete Previous boot entries if there is a boot entry"},{"line_number":280,"context_line":"        # with name \u0027Boot_OS_Wholedisk\u0027 is already present."},{"line_number":281,"context_line":"        # The below operations will fail if \u0027efibootmgr\u0027 command is not present"},{"line_number":282,"context_line":"        # on the deploy ramdisk."}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_b30fbf37","line":279,"range":{"start_line":279,"start_character":41,"end_line":279,"end_character":48},"updated":"2019-08-15 03:03:18.000000000","message":"nit: s/ entries / entry /","commit_id":"854d9c7d70fd5b40d02fba62267b44651afe28a9"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"8f30a15cafad08f96ec7be3138732113c71f39bc","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        efi_partition \u003d _get_partition(device, uuid\u003defi_system_part_uuid)"},{"line_number":277,"context_line":"        partition \u003d re.findall(r\u0027\\d+\u0027, efi_partition)"},{"line_number":278,"context_line":"        partition_number \u003d partition[0]"},{"line_number":279,"context_line":"        # Trying to delete Previous boot entries if there is a boot entry"},{"line_number":280,"context_line":"        # with name \u0027Boot_OS_Wholedisk\u0027 is already present."},{"line_number":281,"context_line":"        # The below operations will fail if \u0027efibootmgr\u0027 command is not present"},{"line_number":282,"context_line":"        # on the deploy ramdisk."}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_e946bf7b","line":279,"range":{"start_line":279,"start_character":41,"end_line":279,"end_character":48},"in_reply_to":"7faddb67_b30fbf37","updated":"2019-08-29 10:23:29.000000000","message":"Done","commit_id":"854d9c7d70fd5b40d02fba62267b44651afe28a9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f6f5804343cb13b21f995c8054e65caeb3004297","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        try:"},{"line_number":284,"context_line":"            boot_entries, _ \u003d utils.execute(\u0027efibootmgr\u0027, run_as_root\u003dTrue)"},{"line_number":285,"context_line":"            for boot_entry in boot_entries.splitlines():"},{"line_number":286,"context_line":"                if \"Boot_OS_Wholedisk\" in boot_entry:"},{"line_number":287,"context_line":"                    boot_order \u003d (boot_entry.split(\" \")[0]).replace(\"*\", \"\")"},{"line_number":288,"context_line":"                    boot_order_number \u003d boot_order.replace(\"Boot\", \"\")"},{"line_number":289,"context_line":"                    utils.execute(\u0027efibootmgr\u0027, \u0027-B\u0027, \u0027-b\u0027, boot_order_number,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_d03b8636","line":286,"range":{"start_line":286,"start_character":18,"end_line":286,"end_character":38},"updated":"2019-08-27 18:57:10.000000000","message":"Where does this come from? Hopefully we\u0027re not stating it someplace?!?","commit_id":"854d9c7d70fd5b40d02fba62267b44651afe28a9"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"8f30a15cafad08f96ec7be3138732113c71f39bc","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        try:"},{"line_number":284,"context_line":"            boot_entries, _ \u003d utils.execute(\u0027efibootmgr\u0027, run_as_root\u003dTrue)"},{"line_number":285,"context_line":"            for boot_entry in boot_entries.splitlines():"},{"line_number":286,"context_line":"                if \"Boot_OS_Wholedisk\" in boot_entry:"},{"line_number":287,"context_line":"                    boot_order \u003d (boot_entry.split(\" \")[0]).replace(\"*\", \"\")"},{"line_number":288,"context_line":"                    boot_order_number \u003d boot_order.replace(\"Boot\", \"\")"},{"line_number":289,"context_line":"                    utils.execute(\u0027efibootmgr\u0027, \u0027-B\u0027, \u0027-b\u0027, boot_order_number,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_492cb3ab","line":286,"range":{"start_line":286,"start_character":18,"end_line":286,"end_character":38},"in_reply_to":"7faddb67_d03b8636","updated":"2019-08-29 10:23:29.000000000","message":"Earlier if we have provisioned the bare metal with this local boot ironic fix, it creates the boot entry \u0027Boot_OS_Wholedisk\u0027, here we are checking if that boot entry is already present in the boot order list then we are deleting that boot entry","commit_id":"854d9c7d70fd5b40d02fba62267b44651afe28a9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c46bec5cbcd23b228f80b8e83f4d52e9d6ab3735","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                    boot_order_number \u003d boot_order.replace(\"Boot\", \"\")"},{"line_number":289,"context_line":"                    utils.execute(\u0027efibootmgr\u0027, \u0027-B\u0027, \u0027-b\u0027, boot_order_number,"},{"line_number":290,"context_line":"                                  run_as_root\u003dTrue)"},{"line_number":291,"context_line":"            # Creates the boot entry"},{"line_number":292,"context_line":"            utils.execute(\u0027efibootmgr\u0027, \u0027--create\u0027, \u0027--disk\u0027, efi_partition,"},{"line_number":293,"context_line":"                          \u0027--part\u0027, partition_number,"},{"line_number":294,"context_line":"                          \u0027--loader\u0027, \u0027/EFI/Boot/bootx64.efi\u0027, \u0027--label\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_3303cf12","line":291,"range":{"start_line":291,"start_character":26,"end_line":291,"end_character":36},"updated":"2019-08-15 03:03:18.000000000","message":"s/ \u0027boot entry\u0027/ \u0027boot entry and put it at the top of the boot order list.\u0027/","commit_id":"854d9c7d70fd5b40d02fba62267b44651afe28a9"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"8f30a15cafad08f96ec7be3138732113c71f39bc","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                    boot_order_number \u003d boot_order.replace(\"Boot\", \"\")"},{"line_number":289,"context_line":"                    utils.execute(\u0027efibootmgr\u0027, \u0027-B\u0027, \u0027-b\u0027, boot_order_number,"},{"line_number":290,"context_line":"                                  run_as_root\u003dTrue)"},{"line_number":291,"context_line":"            # Creates the boot entry"},{"line_number":292,"context_line":"            utils.execute(\u0027efibootmgr\u0027, \u0027--create\u0027, \u0027--disk\u0027, efi_partition,"},{"line_number":293,"context_line":"                          \u0027--part\u0027, partition_number,"},{"line_number":294,"context_line":"                          \u0027--loader\u0027, \u0027/EFI/Boot/bootx64.efi\u0027, \u0027--label\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_a9068720","line":291,"range":{"start_line":291,"start_character":26,"end_line":291,"end_character":36},"in_reply_to":"7faddb67_3303cf12","updated":"2019-08-29 10:23:29.000000000","message":"Done","commit_id":"854d9c7d70fd5b40d02fba62267b44651afe28a9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c46bec5cbcd23b228f80b8e83f4d52e9d6ab3735","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            # Creates the boot entry"},{"line_number":292,"context_line":"            utils.execute(\u0027efibootmgr\u0027, \u0027--create\u0027, \u0027--disk\u0027, efi_partition,"},{"line_number":293,"context_line":"                          \u0027--part\u0027, partition_number,"},{"line_number":294,"context_line":"                          \u0027--loader\u0027, \u0027/EFI/Boot/bootx64.efi\u0027, \u0027--label\u0027,"},{"line_number":295,"context_line":"                          \u0027Boot_OS_Wholedisk\u0027)"},{"line_number":296,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":297,"context_line":"            error_msg \u003d (\u0027efibootmgr command is not executable.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_16048114","line":294,"range":{"start_line":294,"start_character":39,"end_line":294,"end_character":60},"updated":"2019-08-15 03:03:18.000000000","message":"Will this work for Windows?","commit_id":"854d9c7d70fd5b40d02fba62267b44651afe28a9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f6f5804343cb13b21f995c8054e65caeb3004297","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            # Creates the boot entry"},{"line_number":292,"context_line":"            utils.execute(\u0027efibootmgr\u0027, \u0027--create\u0027, \u0027--disk\u0027, efi_partition,"},{"line_number":293,"context_line":"                          \u0027--part\u0027, partition_number,"},{"line_number":294,"context_line":"                          \u0027--loader\u0027, \u0027/EFI/Boot/bootx64.efi\u0027, \u0027--label\u0027,"},{"line_number":295,"context_line":"                          \u0027Boot_OS_Wholedisk\u0027)"},{"line_number":296,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":297,"context_line":"            error_msg \u003d (\u0027efibootmgr command is not executable.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_5028f6ec","line":294,"range":{"start_line":294,"start_character":39,"end_line":294,"end_character":60},"in_reply_to":"7faddb67_16048114","updated":"2019-08-27 18:57:10.000000000","message":"Or OSX? BSD Unix?","commit_id":"854d9c7d70fd5b40d02fba62267b44651afe28a9"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"8f30a15cafad08f96ec7be3138732113c71f39bc","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            # Creates the boot entry"},{"line_number":292,"context_line":"            utils.execute(\u0027efibootmgr\u0027, \u0027--create\u0027, \u0027--disk\u0027, efi_partition,"},{"line_number":293,"context_line":"                          \u0027--part\u0027, partition_number,"},{"line_number":294,"context_line":"                          \u0027--loader\u0027, \u0027/EFI/Boot/bootx64.efi\u0027, \u0027--label\u0027,"},{"line_number":295,"context_line":"                          \u0027Boot_OS_Wholedisk\u0027)"},{"line_number":296,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":297,"context_line":"            error_msg \u003d (\u0027efibootmgr command is not executable.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_69008f03","line":294,"range":{"start_line":294,"start_character":39,"end_line":294,"end_character":60},"in_reply_to":"7faddb67_16048114","updated":"2019-08-29 10:23:29.000000000","message":"Yes it works for Windows also","commit_id":"854d9c7d70fd5b40d02fba62267b44651afe28a9"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"8f30a15cafad08f96ec7be3138732113c71f39bc","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            # Creates the boot entry"},{"line_number":292,"context_line":"            utils.execute(\u0027efibootmgr\u0027, \u0027--create\u0027, \u0027--disk\u0027, efi_partition,"},{"line_number":293,"context_line":"                          \u0027--part\u0027, partition_number,"},{"line_number":294,"context_line":"                          \u0027--loader\u0027, \u0027/EFI/Boot/bootx64.efi\u0027, \u0027--label\u0027,"},{"line_number":295,"context_line":"                          \u0027Boot_OS_Wholedisk\u0027)"},{"line_number":296,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":297,"context_line":"            error_msg \u003d (\u0027efibootmgr command is not executable.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_94df2237","line":294,"range":{"start_line":294,"start_character":39,"end_line":294,"end_character":60},"in_reply_to":"7faddb67_5028f6ec","updated":"2019-08-29 10:23:29.000000000","message":"I\u0027ve not tested for BSD platform\u0027s but it is working for RHEL,SLES,OEL,Windows. What does OSX mean ?","commit_id":"854d9c7d70fd5b40d02fba62267b44651afe28a9"}]}