)]}'
{"id":"openstack%2Fironic-python-agent~670806","triplet_id":"openstack%2Fironic-python-agent~master~I4ce41b335843e18c67668192d2fccff1c6cdfb92","project":"openstack/ironic-python-agent","branch":"master","topic":"software_raid_delete","hashtags":[],"change_id":"I4ce41b335843e18c67668192d2fccff1c6cdfb92","subject":"Software RAID: Detect component \u0026 holder disks in broken RAIDs","status":"MERGED","created":"2019-07-15 10:28:35.000000000","updated":"2019-07-16 10:07:42.000000000","submitted":"2019-07-16 10:07:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"670806-1563271662453-5870c8eb","meta_rev_id":"221cdeaab877e055a3a2021c55d9180f25a1c1dd","_number":670806,"virtual_id_number":670806,"owner":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-07-16 07:53:11.000000000","_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"value":2,"date":"2019-07-16 10:07:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-15 13:04:53.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-16 08:35:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2019-07-15 13:44:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-16 08:35:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-15 13:04:53.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-15 13:44:17.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2019-07-16 08:35:45.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-07-16 10:07:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"75e21958274da8f9a593f79082af2354ae9e4d05","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2019-07-15 10:28:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b95e0e57dabbbff4f8b2fb407796257bb6894308","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-15 12:16:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/06/670806/1/check/openstack-tox-pep8/1ee8951/ : SUCCESS in 3m 22s\n- openstack-tox-py27 http://logs.openstack.org/06/670806/1/check/openstack-tox-py27/a32708f/ : SUCCESS in 3m 29s\n- openstack-tox-py36 http://logs.openstack.org/06/670806/1/check/openstack-tox-py36/f9f6996/ : SUCCESS in 3m 52s\n- openstack-tox-py37 http://logs.openstack.org/06/670806/1/check/openstack-tox-py37/5891993/ : SUCCESS in 5m 16s\n- openstack-tox-cover http://logs.openstack.org/06/670806/1/check/openstack-tox-cover/e9b011c/cover/ : SUCCESS in 4m 29s\n- openstack-tox-docs http://logs.openstack.org/06/670806/1/check/openstack-tox-docs/8ca7982/html/ : SUCCESS in 3m 50s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/06/670806/1/check/ipa-tempest-partition-bios-ipmi-direct-tinyipa-src/e9b28ed/ : SUCCESS in 1h 08m 22s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/06/670806/1/check/ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src/c723906/ : SUCCESS in 1h 12m 37s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/06/670806/1/check/ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src/50f43de/ : SUCCESS in 1h 08m 04s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/06/670806/1/check/ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src/5596d7b/ : SUCCESS in 1h 10m 48s\n- ipa-tempest-ironic-inspector-src http://logs.openstack.org/06/670806/1/check/ipa-tempest-ironic-inspector-src/29d76aa/ : SUCCESS in 1h 42m 18s (non-voting)\n- metalsmith-integration-ipa-src http://logs.openstack.org/06/670806/1/check/metalsmith-integration-ipa-src/e260fbf/ : SUCCESS in 1h 14m 16s (non-voting)\n- ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-coreos-src http://logs.openstack.org/06/670806/1/check/ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-coreos-src/8a0d58a/ : SUCCESS in 56m 49s (non-voting)\n- openstack-tox-functional http://logs.openstack.org/06/670806/1/check/openstack-tox-functional/b7476d7/ : SUCCESS in 3m 27s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/06/670806/1/check/openstack-tox-lower-constraints/e034697/ : SUCCESS in 5m 05s\n- ipa-tox-bandit http://logs.openstack.org/06/670806/1/check/ipa-tox-bandit/6d98212/ : SUCCESS in 4m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"34fa6c8e96c639cf637a019296f0ee14e67f3e78","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-07-15 13:04:53.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 http://logs.rdoproject.org/06/670806/1/openstack-check/tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001/3068d72/ : SUCCESS in 2h 35m 03s","accounts_in_message":[],"_revision_number":1},{"id":"2cf9b73b52b1ca20eb6bf303859fa974763e0c1d","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-07-15 13:44:17.000000000","message":"Patch Set 1: Code-Review+2\n\nthanks Arne","accounts_in_message":[],"_revision_number":1},{"id":"324e5f843624b6c4478c44fbf486ceb606d22468","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-07-16 07:27:50.000000000","message":"Patch Set 1:\n\nAfter thinking more of this: should we really proceed with anything in the presence of broken RAID devices?\n\nAlso this may need a release note, since a release of IPA has been done since introducing software RAID.","accounts_in_message":[],"_revision_number":1},{"id":"befed41b8883fbdfaa26c195489231fa454e8a6e","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2019-07-16 07:53:11.000000000","message":"Patch Set 1:\n\nThe main intention here is to be able to clean up the md device during cleaning (which we cannot do if we are not in a position to detect the broken the md device).\n\nI don\u0027t think ironic should be responsible for anything beyond this.","accounts_in_message":[],"_revision_number":1},{"id":"b3530db0ddbdac6fccad9be702072147f1928f0c","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-07-16 08:35:45.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nI do think we should be able to abort automated wiping of disks if we detect broken RAID. But this is fine to go.","accounts_in_message":[],"_revision_number":1},{"id":"032f12e43cb7ad691c73c0df3624be2edcda1918","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-16 08:35:57.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"7974c59572a48eb334f8a8e53181c7c95c041735","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-16 10:07:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"e9f8d5362e291e2277e9bbbed7018081782a75cd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-16 10:07:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/06/670806/1/gate/openstack-tox-pep8/10acbaf/ : SUCCESS in 3m 18s\n- openstack-tox-py27 http://logs.openstack.org/06/670806/1/gate/openstack-tox-py27/dc751ef/ : SUCCESS in 3m 37s\n- openstack-tox-py36 http://logs.openstack.org/06/670806/1/gate/openstack-tox-py36/794726f/ : SUCCESS in 4m 06s\n- openstack-tox-py37 http://logs.openstack.org/06/670806/1/gate/openstack-tox-py37/29dad22/ : SUCCESS in 3m 35s\n- openstack-tox-docs http://logs.openstack.org/06/670806/1/gate/openstack-tox-docs/95a3305/html/ : SUCCESS in 4m 46s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/06/670806/1/gate/ipa-tempest-partition-bios-ipmi-direct-tinyipa-src/c7268a7/ : SUCCESS in 1h 02m 08s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/06/670806/1/gate/ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src/11a87e9/ : SUCCESS in 1h 04m 36s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src http://logs.openstack.org/06/670806/1/gate/ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src/220baf3/ : SUCCESS in 1h 03m 05s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src http://logs.openstack.org/06/670806/1/gate/ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src/2649ee7/ : SUCCESS in 1h 13m 24s\n- openstack-tox-lower-constraints http://logs.openstack.org/06/670806/1/gate/openstack-tox-lower-constraints/05f254e/ : SUCCESS in 4m 07s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6d2f9b986c7fd2ccda02494cf1aecf7a277809e3","revisions":{"6d2f9b986c7fd2ccda02494cf1aecf7a277809e3":{"kind":"REWORK","_number":1,"created":"2019-07-15 10:28:35.000000000","uploader":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"ref":"refs/changes/06/670806/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/06/670806/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/06/670806/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/06/670806/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/06/670806/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/06/670806/1"}}},"commit":{"parents":[{"commit":"e33744ac2d28d23e1e7951c50deaf07806665023","subject":"Merge \"manual introspection trigger command\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e33744ac2d28d23e1e7951c50deaf07806665023"}]}],"author":{"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","date":"2019-07-12 12:50:14.000000000","tz":120},"committer":{"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","date":"2019-07-12 16:03:53.000000000","tz":120},"subject":"Software RAID: Detect component \u0026 holder disks in broken RAIDs","message":"Software RAID: Detect component \u0026 holder disks in broken RAIDs\n\nThis patch amends the component and holder disk detection code\nto be able to also extract information from inactive/broken md\ndevices. This may be required in case of broken RAID-0 (which\nwill show up as an empty inactive device after a reboot which\nnone the less keeps its spare devices \u0027in-use\u0027 and prevents\nRAID re-creation).\n\nStory: #2006215\nTask: #35808\nChange-Id: I4ce41b335843e18c67668192d2fccff1c6cdfb92\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6d2f9b986c7fd2ccda02494cf1aecf7a277809e3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6d2f9b986c7fd2ccda02494cf1aecf7a277809e3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}