)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5d864fb18f894010be00d7346e12384a076a385","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"SUPPORTED_SOFTWARE_RAID_LEVELS \u003d frozenset([\u00270\u0027, \u00271\u0027, \u00271+0\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"P_DELIMITER_PATTERN \u003d re.compile(r\u0027^(?:/dev/)?nvme.*$\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def _get_device_info(dev, devclass, field):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_82ea0b71","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":55},"updated":"2019-08-06 09:58:42.000000000","message":"Does this has any advantages over\n\n if \u0027/nvme\u0027 in device:\n\n?","commit_id":"dad8255526d0f9357e4a43c3fa86cc367a86e505"},{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"faf057e1b9fc4bb53f241490d64920a448f785a7","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"SUPPORTED_SOFTWARE_RAID_LEVELS \u003d frozenset([\u00270\u0027, \u00271\u0027, \u00271+0\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"P_DELIMITER_PATTERN \u003d re.compile(r\u0027^(?:/dev/)?nvme.*$\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def _get_device_info(dev, devclass, field):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_2261d705","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":55},"in_reply_to":"7faddb67_82ea0b71","updated":"2019-08-06 10:04:45.000000000","message":"I did this to make future exception insertion easier:\nre.compile(r\u0027^(?:/dev/)?(?:nvme|md).*$\u0027) with no further code change\nBut I agree, no current advantage","commit_id":"dad8255526d0f9357e4a43c3fa86cc367a86e505"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5d864fb18f894010be00d7346e12384a076a385","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"            for device in block_devices:"},{"line_number":1480,"context_line":"                # The partition delimiter for all common harddrives (sd[a-z]+)"},{"line_number":1481,"context_line":"                part_delimiter \u003d \u0027\u0027"},{"line_number":1482,"context_line":"                if P_DELIMITER_PATTERN.match(device.name):"},{"line_number":1483,"context_line":"                    part_delimiter \u003d \u0027p\u0027"},{"line_number":1484,"context_line":"                component_devices.append("},{"line_number":1485,"context_line":"                    device.name + part_delimiter + str(index + 1))"},{"line_number":1486,"context_line":"            raid_level \u003d logical_disk[\u0027raid_level\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_e2e17f9c","line":1483,"range":{"start_line":1482,"start_character":0,"end_line":1483,"end_character":40},"updated":"2019-08-06 09:58:42.000000000","message":"I think this logic needs unit test coverage","commit_id":"dad8255526d0f9357e4a43c3fa86cc367a86e505"},{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"faf057e1b9fc4bb53f241490d64920a448f785a7","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"            for device in block_devices:"},{"line_number":1480,"context_line":"                # The partition delimiter for all common harddrives (sd[a-z]+)"},{"line_number":1481,"context_line":"                part_delimiter \u003d \u0027\u0027"},{"line_number":1482,"context_line":"                if P_DELIMITER_PATTERN.match(device.name):"},{"line_number":1483,"context_line":"                    part_delimiter \u003d \u0027p\u0027"},{"line_number":1484,"context_line":"                component_devices.append("},{"line_number":1485,"context_line":"                    device.name + part_delimiter + str(index + 1))"},{"line_number":1486,"context_line":"            raid_level \u003d logical_disk[\u0027raid_level\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_e2565f2a","line":1483,"range":{"start_line":1482,"start_character":0,"end_line":1483,"end_character":40},"in_reply_to":"7faddb67_e2e17f9c","updated":"2019-08-06 10:04:45.000000000","message":"Agree, was on it :)","commit_id":"dad8255526d0f9357e4a43c3fa86cc367a86e505"}]}