)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"899cb63105cc6376adc9c0ba9974a57fd5d6df6e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes:"},{"line_number":10,"context_line":"- Softraid creation: size_gb unit conversion to default parted unit."},{"line_number":11,"context_line":"- Softraid creation issue when we specify several logical disks."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I13e087611354a35acc2925037f1b10047477d972"},{"line_number":14,"context_line":"Story: 2006352"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7faddb67_0c9b10c9","line":11,"range":{"start_line":11,"start_character":2,"end_line":11,"end_character":64},"updated":"2019-08-15 09:18:23.000000000","message":"Nit: \"... with specific sizes.\"","commit_id":"a7b27a5b1b40b190516520d017e680858b9b37d9"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"899cb63105cc6376adc9c0ba9974a57fd5d6df6e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Fixes:"},{"line_number":10,"context_line":"- Softraid creation: size_gb unit conversion to default parted unit."},{"line_number":11,"context_line":"- Softraid creation issue when we specify several logical disks."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I13e087611354a35acc2925037f1b10047477d972"},{"line_number":14,"context_line":"Story: 2006352"},{"line_number":15,"context_line":"Task: 36118"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7faddb67_acabdcd3","line":12,"updated":"2019-08-15 09:18:23.000000000","message":"I\u0027d add another one:\n\n\"- Softraid creation issue when a logical disk with size_gb is \u0027MAX\u0027 is not last in the list.\"","commit_id":"a7b27a5b1b40b190516520d017e680858b9b37d9"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cb7f080c13e8dd8a32aa4600082ccbf4b8e45788","unresolved":false,"context_lines":[{"line_number":1470,"context_line":"            if psize \u003d\u003d \u0027MAX\u0027:"},{"line_number":1471,"context_line":"                psize \u003d \u0027-1\u0027"},{"line_number":1472,"context_line":"            else:"},{"line_number":1473,"context_line":"                psize \u003d \"%dGiB\" % int(psize)"},{"line_number":1474,"context_line":"            for device in block_devices:"},{"line_number":1475,"context_line":"                try:"},{"line_number":1476,"context_line":"                    LOG.debug(\"Creating partition on {}: {} {}\".format("}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_6c4faf6a","line":1473,"range":{"start_line":1473,"start_character":1,"end_line":1473,"end_character":44},"updated":"2019-08-07 07:33:19.000000000","message":"If I get it right, the actual size will be size_gb - 2048 sectors. Do we care?","commit_id":"ddcd5e44489b8aa3c812529730f287fa1cc236e0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa0a8242977e29dfd77dbcfce3ee64cb4cb7f81d","unresolved":false,"context_lines":[{"line_number":1512,"context_line":""},{"line_number":1513,"context_line":"        # With the partitioning below, the first partition is not"},{"line_number":1514,"context_line":"        # exactly the size_gb provided, but rather the size minus a small"},{"line_number":1515,"context_line":"        # amount (often 2048*512B\u003d1MiB, depending on the disk geometry)."},{"line_number":1516,"context_line":"        # Easier to ignore. Another way could be to use sgdisk, which is really"},{"line_number":1517,"context_line":"        # user-friendly to compute part boundaries automatically, instead of"},{"line_number":1518,"context_line":"        # parted, then convert back to mbr table if needed and possible."}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_89a47608","line":1515,"updated":"2019-08-21 09:22:00.000000000","message":"This sounds problematic, especially if somebody tries to use root device hints with size later.. Should we at least document it?","commit_id":"8ad9267aa03163e67e6797d27a2ddc7e7f378e41"}],"releasenotes/notes/softraid-partitioning-refactor-104b817c3bdc73e3.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"81125a43a63e478b48b8b1c890079091dd357961","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7faddb67_4e2140fc","line":8,"updated":"2019-08-12 08:39:48.000000000","message":"nit: add link to story","commit_id":"c7373f478572384ce1a824e3db58679b5d9cb20d"},{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"e8d9a927bf9ba80258aba0c8f60f77b641079da7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7faddb67_5258f32f","line":8,"in_reply_to":"7faddb67_4e2140fc","updated":"2019-08-13 00:34:48.000000000","message":"Done","commit_id":"c7373f478572384ce1a824e3db58679b5d9cb20d"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"899cb63105cc6376adc9c0ba9974a57fd5d6df6e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    the documentation,"},{"line_number":5,"context_line":"    https://docs.openstack.org/ironic/latest/admin/raid.html#target-raid-configuration,"},{"line_number":6,"context_line":"    size_gb unit is GiB but parted default unit is MB."},{"line_number":7,"context_line":"  - Fixes an issue when creating several raid arrays, due to parted mkpart end"},{"line_number":8,"context_line":"    param not being relative to start param."},{"line_number":9,"context_line":"    https://storyboard.openstack.org/#!/story/2006352"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7faddb67_9124fbc7","line":9,"range":{"start_line":7,"start_character":4,"end_line":9,"end_character":53},"updated":"2019-08-15 09:18:23.000000000","message":"I suggest to be a little more specific here so that users running into this can be sure this is the needed fix.\nHow about:\n\n\"Fixes a RAID creation issue when two logical drives with explicit sizes are given (rather than on with an explicit size and one with size \u0027MAX\u0027).\"\n\nI\u0027d also add another issue this patch fixes, sth like:\n\n\"Fixes a RAID creation issue when a logical drive with size \u0027MAX\u0027 is not last in the list of logical drives.\"","commit_id":"a7b27a5b1b40b190516520d017e680858b9b37d9"}],"releasenotes/notes/softraid-partitioning-refactor.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"dcb57cabe474afd68d3cc413311d6dc7a1f15428","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - From the documentation,"},{"line_number":4,"context_line":"    https://docs.openstack.org/ironic/latest/admin/raid.html#target-raid-configuration,"},{"line_number":5,"context_line":"    size_gb unit is GiB. And parted default unit is MB, not MiB."},{"line_number":6,"context_line":"    So the psize conversion was not correct."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_d65f2573","line":3,"updated":"2019-08-09 08:16:45.000000000","message":"I would start with what this is fixing, something like \"Fixes an issue with....\"\nAnd add any links/references at the end","commit_id":"6a6d468829ffea0350b1a4eb7d341bfbb108e869"}],"releasenotes/notes/softraid-specify-parted-unit.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cb7f080c13e8dd8a32aa4600082ccbf4b8e45788","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    https://docs.openstack.org/ironic/latest/admin/raid.html#target-raid-configuration,"},{"line_number":5,"context_line":"    size_gb unit is GiB. And parted default unit is MB, not MiB."},{"line_number":6,"context_line":"    So, to fix the current unit issue and avoid future confusion,"},{"line_number":7,"context_line":"    we propose to specify the unit to parted directly."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_cc3823d6","line":7,"range":{"start_line":7,"start_character":3,"end_line":7,"end_character":18},"updated":"2019-08-07 07:33:19.000000000","message":"nit: remove \"we propose to\", it will look strange on the final release notes page","commit_id":"ddcd5e44489b8aa3c812529730f287fa1cc236e0"}]}