)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"2ff5cba9640e8d164334d2577bd30635431e910d","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"            try:"},{"line_number":1046,"context_line":"                disk_utils.destroy_disk_metadata(dev.name, node[\u0027uuid\u0027])"},{"line_number":1047,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":1048,"context_line":"                if \u0027/dev/fd0: probing initialization\u0027 in str(e):"},{"line_number":1049,"context_line":"                    LOG.debug(\u0027Ignoring floppy disk device. Device \u0027"},{"line_number":1050,"context_line":"                              \u0027\"%(dev)s\" was unable to be initialized.\u0027,"},{"line_number":1051,"context_line":"                              {\u0027dev\u0027: dev.name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_1899d56b","line":1048,"updated":"2019-08-19 20:10:46.000000000","message":"what if I have two floppy drives? I assume /dev/fd1 applies here?","commit_id":"bbddc4ecf53898296e8c22a5403b7935931b9870"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"aa2cec77dac8df35daa34699017491bfc6c5c658","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"            try:"},{"line_number":1046,"context_line":"                disk_utils.destroy_disk_metadata(dev.name, node[\u0027uuid\u0027])"},{"line_number":1047,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":1048,"context_line":"                if \u0027/dev/fd0: probing initialization\u0027 in str(e):"},{"line_number":1049,"context_line":"                    LOG.debug(\u0027Ignoring floppy disk device. Device \u0027"},{"line_number":1050,"context_line":"                              \u0027\"%(dev)s\" was unable to be initialized.\u0027,"},{"line_number":1051,"context_line":"                              {\u0027dev\u0027: dev.name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_381b7181","line":1048,"in_reply_to":"7faddb67_1899d56b","updated":"2019-08-19 20:48:37.000000000","message":"I guess we could if \"probing initialization\" in str(e) and \"/dev/fd\" in str(e)....","commit_id":"bbddc4ecf53898296e8c22a5403b7935931b9870"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c106473c2a113522ade4c00d240df8f286570315","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"def list_all_block_devices(block_type\u003d\u0027disk\u0027,"},{"line_number":239,"context_line":"                           ignore_raid\u003dFalse,"},{"line_number":240,"context_line":"                           include_floppy\u003dFalse):"},{"line_number":241,"context_line":"    \"\"\"List all physical block devices"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    The switches we use for lsblk: P for KEY\u003d\"value\" output, b for size output"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_cf37b5e4","line":240,"updated":"2019-08-22 11:41:07.000000000","message":"nit: maybe ignore_floppy\u003dTrue for consistency with ignore_raid?","commit_id":"4baf746ed59ed7b40204b089f96aebc852ad247a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c106473c2a113522ade4c00d240df8f286570315","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        if str(device.get(\u0027KNAME\u0027)).startswith(\u0027fd\u0027) and not include_floppy:"},{"line_number":315,"context_line":"            continue"},{"line_number":316,"context_line":"        else:"},{"line_number":317,"context_line":"            LOG.debug(\u0027Ignoring floppy disk device %s\u0027, device)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        # Search for raid in the reply type, as RAID is a"},{"line_number":320,"context_line":"        # disk device, and we should honor it if is present."}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_ef34f1e1","line":317,"updated":"2019-08-22 11:41:07.000000000","message":"On this branch we\u0027re actually including it, should be moved before \u0027continue\u0027","commit_id":"4baf746ed59ed7b40204b089f96aebc852ad247a"}],"releasenotes/notes/handle-fd0-devices-3d1f31c3b34819e8.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c92626ac2b0aa92945036b73b37bd7bb0264bda3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes cleaning operations when floppy disk devices are present on the"},{"line_number":5,"context_line":"    baremetal node."},{"line_number":6,"context_line":"other:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The default ``list_all_block_devices`` hardware manager method has been"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_19df3b0d","line":5,"updated":"2019-08-23 22:20:35.000000000","message":"wonder if it is useful to mention how it was fixed (eg, by skipping, or not trying to clean floppy disk devices)...","commit_id":"b98bc678b9dec6cc630f0d5573e8246464567129"}]}