)]}'
{"playbooks/ironic-python-agent-buildimage/pre.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"bc3a16091d3c36175290609a81cf71a216fefcff","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        name: bindep"},{"line_number":7,"context_line":"      vars:"},{"line_number":8,"context_line":"        bindep_dir: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/diskimage-builder\u0027].src_dir }}\""},{"line_number":9,"context_line":"      when: image_name \u003d\u003d \"dib\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    - name: Install diskimage-builder from pip"},{"line_number":12,"context_line":"      pip:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_1ae66db2","line":9,"updated":"2019-08-22 13:05:33.000000000","message":"this could work - but you can remove dib check and use that onl yon the single job","commit_id":"fb71f0ffb111a54e60201ad7d2dbdb8906ecc663"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"bc3a16091d3c36175290609a81cf71a216fefcff","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      when: image_name \u003d\u003d \"dib\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    - name: Install diskimage-builder from pip"},{"line_number":12,"context_line":"      pip:"},{"line_number":13,"context_line":"        name: diskimage-builder"},{"line_number":14,"context_line":"        extra_args: -c \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/requirements\u0027].src_dir }}/upper-constraints.txt\""},{"line_number":15,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_5aece591","line":12,"updated":"2019-08-22 13:05:33.000000000","message":"why not add this to requirements?","commit_id":"fb71f0ffb111a54e60201ad7d2dbdb8906ecc663"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"211ab6f9309fcd21047d77c3bac76eb18c1af90c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      when: image_name \u003d\u003d \"dib\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    - name: Install diskimage-builder from pip"},{"line_number":12,"context_line":"      pip:"},{"line_number":13,"context_line":"        name: diskimage-builder"},{"line_number":14,"context_line":"        extra_args: -c \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/requirements\u0027].src_dir }}/upper-constraints.txt\""},{"line_number":15,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_553356c5","line":12,"in_reply_to":"7faddb67_5aece591","updated":"2019-08-22 13:22:21.000000000","message":"Hmm, yeah. But it will need to install ironic-python-agent-builder itself, which is probably a good idea.","commit_id":"fb71f0ffb111a54e60201ad7d2dbdb8906ecc663"}],"playbooks/ironic-python-agent-buildimage/run.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"80df65400d3a222050650584f193cede46c7b47c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                  mv ipa-coreos*.tar.gz* UPLOAD_TAR"},{"line_number":55,"context_line":"              ;;"},{"line_number":56,"context_line":"              dib)"},{"line_number":57,"context_line":"                  NAME\u003dipa-{{ image_distro }}-$BRANCH_PATH"},{"line_number":58,"context_line":"                  ironic-python-agent-builder -e dhcp-all-interfaces -o $NAME {{ image_distro }}"},{"line_number":59,"context_line":"                  tar -czf UPLOAD_TAR/$NAME.tar.gz ${NAME}*"},{"line_number":60,"context_line":"                  mv ${NAME}* \"$IPA_SOURCE_DIR/UPLOAD_RAW\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_cf9c7cc1","line":57,"range":{"start_line":57,"start_character":46,"end_line":57,"end_character":58},"updated":"2019-08-23 13:22:51.000000000","message":"I would add braces here","commit_id":"9226263ccba436b2ccb76ff5668336f72a8d082d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e805892f3229523446ecd549913f8087ae7b491c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                  mv ipa-coreos*.tar.gz* UPLOAD_TAR"},{"line_number":55,"context_line":"              ;;"},{"line_number":56,"context_line":"              dib)"},{"line_number":57,"context_line":"                  NAME\u003dipa-{{ image_distro }}-$BRANCH_PATH"},{"line_number":58,"context_line":"                  ironic-python-agent-builder -e dhcp-all-interfaces -o $NAME {{ image_distro }}"},{"line_number":59,"context_line":"                  tar -czf UPLOAD_TAR/$NAME.tar.gz ${NAME}*"},{"line_number":60,"context_line":"                  mv ${NAME}* \"$IPA_SOURCE_DIR/UPLOAD_RAW\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_6f246861","line":57,"range":{"start_line":57,"start_character":46,"end_line":57,"end_character":58},"in_reply_to":"7faddb67_6f3d488d","updated":"2019-08-23 13:34:11.000000000","message":"not for spaces, only, old habit to keep the variable visibly separated from the rest in case normal string interpolation might get weird","commit_id":"9226263ccba436b2ccb76ff5668336f72a8d082d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e303b59f30461e8be90b5a5a9e750557ebb03dea","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                  mv ipa-coreos*.tar.gz* UPLOAD_TAR"},{"line_number":55,"context_line":"              ;;"},{"line_number":56,"context_line":"              dib)"},{"line_number":57,"context_line":"                  NAME\u003dipa-{{ image_distro }}-$BRANCH_PATH"},{"line_number":58,"context_line":"                  ironic-python-agent-builder -e dhcp-all-interfaces -o $NAME {{ image_distro }}"},{"line_number":59,"context_line":"                  tar -czf UPLOAD_TAR/$NAME.tar.gz ${NAME}*"},{"line_number":60,"context_line":"                  mv ${NAME}* \"$IPA_SOURCE_DIR/UPLOAD_RAW\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_6f3d488d","line":57,"range":{"start_line":57,"start_character":46,"end_line":57,"end_character":58},"in_reply_to":"7faddb67_cf9c7cc1","updated":"2019-08-23 13:24:20.000000000","message":"Why? Nothing here has spaces.","commit_id":"9226263ccba436b2ccb76ff5668336f72a8d082d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"80df65400d3a222050650584f193cede46c7b47c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"              ;;"},{"line_number":56,"context_line":"              dib)"},{"line_number":57,"context_line":"                  NAME\u003dipa-{{ image_distro }}-$BRANCH_PATH"},{"line_number":58,"context_line":"                  ironic-python-agent-builder -e dhcp-all-interfaces -o $NAME {{ image_distro }}"},{"line_number":59,"context_line":"                  tar -czf UPLOAD_TAR/$NAME.tar.gz ${NAME}*"},{"line_number":60,"context_line":"                  mv ${NAME}* \"$IPA_SOURCE_DIR/UPLOAD_RAW\""},{"line_number":61,"context_line":"              ;;"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_afcee0b4","line":58,"range":{"start_line":58,"start_character":72,"end_line":58,"end_character":77},"updated":"2019-08-23 13:22:51.000000000","message":"maybe surround this by double quotes ?","commit_id":"9226263ccba436b2ccb76ff5668336f72a8d082d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e805892f3229523446ecd549913f8087ae7b491c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"              ;;"},{"line_number":56,"context_line":"              dib)"},{"line_number":57,"context_line":"                  NAME\u003dipa-{{ image_distro }}-$BRANCH_PATH"},{"line_number":58,"context_line":"                  ironic-python-agent-builder -e dhcp-all-interfaces -o $NAME {{ image_distro }}"},{"line_number":59,"context_line":"                  tar -czf UPLOAD_TAR/$NAME.tar.gz ${NAME}*"},{"line_number":60,"context_line":"                  mv ${NAME}* \"$IPA_SOURCE_DIR/UPLOAD_RAW\""},{"line_number":61,"context_line":"              ;;"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_6fd9c854","line":58,"range":{"start_line":58,"start_character":72,"end_line":58,"end_character":77},"in_reply_to":"7faddb67_2f475021","updated":"2019-08-23 13:34:11.000000000","message":"same thing, old habit, when I have a string variable \"in the wild\" I usually add the double quotes","commit_id":"9226263ccba436b2ccb76ff5668336f72a8d082d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"83f1cbd83bb18c07d9b41959440729b252b3d787","unresolved":false,"context_lines":[{"line_number":55,"context_line":"              ;;"},{"line_number":56,"context_line":"              dib)"},{"line_number":57,"context_line":"                  NAME\u003dipa-{{ image_distro }}-$BRANCH_PATH"},{"line_number":58,"context_line":"                  ironic-python-agent-builder -e dhcp-all-interfaces -o $NAME {{ image_distro }}"},{"line_number":59,"context_line":"                  tar -czf UPLOAD_TAR/$NAME.tar.gz ${NAME}*"},{"line_number":60,"context_line":"                  mv ${NAME}* \"$IPA_SOURCE_DIR/UPLOAD_RAW\""},{"line_number":61,"context_line":"              ;;"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_8fb9a47a","line":58,"range":{"start_line":58,"start_character":72,"end_line":58,"end_character":77},"in_reply_to":"7faddb67_6fd9c854","updated":"2019-08-23 13:55:07.000000000","message":"honestly, I have a different habit :) this file uses both approaches quite extensively (and should be rewritten in ansible honestly)","commit_id":"9226263ccba436b2ccb76ff5668336f72a8d082d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e303b59f30461e8be90b5a5a9e750557ebb03dea","unresolved":false,"context_lines":[{"line_number":55,"context_line":"              ;;"},{"line_number":56,"context_line":"              dib)"},{"line_number":57,"context_line":"                  NAME\u003dipa-{{ image_distro }}-$BRANCH_PATH"},{"line_number":58,"context_line":"                  ironic-python-agent-builder -e dhcp-all-interfaces -o $NAME {{ image_distro }}"},{"line_number":59,"context_line":"                  tar -czf UPLOAD_TAR/$NAME.tar.gz ${NAME}*"},{"line_number":60,"context_line":"                  mv ${NAME}* \"$IPA_SOURCE_DIR/UPLOAD_RAW\""},{"line_number":61,"context_line":"              ;;"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_2f475021","line":58,"range":{"start_line":58,"start_character":72,"end_line":58,"end_character":77},"in_reply_to":"7faddb67_afcee0b4","updated":"2019-08-23 13:24:20.000000000","message":"Same question here","commit_id":"9226263ccba436b2ccb76ff5668336f72a8d082d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"80df65400d3a222050650584f193cede46c7b47c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"              dib)"},{"line_number":57,"context_line":"                  NAME\u003dipa-{{ image_distro }}-$BRANCH_PATH"},{"line_number":58,"context_line":"                  ironic-python-agent-builder -e dhcp-all-interfaces -o $NAME {{ image_distro }}"},{"line_number":59,"context_line":"                  tar -czf UPLOAD_TAR/$NAME.tar.gz ${NAME}*"},{"line_number":60,"context_line":"                  mv ${NAME}* \"$IPA_SOURCE_DIR/UPLOAD_RAW\""},{"line_number":61,"context_line":"              ;;"},{"line_number":62,"context_line":"          esac"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_8f7f6465","line":59,"range":{"start_line":59,"start_character":38,"end_line":59,"end_character":43},"updated":"2019-08-23 13:22:51.000000000","message":"and braces here","commit_id":"9226263ccba436b2ccb76ff5668336f72a8d082d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"80df65400d3a222050650584f193cede46c7b47c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                  NAME\u003dipa-{{ image_distro }}-$BRANCH_PATH"},{"line_number":58,"context_line":"                  ironic-python-agent-builder -e dhcp-all-interfaces -o $NAME {{ image_distro }}"},{"line_number":59,"context_line":"                  tar -czf UPLOAD_TAR/$NAME.tar.gz ${NAME}*"},{"line_number":60,"context_line":"                  mv ${NAME}* \"$IPA_SOURCE_DIR/UPLOAD_RAW\""},{"line_number":61,"context_line":"              ;;"},{"line_number":62,"context_line":"          esac"},{"line_number":63,"context_line":"          ERRORS\u003d0"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_ef8db87c","line":60,"range":{"start_line":60,"start_character":31,"end_line":60,"end_character":46},"updated":"2019-08-23 13:22:51.000000000","message":"also braces here","commit_id":"9226263ccba436b2ccb76ff5668336f72a8d082d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e805892f3229523446ecd549913f8087ae7b491c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                  NAME\u003dipa-{{ image_distro }}-$BRANCH_PATH"},{"line_number":58,"context_line":"                  ironic-python-agent-builder -e dhcp-all-interfaces -o $NAME {{ image_distro }}"},{"line_number":59,"context_line":"                  tar -czf UPLOAD_TAR/$NAME.tar.gz ${NAME}*"},{"line_number":60,"context_line":"                  mv ${NAME}* \"$IPA_SOURCE_DIR/UPLOAD_RAW\""},{"line_number":61,"context_line":"              ;;"},{"line_number":62,"context_line":"          esac"},{"line_number":63,"context_line":"          ERRORS\u003d0"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_4fc96c77","line":60,"range":{"start_line":60,"start_character":31,"end_line":60,"end_character":46},"in_reply_to":"7faddb67_ef5058d8","updated":"2019-08-23 13:34:11.000000000","message":"see other comments","commit_id":"9226263ccba436b2ccb76ff5668336f72a8d082d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e303b59f30461e8be90b5a5a9e750557ebb03dea","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                  NAME\u003dipa-{{ image_distro }}-$BRANCH_PATH"},{"line_number":58,"context_line":"                  ironic-python-agent-builder -e dhcp-all-interfaces -o $NAME {{ image_distro }}"},{"line_number":59,"context_line":"                  tar -czf UPLOAD_TAR/$NAME.tar.gz ${NAME}*"},{"line_number":60,"context_line":"                  mv ${NAME}* \"$IPA_SOURCE_DIR/UPLOAD_RAW\""},{"line_number":61,"context_line":"              ;;"},{"line_number":62,"context_line":"          esac"},{"line_number":63,"context_line":"          ERRORS\u003d0"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_ef5058d8","line":60,"range":{"start_line":60,"start_character":31,"end_line":60,"end_character":46},"in_reply_to":"7faddb67_ef8db87c","updated":"2019-08-23 13:24:20.000000000","message":"This may make sense, although probably not in the CI context","commit_id":"9226263ccba436b2ccb76ff5668336f72a8d082d"}],"zuul.d/ironic-python-agent-jobs.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"bc3a16091d3c36175290609a81cf71a216fefcff","unresolved":false,"context_lines":[{"line_number":89,"context_line":"- job:"},{"line_number":90,"context_line":"    name: ironic-python-agent-buildimage-base"},{"line_number":91,"context_line":"    parent: publish-openstack-artifacts"},{"line_number":92,"context_line":"    pre-run: playbooks/ironic-python-agent-buildimage/pre.yaml"},{"line_number":93,"context_line":"    run: playbooks/ironic-python-agent-buildimage/run.yaml"},{"line_number":94,"context_line":"    post-run: playbooks/ironic-python-agent-buildimage/post.yaml"},{"line_number":95,"context_line":"    timeout: 1800"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_daff7533","line":92,"updated":"2019-08-22 13:05:33.000000000","message":"you can move this down to the dib job","commit_id":"fb71f0ffb111a54e60201ad7d2dbdb8906ecc663"}]}