)]}'
{"ironic_python_agent/tests/unit/extensions/test_iscsi.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"950196ab91b5840ad96f89cabfa8230682d17378","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        self.agent_extension \u003d iscsi.ISCSIExtension()"},{"line_number":290,"context_line":"        self.fake_dev \u003d \u0027/dev/fake\u0027"},{"line_number":291,"context_line":"        self.fake_iqn \u003d \u0027iqn-fake\u0027"},{"line_number":292,"context_line":"        self.rtsmock \u003d mock.patch.object("},{"line_number":293,"context_line":"            iscsi.rtslib_fb, \u0027RTSRoot\u0027,"},{"line_number":294,"context_line":"            side_effect\u003dEnvironmentError(), autospec\u003dTrue)"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0472444c","side":"PARENT","line":292,"updated":"2020-02-05 07:55:55.000000000","message":"Sigh, this is a lesson for us to always use decorators or context managers :(","commit_id":"5e3153825a96f3cd45d2657dd3e96b4722eddd61"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3079fa4f1470fdd85967504bfc26570326f33239","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        iscsi.clean_up(self.fake_dev)"},{"line_number":304,"context_line":"        mock_execute.assert_has_calls(expected)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def test_commands_fail(self, mock_execute):"},{"line_number":307,"context_line":"        mock_execute.side_effect \u003d [processutils.ProcessExecutionError(),"},{"line_number":308,"context_line":"                                    (\u0027\u0027, \u0027\u0027),"},{"line_number":309,"context_line":"                                    processutils.ProcessExecutionError()]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d1a73abb","line":306,"updated":"2020-02-18 21:37:47.000000000","message":"An argument is required here, with the mock on 284.","commit_id":"5a61c0c80d1406fef06da9e36d32cd9bebf156f6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a2572766b5a5c35eb8e637ca271c3b1e0d504ffe","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        mock_destroy.assert_called_once_with(\u0027/dev/fake\u0027, \u0027my_node_uuid\u0027)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"@mock.patch.object(iscsi.rtslib_fb, \u0027RTSRoot\u0027, autospec\u003dTrue)"},{"line_number":285,"context_line":"@mock.patch.object(utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":286,"context_line":"class TestISCSIExtensionCleanUpFallback(base.IronicAgentTest):"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_7d6f2d61","line":284,"updated":"2020-02-19 14:41:08.000000000","message":"you could add the side_effect here","commit_id":"dd721dd22e703454be79f2ecd06a7c339b4bd15d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"14ec953e3b2fd0034ba13d123dd23228da9f9755","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        mock_execute.side_effect \u003d [processutils.ProcessExecutionError(),"},{"line_number":308,"context_line":"                                    (\u0027\u0027, \u0027\u0027),"},{"line_number":309,"context_line":"                                    processutils.ProcessExecutionError()]"},{"line_number":310,"context_line":"        mock_rtslib.side_effect \u003d EnvironmentError()"},{"line_number":311,"context_line":"        expected \u003d [mock.call(\u0027tgtadm\u0027, \u0027--lld\u0027, \u0027iscsi\u0027, \u0027--mode\u0027,"},{"line_number":312,"context_line":"                              \u0027target\u0027, \u0027--op\u0027, \u0027unbind\u0027, \u0027--tid\u0027, \u00271\u0027,"},{"line_number":313,"context_line":"                              \u0027--initiator-address\u0027, \u0027ALL\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_79c42462","line":310,"updated":"2020-02-19 12:00:24.000000000","message":"I think this is incorrect, it makes the test identical to the previous one. Will it work without this line?","commit_id":"dd721dd22e703454be79f2ecd06a7c339b4bd15d"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"3eac6c4a93f087b8646450ef541dd3a3cb23aad6","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        mock_execute.side_effect \u003d [processutils.ProcessExecutionError(),"},{"line_number":308,"context_line":"                                    (\u0027\u0027, \u0027\u0027),"},{"line_number":309,"context_line":"                                    processutils.ProcessExecutionError()]"},{"line_number":310,"context_line":"        mock_rtslib.side_effect \u003d EnvironmentError()"},{"line_number":311,"context_line":"        expected \u003d [mock.call(\u0027tgtadm\u0027, \u0027--lld\u0027, \u0027iscsi\u0027, \u0027--mode\u0027,"},{"line_number":312,"context_line":"                              \u0027target\u0027, \u0027--op\u0027, \u0027unbind\u0027, \u0027--tid\u0027, \u00271\u0027,"},{"line_number":313,"context_line":"                              \u0027--initiator-address\u0027, \u0027ALL\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_ba9a8b5e","line":310,"in_reply_to":"3fa7e38b_79c42462","updated":"2020-02-19 13:56:54.000000000","message":"Well, the executes will return different things in these tests (this is what I told myself when I saw they are now ... \"similar\" ;-).\n\nThe test does not work without this line, no. And if I am not mistaken, the test does now the very same thing it did before I touched it (not a very convincing excuse, I agree).","commit_id":"dd721dd22e703454be79f2ecd06a7c339b4bd15d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a2572766b5a5c35eb8e637ca271c3b1e0d504ffe","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        mock_execute.side_effect \u003d [processutils.ProcessExecutionError(),"},{"line_number":308,"context_line":"                                    (\u0027\u0027, \u0027\u0027),"},{"line_number":309,"context_line":"                                    processutils.ProcessExecutionError()]"},{"line_number":310,"context_line":"        mock_rtslib.side_effect \u003d EnvironmentError()"},{"line_number":311,"context_line":"        expected \u003d [mock.call(\u0027tgtadm\u0027, \u0027--lld\u0027, \u0027iscsi\u0027, \u0027--mode\u0027,"},{"line_number":312,"context_line":"                              \u0027target\u0027, \u0027--op\u0027, \u0027unbind\u0027, \u0027--tid\u0027, \u00271\u0027,"},{"line_number":313,"context_line":"                              \u0027--initiator-address\u0027, \u0027ALL\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_3d87750d","line":310,"in_reply_to":"3fa7e38b_ba9a8b5e","updated":"2020-02-19 14:41:08.000000000","message":"Mmm, you\u0027re right, sorry","commit_id":"dd721dd22e703454be79f2ecd06a7c339b4bd15d"}]}