)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"c594c1d5b1b3a1eec85e6be3444188e362a103d2","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        LOG.warning(\"Path %(path)s is inaccessible, /dev/disk/by-path/* \""},{"line_number":288,"context_line":"                    \"version of block device name is unavailable \""},{"line_number":289,"context_line":"                    \"Cause: %(error)s\", {\u0027path\u0027: disk_by_path_dir, \u0027error\u0027: e})"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    columns \u003d [\u0027KNAME\u0027, \u0027MODEL\u0027, \u0027SIZE\u0027, \u0027ROTA\u0027, \u0027TYPE\u0027]"},{"line_number":292,"context_line":"    report \u003d utils.execute(\u0027lsblk\u0027, \u0027-Pbia\u0027, \u0027-o{}\u0027.format(\u0027,\u0027.join(columns)),"},{"line_number":293,"context_line":"                           check_exit_code\u003d[0])[0]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_a3709141","side":"PARENT","line":290,"updated":"2019-10-14 15:50:31.000000000","message":"I guess I\u0027m missing sth here, but this is not in sync with utils.LSBLK, is it? Would it make sense to have one (frozen) set somewhere with the desired options?","commit_id":"5e3153825a96f3cd45d2657dd3e96b4722eddd61"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e9cb509fda9e913aacca42ed707a33e002c10251","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        LOG.warning(\"Path %(path)s is inaccessible, /dev/disk/by-path/* \""},{"line_number":288,"context_line":"                    \"version of block device name is unavailable \""},{"line_number":289,"context_line":"                    \"Cause: %(error)s\", {\u0027path\u0027: disk_by_path_dir, \u0027error\u0027: e})"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    columns \u003d [\u0027KNAME\u0027, \u0027MODEL\u0027, \u0027SIZE\u0027, \u0027ROTA\u0027, \u0027TYPE\u0027]"},{"line_number":292,"context_line":"    report \u003d utils.execute(\u0027lsblk\u0027, \u0027-Pbia\u0027, \u0027-o{}\u0027.format(\u0027,\u0027.join(columns)),"},{"line_number":293,"context_line":"                           check_exit_code\u003d[0])[0]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_f5f05e68","side":"PARENT","line":290,"in_reply_to":"3fa7e38b_83fb1545","updated":"2020-01-09 16:09:12.000000000","message":"It may not look logical, but what about having two lists in utils, eg:\n- LSBLK_COLUMNS \u003d this set\n- LSBLK_COLUMNS_TO_LOG \u003d LSBLK_COLUMNS + [\u0027UUID\u0027, \u0027PARTUUID\u0027] ?","commit_id":"5e3153825a96f3cd45d2657dd3e96b4722eddd61"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"37ebbb3cb898fc3de85cca4a8026a021cf7d4dc4","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        LOG.warning(\"Path %(path)s is inaccessible, /dev/disk/by-path/* \""},{"line_number":288,"context_line":"                    \"version of block device name is unavailable \""},{"line_number":289,"context_line":"                    \"Cause: %(error)s\", {\u0027path\u0027: disk_by_path_dir, \u0027error\u0027: e})"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    columns \u003d [\u0027KNAME\u0027, \u0027MODEL\u0027, \u0027SIZE\u0027, \u0027ROTA\u0027, \u0027TYPE\u0027]"},{"line_number":292,"context_line":"    report \u003d utils.execute(\u0027lsblk\u0027, \u0027-Pbia\u0027, \u0027-o{}\u0027.format(\u0027,\u0027.join(columns)),"},{"line_number":293,"context_line":"                           check_exit_code\u003d[0])[0]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_83fb1545","side":"PARENT","line":290,"in_reply_to":"3fa7e38b_a3709141","updated":"2019-10-14 16:04:57.000000000","message":"Yeah, the one in utils also has UUID and PARTUUID. Not sure how best to act here, I\u0027d not like to move this list to utils completely (doesn\u0027t look logical to me).","commit_id":"5e3153825a96f3cd45d2657dd3e96b4722eddd61"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"390f58c2b8e0acdd6173c04deef6735532199017","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        LOG.warning(\"Path %(path)s is inaccessible, /dev/disk/by-path/* \""},{"line_number":288,"context_line":"                    \"version of block device name is unavailable \""},{"line_number":289,"context_line":"                    \"Cause: %(error)s\", {\u0027path\u0027: disk_by_path_dir, \u0027error\u0027: e})"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    columns \u003d [\u0027KNAME\u0027, \u0027MODEL\u0027, \u0027SIZE\u0027, \u0027ROTA\u0027, \u0027TYPE\u0027]"},{"line_number":292,"context_line":"    report \u003d utils.execute(\u0027lsblk\u0027, \u0027-Pbia\u0027, \u0027-o{}\u0027.format(\u0027,\u0027.join(columns)),"},{"line_number":293,"context_line":"                           check_exit_code\u003d[0])[0]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_31da8378","side":"PARENT","line":290,"in_reply_to":"3fa7e38b_f5f05e68","updated":"2020-01-09 22:35:16.000000000","message":"The hardware device listing code is entirely modeled around only the five initial facts being loaded and the rest of the data being loaded by python native utilities. Ultimately,, it is likely better to reconcile this for the best case in whatever way minimizes VFS cache hits.That may, or may not be the python utilities. I guess what I\u0027m saying is things were done for a reason.\n\nRegardless, looking at the comment if I s/NOTE/TODO/, then it seems like I would +2 this change as the additional information to troubleshoot outweighs.","commit_id":"5e3153825a96f3cd45d2657dd3e96b4722eddd61"}]}