)]}'
{"ironic_python_agent/extensions/standby.py":[{"author":{"_account_id":31288,"name":"wenhuihu","email":"huwenhui_yewu@cmss.chinamobile.com","username":"huwenhui"},"change_message_id":"8db4ae6e2177b0c80e65934692508c53282b11ea","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            raise errors.CommandExecutionError(error_msg)"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    @base.async_command(\u0027kexec\u0027)"},{"line_number":670,"context_line":"    def kexec(self, kernel_image, ramdisk_image\u003dNone, root_uuid\u003dNone,"},{"line_number":671,"context_line":"              kernel_extra_arguments\u003dNone):"},{"line_number":672,"context_line":"        \"\"\"Execute the new kernel"},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e25ffce2","line":670,"range":{"start_line":670,"start_character":20,"end_line":670,"end_character":32},"updated":"2020-07-28 03:12:32.000000000","message":"A very good idea, but still I have a question, is there any restrictions about the user image? in general,the deploy image is linux(such as ubuntu,centos...), however, if the user image is windows, will it work when running the kexec command？whether this feature can support the windows user image?","commit_id":"2aced0e1674857216c1e3e0747dff6c8f78755ae"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"8a449cbaae2da10a0f455744140d6359ade9556c","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            raise errors.CommandExecutionError(error_msg)"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    @base.async_command(\u0027kexec\u0027)"},{"line_number":670,"context_line":"    def kexec(self, kernel_image, ramdisk_image\u003dNone, root_uuid\u003dNone,"},{"line_number":671,"context_line":"              kernel_extra_arguments\u003dNone):"},{"line_number":672,"context_line":"        \"\"\"Execute the new kernel"},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ee92279f","line":670,"range":{"start_line":670,"start_character":20,"end_line":670,"end_character":32},"in_reply_to":"9f560f44_e25ffce2","updated":"2020-07-29 13:55:21.000000000","message":"I believe kexec can not support windows image, and in the case of linux it also needs compatibility between the kernel of the ramdisk and rootfs of the user image.","commit_id":"2aced0e1674857216c1e3e0747dff6c8f78755ae"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d75c8a9a15f7969c2d88da2deab9ddda1b281156","unresolved":false,"context_lines":[{"line_number":696,"context_line":"        if kernel_arguments:"},{"line_number":697,"context_line":"            kexec_command.append(\u0027--append\u003d\"%s\"\u0027 % kernel_arguments)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        utils.execute(kexec_command)"},{"line_number":700,"context_line":"        utils.execute(\u0027kexec\u0027, \u0027-e\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_88f565cd","line":699,"updated":"2019-10-15 08:19:39.000000000","message":"**kexec_command","commit_id":"2aced0e1674857216c1e3e0747dff6c8f78755ae"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d880c38a4c95b8dc4ab776006cd42f40727a3782","unresolved":false,"context_lines":[{"line_number":696,"context_line":"        if kernel_arguments:"},{"line_number":697,"context_line":"            kexec_command.append(\u0027--append\u003d\"%s\"\u0027 % kernel_arguments)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        utils.execute(kexec_command)"},{"line_number":700,"context_line":"        utils.execute(\u0027kexec\u0027, \u0027-e\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ff07e680","line":699,"in_reply_to":"3fa7e38b_88f565cd","updated":"2019-10-15 22:59:48.000000000","message":"Good catch! Thanks!","commit_id":"2aced0e1674857216c1e3e0747dff6c8f78755ae"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d880c38a4c95b8dc4ab776006cd42f40727a3782","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        if kexec_extra_arguments:"},{"line_number":711,"context_line":"            kexec_command.append(kexec_extra_arguments)"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"        utils.execute(*kexec_command, run_as_root\u003dTrue)"},{"line_number":714,"context_line":"        utils.execute(\u0027kexec\u0027, \u0027-e\u0027, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d4de880f","line":713,"updated":"2019-10-15 22:59:48.000000000","message":"We should likely just fire off sync here. Doing it from the conductor complicates the code way too much.","commit_id":"604dd1fdd2987631b14b59636d868a5cd45902a8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e95638d2ffc0d77dc20ed1ad9b838b78bc6bb03d","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        if kexec_extra_arguments:"},{"line_number":711,"context_line":"            kexec_command.append(kexec_extra_arguments)"},{"line_number":712,"context_line":"        self.sync()"},{"line_number":713,"context_line":"        utils.execute(*kexec_command, run_as_root\u003dTrue)"},{"line_number":714,"context_line":"        utils.execute(\u0027kexec\u0027, \u0027-e\u0027, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ea2b9c91","line":713,"updated":"2019-10-16 09:20:17.000000000","message":"maybe worth wrapping this and the next line in a try-except ?","commit_id":"2ed46f35f06f333f1e99d8b9be9b00902f32dbb2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"efe30fcc7b0de10470a052ab455b05faed168fff","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        if kexec_extra_arguments:"},{"line_number":711,"context_line":"            kexec_command.append(kexec_extra_arguments)"},{"line_number":712,"context_line":"        self.sync()"},{"line_number":713,"context_line":"        utils.execute(*kexec_command, run_as_root\u003dTrue)"},{"line_number":714,"context_line":"        utils.execute(\u0027kexec\u0027, \u0027-e\u0027, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_27f55ecb","line":713,"in_reply_to":"3fa7e38b_ea2b9c91","updated":"2019-10-16 21:06:15.000000000","message":"Yeah, I guess that is likely best to do..\nI had a reason mentally why not but *shrugs*","commit_id":"2ed46f35f06f333f1e99d8b9be9b00902f32dbb2"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"1a8f8134fbc33f7dad9adbb0b3098d8f27358de4","unresolved":false,"context_lines":[{"line_number":695,"context_line":"        :param str kexec_extra_arguments: Extra string to allow the passage of"},{"line_number":696,"context_line":"                                          additional arguments to kexec"},{"line_number":697,"context_line":"                                          command."},{"line_number":698,"context_line":"        \"\"\""},{"line_number":699,"context_line":"        if root_uuid:"},{"line_number":700,"context_line":"            device \u003d hardware.dispatch_to_managers(\u0027get_os_install_device\u0027)"},{"line_number":701,"context_line":"            root_partition \u003d image.get_partition(device, root_uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_36d84f79","line":698,"range":{"start_line":698,"start_character":0,"end_line":698,"end_character":11},"updated":"2020-03-08 11:31:58.000000000","message":"Nit: missing \":raises CommandExecutionError: ...\"","commit_id":"79a54793909715827394a7b079b2005a2ee6e33e"}]}