)]}'
{"id":"openstack%2Fironic-python-agent~693711","triplet_id":"openstack%2Fironic-python-agent~master~I5b54c1f6cfac5fff672245c523b9fb647478edbd","project":"openstack/ironic-python-agent","branch":"master","hashtags":[],"change_id":"I5b54c1f6cfac5fff672245c523b9fb647478edbd","subject":"Do not try to read raw disk data as unicode","status":"MERGED","created":"2019-11-11 15:04:48.000000000","updated":"2019-11-12 16:10:39.000000000","submitted":"2019-11-12 16:08:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"693711-1573574909783-3ed51160","meta_rev_id":"9df3b84838535f301e0d6ed6cb46d0c894009297","_number":693711,"virtual_id_number":693711,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-12 16:08:29.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-11-11 17:45:12.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"all":[{"value":2,"date":"2019-11-12 14:43:23.000000000","_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":2,"date":"2019-11-12 03:19:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-11-12 14:32:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"all":[{"value":1,"date":"2019-11-12 14:43:23.000000000","_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-11 17:45:12.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-11-12 03:19:02.000000000","updated_by":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"reviewer":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"state":"REVIEWER"},{"updated":"2019-11-12 14:32:27.000000000","updated_by":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"reviewer":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"state":"REVIEWER"},{"updated":"2019-11-12 14:43:23.000000000","updated_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"reviewer":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"state":"REVIEWER"},{"updated":"2019-11-12 16:08:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6c8d646283a64fd9f428c29b01c75aa37417f988","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-11-11 15:04:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"916618d6ba990d9879b2310ee69a4c33af280374","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-11 16:48:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/054a7bd8a4424cd1bf59cde4d47a14ad : SUCCESS in 4m 14s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1dc4a9904f9b47f3afaf9cfd0bba6408 : SUCCESS in 5m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/05f929b08efe4d54a4ad455abaca18aa : SUCCESS in 4m 43s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/16975d75047a4b76a34d3c8e7d482ad5 : SUCCESS in 6m 40s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9c20845575ab48f4a0fde8ff8313627f : SUCCESS in 4m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9a5a497d3f714a7f97caac5ffe02b013 : SUCCESS in 8m 58s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/a0ea9dd36b02436b8ae5d06c54df8389 : SUCCESS in 1h 10m 36s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/20e624b6fd00489a8e6276313ca35ef8 : SUCCESS in 1h 15m 31s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/d43be3331bb74041bea53fd50b00c5cf : SUCCESS in 1h 09m 03s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/09ee103e41034115b1bd1d65aca27b40 : SUCCESS in 1h 05m 03s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/fcb7f61919724f008a988627c34b3c22 : SUCCESS in 1h 18m 51s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/bcc2fb4292514f97ae9657d7a61fa916 : SUCCESS in 16m 21s (non-voting)\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/fb41ebeb655d4eab8fc10718c3b07c08 : SUCCESS in 13m 01s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/e9fa92c71c224fb7971f55914eb1e267 : SUCCESS in 1h 37m 33s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/741d376b43fe4bcfaf49af05a377413d : SUCCESS in 1h 28m 32s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/02ec24bb5c7546a4acf45655488bd10c : SUCCESS in 1h 08m 35s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/6779e66d3f81429cb5707d04d635a135 : SUCCESS in 6m 05s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ed63dbb61b89495e9ef88cf9ca05b4a6 : SUCCESS in 5m 05s\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/2054a7f2e7614b56b757d7ad774d4134 : SUCCESS in 5m 12s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"aa945432c47f8508e88177050cfd6104f8b0907d","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-11-11 17:45:12.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 http://logs.rdoproject.org/11/693711/1/openstack-check/tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001/82e91ea/ : SUCCESS in 2h 39m 46s\n- tripleo-rhel-8-buildimage-overcloud-full http://logs.rdoproject.org/11/693711/1/openstack-check/tripleo-rhel-8-buildimage-overcloud-full/0128310/ : SUCCESS in 21m 17s\n- tripleo-rhel-8-buildimage-ironic-python-agent http://logs.rdoproject.org/11/693711/1/openstack-check/tripleo-rhel-8-buildimage-ironic-python-agent/3e7e583/ : SUCCESS in 18m 25s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6da1749c750934488cfcfe2dedcc5fcd6c3efbcb","author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"date":"2019-11-12 03:19:02.000000000","message":"Patch Set 1: Code-Review+2\n\nWould need a release note if we have a release after the regression, but git shows none, so I am going ahead.","accounts_in_message":[],"_revision_number":1},{"id":"356adbcfcb688cda72c65a36a1ff495bb4774efd","author":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"date":"2019-11-12 14:32:27.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"17455467cd95139e328ffb54b6847a7566fcee68","author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"date":"2019-11-12 14:43:23.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThank you Dmitry.","accounts_in_message":[],"_revision_number":1},{"id":"e4482d2fa1b4d2d9c54b4cea536d4a5cfcef52db","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-12 14:43:35.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8ac6000a33870dede0a208d06f7c3e86cad4efe7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-12 16:08:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"b7e30fdaa76b430553cd9ef185027eedf6f185c9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-12 16:08:29.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9a052a93350d4ff3900a9254dbcaf8a3 : SUCCESS in 3m 14s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/35a7c0ba517c428dac3dfcb5a632e4e5 : SUCCESS in 3m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d4e52ee0efa64d01bf41ca7fdf9db4d0 : SUCCESS in 3m 33s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/9e965e6bc47347d0928cd9cd061541e3 : SUCCESS in 5m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a0134c0deeeb408cac732feed5757de9 : SUCCESS in 5m 44s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/d28f86064ae54830af416d1ed247e862 : SUCCESS in 1h 09m 23s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/d6a0f2f2dc3b4f2ab996d489803ae6d4 : SUCCESS in 59m 47s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/7dd895e3d4f2421ea62b91903e9757bd : SUCCESS in 1h 10m 10s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/80e50b07ae064acbb9d1b1a76c77f630 : SUCCESS in 1h 08m 04s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/8ff0b32690bb444bb7619abf784ce5e2 : SUCCESS in 1h 19m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c18d278a209e418eb521739a2f062605 : SUCCESS in 3m 27s","accounts_in_message":[],"_revision_number":1},{"id":"9df3b84838535f301e0d6ed6cb46d0c894009297","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-12 16:10:39.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4350dfa27bf145efa13620ec2898c3fd : SUCCESS in 1m 44s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1d12505fa069bef886ee908a83920aa2afa44298","revisions":{"1d12505fa069bef886ee908a83920aa2afa44298":{"kind":"REWORK","_number":1,"created":"2019-11-11 15:04:48.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/11/693711/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/11/693711/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/693711/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/693711/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/693711/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/693711/1"}}},"commit":{"parents":[{"commit":"11862ccae925904d034cb27b6ed6078fc91e1a09","subject":"Fix instructions for enabling SSH on recent tinyipa images","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/11862ccae925904d034cb27b6ed6078fc91e1a09"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-11-11 15:03:59.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-11-11 15:03:59.000000000","tz":60},"subject":"Do not try to read raw disk data as unicode","message":"Do not try to read raw disk data as unicode\n\nFixes regression in commit 9f8fa2853af00045118ccd44180e7053e6d027af:\nutils.execute returns unicode by default, but this data is binary.\n\nChange-Id: I5b54c1f6cfac5fff672245c523b9fb647478edbd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1d12505fa069bef886ee908a83920aa2afa44298"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1d12505fa069bef886ee908a83920aa2afa44298"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}