)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"f24244ce80c104cc2516b564d21effe04cba7167","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make network-wait-timeout configurable."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For some baremetal servers, it takes more than 90 seconds"},{"line_number":10,"context_line":"to obtain ipaddress with dhcp-interface service. it\u0027s better"},{"line_number":11,"context_line":"to make the network-wait-timeout configurable."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If9b0da28cd2479e996f4d4d6f838049806981330"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_49d35002","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":47},"updated":"2019-11-15 01:41:08.000000000","message":"The description doesn\u0027t coincide with the code change, dhcp timeout is not controlled by the proposed change, it\u0027s another parameter specified when building ramdisk.","commit_id":"99e1edec1d28d61b3c29a7474cef50d717439c31"}],"ironic_python_agent/agent.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"f24244ce80c104cc2516b564d21effe04cba7167","unresolved":false,"context_lines":[{"line_number":45,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":46,"context_line":"CONF \u003d cfg.CONF"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"cfg.CONF.import_group(\u0027metrics\u0027, \u0027ironic_lib.metrics_utils\u0027)"},{"line_number":49,"context_line":"cfg.CONF.import_group(\u0027metrics_statsd\u0027, \u0027ironic_lib.metrics_statsd\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Host \u003d collections.namedtuple(\u0027Host\u0027, [\u0027hostname\u0027, \u0027port\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e99ebc67","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":4},"updated":"2019-11-15 01:41:08.000000000","message":"sidenote: we might want to remove this as we have CONF now.","commit_id":"99e1edec1d28d61b3c29a7474cef50d717439c31"}],"ironic_python_agent/config.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"061b4a3ffd128568eb6d92befe07111892bb52ab","unresolved":false,"context_lines":[{"line_number":187,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-network-wait-retry\u0027,"},{"line_number":188,"context_line":"                                   NETWORK_WAIT_RETRY),"},{"line_number":189,"context_line":"               help\u003d\u0027Interval(in seconds) to wait for the PXE NIC \u0027"},{"line_number":190,"context_line":"                    \u0027to get its IP address via DHCP before communicating \u0027"},{"line_number":191,"context_line":"                    \u0027with ironic. \u0027"},{"line_number":192,"context_line":"                    \u0027Can be supplied as \"ipa-network-wait-retry\" \u0027"},{"line_number":193,"context_line":"                    \u0027kernel parameter.\u0027),"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ea58ff57","line":191,"range":{"start_line":190,"start_character":59,"end_line":191,"end_character":33},"updated":"2019-11-14 04:37:02.000000000","message":"Should it be \u0027before re-attempting\u0027?","commit_id":"206511d0abe0ec43fd95d93a657dd323051dd168"},{"author":{"_account_id":29147,"name":"wangwei1","email":"wangwei1_yewu@cmss.chinamobile.com","username":"wangwei1"},"change_message_id":"115e112b4c51af5f9c918d528c29fb1143a040e0","unresolved":false,"context_lines":[{"line_number":187,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-network-wait-retry\u0027,"},{"line_number":188,"context_line":"                                   NETWORK_WAIT_RETRY),"},{"line_number":189,"context_line":"               help\u003d\u0027Interval(in seconds) to wait for the PXE NIC \u0027"},{"line_number":190,"context_line":"                    \u0027to get its IP address via DHCP before communicating \u0027"},{"line_number":191,"context_line":"                    \u0027with ironic. \u0027"},{"line_number":192,"context_line":"                    \u0027Can be supplied as \"ipa-network-wait-retry\" \u0027"},{"line_number":193,"context_line":"                    \u0027kernel parameter.\u0027),"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a543183f","line":191,"range":{"start_line":190,"start_character":59,"end_line":191,"end_character":33},"in_reply_to":"3fa7e38b_ea58ff57","updated":"2019-11-14 05:47:48.000000000","message":"Oh,I was negligent, thank you very much.","commit_id":"206511d0abe0ec43fd95d93a657dd323051dd168"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f1ab86e4aa7a3a9d5022ae0dbf63f740caeff075","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    cfg.IntOpt(\u0027network_wait_timeout\u0027,"},{"line_number":175,"context_line":"               min\u003d0,"},{"line_number":176,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-network-wait-timeout\u0027,"},{"line_number":177,"context_line":"                                   NETWORK_DEFAULT_WAIT_TIMEOUT),"},{"line_number":178,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for the PXE NIC \u0027"},{"line_number":179,"context_line":"                    \u0027to get its IP address via DHCP before communicating \u0027"},{"line_number":180,"context_line":"                    \u0027with ironic.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_908655ba","line":177,"updated":"2019-11-14 11:31:46.000000000","message":"we should add a default value of 60","commit_id":"f85ba20c4bf46675fd0e61e19a162460982d884d"},{"author":{"_account_id":29147,"name":"wangwei1","email":"wangwei1_yewu@cmss.chinamobile.com","username":"wangwei1"},"change_message_id":"3433bcd7cc4c651b59b5f2fcdfeec264eed620b9","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    cfg.IntOpt(\u0027network_wait_timeout\u0027,"},{"line_number":175,"context_line":"               min\u003d0,"},{"line_number":176,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-network-wait-timeout\u0027,"},{"line_number":177,"context_line":"                                   NETWORK_DEFAULT_WAIT_TIMEOUT),"},{"line_number":178,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for the PXE NIC \u0027"},{"line_number":179,"context_line":"                    \u0027to get its IP address via DHCP before communicating \u0027"},{"line_number":180,"context_line":"                    \u0027with ironic.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_69c3ac8b","line":177,"in_reply_to":"3fa7e38b_908655ba","updated":"2019-11-15 00:58:42.000000000","message":"Hi，I have added a default value at line 31","commit_id":"f85ba20c4bf46675fd0e61e19a162460982d884d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f1ab86e4aa7a3a9d5022ae0dbf63f740caeff075","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    cfg.IntOpt(\u0027network_wait_retry\u0027,"},{"line_number":186,"context_line":"               min\u003d0,"},{"line_number":187,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-network-wait-retry\u0027,"},{"line_number":188,"context_line":"                                   NETWORK_WAIT_RETRY),"},{"line_number":189,"context_line":"               help\u003d\u0027Interval(in seconds) to wait for the PXE NIC \u0027"},{"line_number":190,"context_line":"                    \u0027to get its IP address via DHCP before reattempt.\u0027"},{"line_number":191,"context_line":"                    \u0027Can be supplied as \"ipa-network-wait-retry\" \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_b08111a3","line":188,"updated":"2019-11-14 11:31:46.000000000","message":"we should add a default value of 5","commit_id":"f85ba20c4bf46675fd0e61e19a162460982d884d"},{"author":{"_account_id":29147,"name":"wangwei1","email":"wangwei1_yewu@cmss.chinamobile.com","username":"wangwei1"},"change_message_id":"3433bcd7cc4c651b59b5f2fcdfeec264eed620b9","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    cfg.IntOpt(\u0027network_wait_retry\u0027,"},{"line_number":186,"context_line":"               min\u003d0,"},{"line_number":187,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-network-wait-retry\u0027,"},{"line_number":188,"context_line":"                                   NETWORK_WAIT_RETRY),"},{"line_number":189,"context_line":"               help\u003d\u0027Interval(in seconds) to wait for the PXE NIC \u0027"},{"line_number":190,"context_line":"                    \u0027to get its IP address via DHCP before reattempt.\u0027"},{"line_number":191,"context_line":"                    \u0027Can be supplied as \"ipa-network-wait-retry\" \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_89be28fe","line":188,"in_reply_to":"3fa7e38b_b08111a3","updated":"2019-11-15 00:58:42.000000000","message":"Hi，I have added a default value at line 34","commit_id":"f85ba20c4bf46675fd0e61e19a162460982d884d"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"f24244ce80c104cc2516b564d21effe04cba7167","unresolved":false,"context_lines":[{"line_number":175,"context_line":"               min\u003d0,"},{"line_number":176,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-network-wait-timeout\u0027,"},{"line_number":177,"context_line":"                                   NETWORK_DEFAULT_WAIT_TIMEOUT),"},{"line_number":178,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for the PXE NIC \u0027"},{"line_number":179,"context_line":"                    \u0027to get its IP address via DHCP before communicating \u0027"},{"line_number":180,"context_line":"                    \u0027with ironic.\u0027"},{"line_number":181,"context_line":"                    \u0027Set to 0 to disable waiting completely. \u0027"},{"line_number":182,"context_line":"                    \u0027Can be supplied as \"ipa-network-wait-timeout\" \u0027"},{"line_number":183,"context_line":"                    \u0027kernel parameter.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_49ecb0ba","line":180,"range":{"start_line":178,"start_character":21,"end_line":180,"end_character":32},"updated":"2019-11-15 01:41:08.000000000","message":"The description is incorrect. This is the time that interface will be available to be used, before dhcp request can happen. The default time which is 5 minutes seems quite enough to me though.","commit_id":"99e1edec1d28d61b3c29a7474cef50d717439c31"},{"author":{"_account_id":29147,"name":"wangwei1","email":"wangwei1_yewu@cmss.chinamobile.com","username":"wangwei1"},"change_message_id":"ab40cd49b110498556fce5f97b5e1545c9fc3bf8","unresolved":false,"context_lines":[{"line_number":175,"context_line":"               min\u003d0,"},{"line_number":176,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-network-wait-timeout\u0027,"},{"line_number":177,"context_line":"                                   NETWORK_DEFAULT_WAIT_TIMEOUT),"},{"line_number":178,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for the PXE NIC \u0027"},{"line_number":179,"context_line":"                    \u0027to get its IP address via DHCP before communicating \u0027"},{"line_number":180,"context_line":"                    \u0027with ironic.\u0027"},{"line_number":181,"context_line":"                    \u0027Set to 0 to disable waiting completely. \u0027"},{"line_number":182,"context_line":"                    \u0027Can be supplied as \"ipa-network-wait-timeout\" \u0027"},{"line_number":183,"context_line":"                    \u0027kernel parameter.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_69864cbd","line":180,"range":{"start_line":178,"start_character":21,"end_line":180,"end_character":32},"in_reply_to":"3fa7e38b_49ecb0ba","updated":"2019-11-15 02:02:38.000000000","message":"Hi, do you mean that we can increase the DIB_DHCP_TIMEOUT for dhcp-interface service when building a ramdisk, and IPA will try to connect with ironic periodically?\nThanks!","commit_id":"99e1edec1d28d61b3c29a7474cef50d717439c31"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"bf3794d22485208a36f4509f740770ac79f4f80f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"               min\u003d0,"},{"line_number":176,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-network-wait-timeout\u0027,"},{"line_number":177,"context_line":"                                   NETWORK_DEFAULT_WAIT_TIMEOUT),"},{"line_number":178,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for the PXE NIC \u0027"},{"line_number":179,"context_line":"                    \u0027to get its IP address via DHCP before communicating \u0027"},{"line_number":180,"context_line":"                    \u0027with ironic.\u0027"},{"line_number":181,"context_line":"                    \u0027Set to 0 to disable waiting completely. \u0027"},{"line_number":182,"context_line":"                    \u0027Can be supplied as \"ipa-network-wait-timeout\" \u0027"},{"line_number":183,"context_line":"                    \u0027kernel parameter.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_1b7d8ce6","line":180,"range":{"start_line":178,"start_character":21,"end_line":180,"end_character":32},"in_reply_to":"3fa7e38b_69864cbd","updated":"2019-11-16 03:19:48.000000000","message":"DIB_DHCP_TIMEOUT controls the timeout of dhcp requests, it\u0027s a prerequisite before IPA can talk with ironic. You can take a further look on the element implementation if desired.\n\nhttps://opendev.org/openstack/diskimage-builder/src/branch/master/diskimage_builder/elements/dhcp-all-interfaces/install.d/50-dhcp-all-interfaces","commit_id":"99e1edec1d28d61b3c29a7474cef50d717439c31"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"f24244ce80c104cc2516b564d21effe04cba7167","unresolved":false,"context_lines":[{"line_number":186,"context_line":"               min\u003d0,"},{"line_number":187,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-network-wait-retry\u0027,"},{"line_number":188,"context_line":"                                   NETWORK_WAIT_RETRY),"},{"line_number":189,"context_line":"               help\u003d\u0027Interval(in seconds) to wait for the PXE NIC \u0027"},{"line_number":190,"context_line":"                    \u0027to get its IP address via DHCP before reattempt.\u0027"},{"line_number":191,"context_line":"                    \u0027Can be supplied as \"ipa-network-wait-retry\" \u0027"},{"line_number":192,"context_line":"                    \u0027kernel parameter.\u0027),"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e928fcee","line":190,"range":{"start_line":189,"start_character":21,"end_line":190,"end_character":68},"updated":"2019-11-15 01:41:08.000000000","message":"ditto","commit_id":"99e1edec1d28d61b3c29a7474cef50d717439c31"}],"releasenotes/notes/configurable-network-timeout-b1d30720d9d913d7.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f1ab86e4aa7a3a9d5022ae0dbf63f740caeff075","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Make network-wait-timeout configurable, because for some baremetal"},{"line_number":4,"context_line":"    servers, dhcp-interface service cannot obtain ip address in 90 seconds,"},{"line_number":5,"context_line":"    which will cause connection timeout with ironic-api or ironic-inspector"},{"line_number":6,"context_line":"    in ironic-python-agent."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_10610512","line":3,"updated":"2019-11-14 11:31:46.000000000","message":"please add also reference to network_wait_retry\nalso this doesn\u0027t sound as a fix but more as an upgrade, that will be useful in some use cases","commit_id":"f85ba20c4bf46675fd0e61e19a162460982d884d"},{"author":{"_account_id":29147,"name":"wangwei1","email":"wangwei1_yewu@cmss.chinamobile.com","username":"wangwei1"},"change_message_id":"3433bcd7cc4c651b59b5f2fcdfeec264eed620b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Make network-wait-timeout configurable, because for some baremetal"},{"line_number":4,"context_line":"    servers, dhcp-interface service cannot obtain ip address in 90 seconds,"},{"line_number":5,"context_line":"    which will cause connection timeout with ironic-api or ironic-inspector"},{"line_number":6,"context_line":"    in ironic-python-agent."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_69f64cdb","line":3,"in_reply_to":"3fa7e38b_10610512","updated":"2019-11-15 00:58:42.000000000","message":"Done","commit_id":"f85ba20c4bf46675fd0e61e19a162460982d884d"}]}