)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"58da6efc740662f4ca49070366b16f1b8b13d704","unresolved":false,"context_lines":[{"line_number":14,"context_line":"actually stopped the API."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As setting the flag to stop the API is a hard notification that"},{"line_number":17,"context_line":"the API must now exit, there is no reason to wait and block exit,"},{"line_number":18,"context_line":"hence the simple nature of this change."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Now the threads should exit, IPA should exit, and rescue should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_d5523f68","line":17,"range":{"start_line":17,"start_character":24,"end_line":17,"end_character":65},"updated":"2019-12-09 10:06:49.000000000","message":"Any concurrent request (i.e. ironic checking the command status) may end up interrupted mid-processing, causing broken pipe error and potentially rescue failure.","commit_id":"8aa9b79c46744bcb0221379d26a4147317d63f77"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"65a6ef6b5fd36e0e2167f69045d71945300cc310","unresolved":false,"context_lines":[{"line_number":14,"context_line":"actually stopped the API."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As setting the flag to stop the API is a hard notification that"},{"line_number":17,"context_line":"the API must now exit, there is no reason to wait and block exit,"},{"line_number":18,"context_line":"hence the simple nature of this change."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Now the threads should exit, IPA should exit, and rescue should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_f078a28f","line":17,"range":{"start_line":17,"start_character":24,"end_line":17,"end_character":65},"in_reply_to":"3fa7e38b_d5523f68","updated":"2019-12-09 16:54:00.000000000","message":"That is fine, the contract is immediate exit for serve_api being set to false. Also, the conductor would have an exclusive lock on the operation to back out so really the only user touching the api at that point could be an external party.","commit_id":"8aa9b79c46744bcb0221379d26a4147317d63f77"}]}