)]}'
{"ironic_python_agent/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"23b9603b6c473fe69be0398d116e8df32adc4a52","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        _set_cached_params(params)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # Check to see if any deprecated parameters have been used"},{"line_number":226,"context_line":"        deprecated_params \u003d {\u0027lldp-timeout\u0027: \u0027ipa-lldp-timeout\u0027}"},{"line_number":227,"context_line":"        for old_param, new_param in deprecated_params.items():"},{"line_number":228,"context_line":"            if params.get(old_param) is not None:"},{"line_number":229,"context_line":"                LOG.warning(\"The parameter \u0027%s\u0027 has been deprecated. Please \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5ee0a7f8","side":"PARENT","line":226,"updated":"2020-01-06 19:29:18.000000000","message":"I think it might be nice to keep the code that handles deprecated parameters, for future use. And just change this to be {}. Not sure what others think.","commit_id":"0a55e319ce3a32dda764d2c07afe1ac0fda9edb7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0e68ef2f1e6d763a02c4de9b027d4c22d3b6072c","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        _set_cached_params(params)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # Check to see if any deprecated parameters have been used"},{"line_number":226,"context_line":"        deprecated_params \u003d {\u0027lldp-timeout\u0027: \u0027ipa-lldp-timeout\u0027}"},{"line_number":227,"context_line":"        for old_param, new_param in deprecated_params.items():"},{"line_number":228,"context_line":"            if params.get(old_param) is not None:"},{"line_number":229,"context_line":"                LOG.warning(\"The parameter \u0027%s\u0027 has been deprecated. Please \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_fc0b91d0","side":"PARENT","line":226,"in_reply_to":"3fa7e38b_5ee0a7f8","updated":"2021-01-12 14:42:05.000000000","message":"The deprectated options being from newton, I think it is fair to go ahead and drop this code.","commit_id":"0a55e319ce3a32dda764d2c07afe1ac0fda9edb7"}],"releasenotes/notes/remove-lldp-timeout-ea481dbb01a39522.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"23b9603b6c473fe69be0398d116e8df32adc4a52","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The kernel parameter ``lldp-timeout`` was deprecated and removed, please"},{"line_number":5,"context_line":"    use ``ipa-lldp-timeout`` instead."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_becf5b89","line":5,"updated":"2020-01-06 19:29:18.000000000","message":"I was wondering when lldp-timeout was deprecated. I see in the newton release notes (https://docs.openstack.org/releasenotes/ironic-python-agent/newton.html) mention about ipa-lldp-timeout. But I don\u0027t see anything mentioning that llmd-timeout was deprecated :-(\n\nI guess it is ok to remove it but I am not sure... If we do remove it, we should probably mention that it was replaced with ipa-lldp-timeout in Newton...","commit_id":"26b18914274bcf0f68afa825977376e1caa344b3"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"57745a4ac89a66e83f53b30d1aaedd6598a601f7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The kernel parameter ``lldp-timeout`` was deprecated and removed, please"},{"line_number":5,"context_line":"    use ``ipa-lldp-timeout`` instead."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0c320be9_194d5e55","line":5,"in_reply_to":"3fa7e38b_1c030dc0","updated":"2021-01-15 08:18:34.000000000","message":"Done","commit_id":"26b18914274bcf0f68afa825977376e1caa344b3"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"2f4176f27a2560f421ee9d6d5145a4b729fa6f1f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The kernel parameter ``lldp-timeout`` was deprecated and removed, please"},{"line_number":5,"context_line":"    use ``ipa-lldp-timeout`` instead."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_d477939e","line":5,"in_reply_to":"3fa7e38b_becf5b89","updated":"2020-01-07 02:26:41.000000000","message":"Indeed, my thought is deprecated implies we will remove it some time in the future, while this one is deprecated for quite long.","commit_id":"26b18914274bcf0f68afa825977376e1caa344b3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0e68ef2f1e6d763a02c4de9b027d4c22d3b6072c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The kernel parameter ``lldp-timeout`` was deprecated and removed, please"},{"line_number":5,"context_line":"    use ``ipa-lldp-timeout`` instead."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_1c030dc0","line":5,"in_reply_to":"3fa7e38b_d477939e","updated":"2021-01-12 14:42:05.000000000","message":"+1 for mentioning when it was deprecated.","commit_id":"26b18914274bcf0f68afa825977376e1caa344b3"}]}