)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"3be6f6533a7fd1260926fb4e21ecc6625c7ceb7a","unresolved":false,"context_lines":[{"line_number":1876,"context_line":""},{"line_number":1877,"context_line":"        for extension in extensions:"},{"line_number":1878,"context_line":"            if extension.obj.evaluate_hardware_support() \u003e 0:"},{"line_number":1879,"context_line":"                names.append(extension.name)"},{"line_number":1880,"context_line":"                preferred_managers.append(extension.obj)"},{"line_number":1881,"context_line":"                LOG.info(\u0027Hardware manager found: {}\u0027.format("},{"line_number":1882,"context_line":"                    extension.entry_point_target))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7a758fc8","line":1879,"updated":"2020-01-22 02:08:37.000000000","message":"Instead of extension name, maybe we could use HARDWARE_MANAGER_NAME each manager provides, we also have a base method get_version() which contains an extra version field that might be useful. Not idea which one is better though.","commit_id":"97dc1d99d40eb07f69b34cca1c5c67a85536f627"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f357bbf4a8ede1b33da4ab499489530e8c677a0f","unresolved":false,"context_lines":[{"line_number":1876,"context_line":""},{"line_number":1877,"context_line":"        for extension in extensions:"},{"line_number":1878,"context_line":"            if extension.obj.evaluate_hardware_support() \u003e 0:"},{"line_number":1879,"context_line":"                names.append(extension.name)"},{"line_number":1880,"context_line":"                preferred_managers.append(extension.obj)"},{"line_number":1881,"context_line":"                LOG.info(\u0027Hardware manager found: {}\u0027.format("},{"line_number":1882,"context_line":"                    extension.entry_point_target))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4d801c4a","line":1879,"in_reply_to":"3fa7e38b_7a758fc8","updated":"2020-01-22 08:58:37.000000000","message":"I also like the idea of using HARDWARE_MANAGER_NAME\nwe could give it a try in a follow-up change","commit_id":"97dc1d99d40eb07f69b34cca1c5c67a85536f627"}]}