)]}'
{"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"ee4205e1cb757f61ec4f646b1af689da244776e4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def _rescan_device(device):"},{"line_number":41,"context_line":"    \"\"\"Force the device to be rescanned"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    :param device: device upon which to rescan and update"},{"line_number":44,"context_line":"                   kernel partition records using."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    # Try to tell the kernel to re-read the partition table"},{"line_number":47,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_f642b70e","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":50},"updated":"2020-03-08 11:52:29.000000000","message":"Nit: is this proper English?","commit_id":"5196f4a18ea726a5696439a5671b309c6f070582"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"700bf41f034cd7cc5b0e0d452f84a67da8296958","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def _rescan_device(device):"},{"line_number":41,"context_line":"    \"\"\"Force the device to be rescanned"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    :param device: device upon which to rescan and update"},{"line_number":44,"context_line":"                   kernel partition records using."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    # Try to tell the kernel to re-read the partition table"},{"line_number":47,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_4039143d","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":50},"in_reply_to":"1fa4df85_f642b70e","updated":"2020-03-16 12:57:33.000000000","message":"Fixed, I think.","commit_id":"5196f4a18ea726a5696439a5671b309c6f070582"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"ee4205e1cb757f61ec4f646b1af689da244776e4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    :param device: device upon which to rescan and update"},{"line_number":44,"context_line":"                   kernel partition records using."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    # Try to tell the kernel to re-read the partition table"},{"line_number":47,"context_line":"    try:"},{"line_number":48,"context_line":"        utils.execute(\u0027partx\u0027, \u0027-u\u0027, device, attempts\u003d3,"},{"line_number":49,"context_line":"                      delay_on_retry\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_964d833f","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":59},"updated":"2020-03-08 11:52:29.000000000","message":"Nit: do we need this comment given the length of the function and that it is just below the function\u0027s comment?","commit_id":"5196f4a18ea726a5696439a5671b309c6f070582"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"700bf41f034cd7cc5b0e0d452f84a67da8296958","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    :param device: device upon which to rescan and update"},{"line_number":44,"context_line":"                   kernel partition records using."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    # Try to tell the kernel to re-read the partition table"},{"line_number":47,"context_line":"    try:"},{"line_number":48,"context_line":"        utils.execute(\u0027partx\u0027, \u0027-u\u0027, device, attempts\u003d3,"},{"line_number":49,"context_line":"                      delay_on_retry\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_e047e0bb","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":59},"in_reply_to":"1fa4df85_964d833f","updated":"2020-03-16 12:57:33.000000000","message":"Done","commit_id":"5196f4a18ea726a5696439a5671b309c6f070582"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"ee4205e1cb757f61ec4f646b1af689da244776e4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    # Try to tell the kernel to re-read the partition table"},{"line_number":47,"context_line":"    try:"},{"line_number":48,"context_line":"        utils.execute(\u0027partx\u0027, \u0027-u\u0027, device, attempts\u003d3,"},{"line_number":49,"context_line":"                      delay_on_retry\u003dTrue)"},{"line_number":50,"context_line":"        utils.execute(\u0027udevadm\u0027, \u0027settle\u0027)"},{"line_number":51,"context_line":"    except processutils.ProcessExecutionError:"},{"line_number":52,"context_line":"        LOG.warning(\"Couldn\u0027t re-read the partition table \""},{"line_number":53,"context_line":"                    \"on device %s\", device)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_b648bf2c","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":42},"updated":"2020-03-08 11:52:29.000000000","message":"Is the order of these two commands correct?","commit_id":"5196f4a18ea726a5696439a5671b309c6f070582"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"700bf41f034cd7cc5b0e0d452f84a67da8296958","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    # Try to tell the kernel to re-read the partition table"},{"line_number":47,"context_line":"    try:"},{"line_number":48,"context_line":"        utils.execute(\u0027partx\u0027, \u0027-u\u0027, device, attempts\u003d3,"},{"line_number":49,"context_line":"                      delay_on_retry\u003dTrue)"},{"line_number":50,"context_line":"        utils.execute(\u0027udevadm\u0027, \u0027settle\u0027)"},{"line_number":51,"context_line":"    except processutils.ProcessExecutionError:"},{"line_number":52,"context_line":"        LOG.warning(\"Couldn\u0027t re-read the partition table \""},{"line_number":53,"context_line":"                    \"on device %s\", device)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_a01328b8","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":42},"in_reply_to":"1fa4df85_b648bf2c","updated":"2020-03-16 12:57:33.000000000","message":"Yes, partx performs the rescan, udevadm holds us until the kernel udev has managed to do the needful.","commit_id":"5196f4a18ea726a5696439a5671b309c6f070582"}]}