)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"c7f29d13866f79e89e549747f8b4a13c7f0cc078","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":1532,"context_line":"        block_devices_partitions \u003d self.list_block_devices("},{"line_number":1533,"context_line":"            include_partitions\u003dTrue)"},{"line_number":1534,"context_line":"        # TODO(dtantsur): limit this validation to only the discs involved the"},{"line_number":1535,"context_line":"        # software RAID."},{"line_number":1536,"context_line":"        if len(block_devices) !\u003d len(block_devices_partitions):"},{"line_number":1537,"context_line":"            partitions \u003d \u0027 \u0027.join("},{"line_number":1538,"context_line":"                partition.name for partition in block_devices_partitions)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_944b91ae","line":1535,"range":{"start_line":1534,"start_character":0,"end_line":1535,"end_character":24},"updated":"2020-03-27 10:59:09.000000000","message":"I think this should be changed (or dropped) with this change: beforehand we were assuming all disks can be used for the RAID and we put this in to protect overwriting sth accidentally. With this change it is very likely that there are other devices, so whatever is happening on them should only stop the RAID setup if it is relevant.","commit_id":"ddbba070216233e695f90095334ab7ddaef563f2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"baa35c06357ad989eac9b0b614be5e8a86fb90ac","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":1532,"context_line":"        block_devices_partitions \u003d self.list_block_devices("},{"line_number":1533,"context_line":"            include_partitions\u003dTrue)"},{"line_number":1534,"context_line":"        # TODO(dtantsur): limit this validation to only the discs involved the"},{"line_number":1535,"context_line":"        # software RAID."},{"line_number":1536,"context_line":"        if len(block_devices) !\u003d len(block_devices_partitions):"},{"line_number":1537,"context_line":"            partitions \u003d \u0027 \u0027.join("},{"line_number":1538,"context_line":"                partition.name for partition in block_devices_partitions)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_38597dfd","line":1535,"range":{"start_line":1534,"start_character":0,"end_line":1535,"end_character":24},"in_reply_to":"df33271e_66dbbaec","updated":"2020-04-01 11:05:21.000000000","message":"Follow-up proposed: https://review.opendev.org/#/c/716542/","commit_id":"ddbba070216233e695f90095334ab7ddaef563f2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fe5b3fcee64b2ce2333dd5c28f3206ea5e42705a","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":1532,"context_line":"        block_devices_partitions \u003d self.list_block_devices("},{"line_number":1533,"context_line":"            include_partitions\u003dTrue)"},{"line_number":1534,"context_line":"        # TODO(dtantsur): limit this validation to only the discs involved the"},{"line_number":1535,"context_line":"        # software RAID."},{"line_number":1536,"context_line":"        if len(block_devices) !\u003d len(block_devices_partitions):"},{"line_number":1537,"context_line":"            partitions \u003d \u0027 \u0027.join("},{"line_number":1538,"context_line":"                partition.name for partition in block_devices_partitions)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_66dbbaec","line":1535,"range":{"start_line":1534,"start_character":0,"end_line":1535,"end_character":24},"in_reply_to":"df33271e_944b91ae","updated":"2020-03-27 16:21:10.000000000","message":"It\u0027s not entirely trivial to do with our current primitives, that\u0027s why I wanted to leave it for a follow-up.","commit_id":"ddbba070216233e695f90095334ab7ddaef563f2"}],"ironic_python_agent/raid_utils.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"c7f29d13866f79e89e549747f8b4a13c7f0cc078","unresolved":false,"context_lines":[{"line_number":20,"context_line":"def get_block_devices_for_raid(block_devices, logical_disks):"},{"line_number":21,"context_line":"    \"\"\"Get block devices that are involved in the RAID configuration."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    This call does two things:"},{"line_number":24,"context_line":"    * Collect all block devices that are involved in RAID."},{"line_number":25,"context_line":"    * Update each logical disks with suitable block devices."},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":"    serialized_devs \u003d [dev.serialize() for dev in block_devices]"},{"line_number":28,"context_line":"    # NOTE(dtantsur): we\u0027re going to modify the structure, so make a copy"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_d4f35972","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":60},"updated":"2020-03-27 10:59:09.000000000","message":"Nit: add doc strings for the parameters and the exception","commit_id":"ddbba070216233e695f90095334ab7ddaef563f2"}]}