)]}'
{"id":"openstack%2Fironic-python-agent~715024","triplet_id":"openstack%2Fironic-python-agent~stable%2Ftrain~I8c0b42bb71b9e26ed7fec8894e21ce7fc06b94a1","project":"openstack/ironic-python-agent","branch":"stable/train","hashtags":[],"change_id":"I8c0b42bb71b9e26ed7fec8894e21ce7fc06b94a1","subject":"Return false for MBR bootloader check on UEFI machines","status":"MERGED","created":"2020-03-25 18:36:18.000000000","updated":"2020-03-25 22:05:28.000000000","submitted":"2020-03-25 22:01:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"715024-1585173704643-795c03e7","meta_rev_id":"d1033ef61a3085f1795edf578bb6fb7a39972260","_number":715024,"virtual_id_number":715024,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-25 22:01:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-03-25 21:23:10.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-03-25 18:47:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2020-03-25 18:47:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-25 18:47:37.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-03-25 21:23:10.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-03-25 22:01:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"111af5d14ed52dd4252771d54b405b3f8bec6e67","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-03-25 18:36:18.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"62d256771a991179a6abe40fc86fa304ab9b0c79","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-03-25 18:47:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c1c123c45706df49012cddaefaedf33c5e7fa17c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-25 20:23:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1ffa8ddc639e4288813a778653cd7d6e : SUCCESS in 5m 03s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/871b7d47aa5648529c473d2dd42b3e5c : SUCCESS in 5m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c1c7b9936b16446dac2ca0b95bc3c4e7 : SUCCESS in 6m 13s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/83aa18cb72674935b7619409cbcd43c0 : SUCCESS in 8m 33s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/67ebe56738864e14ae4557b630c11940 : SUCCESS in 8m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ba202469d4674247be328f51b0db3438 : SUCCESS in 9m 06s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5f753aeb901b431ea74caf98ecab5c9d : SUCCESS in 8m 54s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/f0ce2b3539c8429da7c7fec0684e4f95 : SUCCESS in 1h 10m 01s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/ce09ce0e086242c99425609ab63e5180 : SUCCESS in 1h 10m 40s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/2b4789a6e4454231b1f06fa7465781be : SUCCESS in 1h 04m 12s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/41abc160a20341aba85d533561daeb92 : SUCCESS in 1h 00m 36s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/bfaa7c1a44e7456f835bf166f7983ed9 : SUCCESS in 1h 26m 27s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/ee54bb3696534c95bc4e770b5f91bbd7 : SUCCESS in 16m 34s (non-voting)\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/fbb5c044bec44846849a2a46547141bb : FAILURE in 2m 53s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/b359058cb8d2450fada1902737d59bc4 : SUCCESS in 1h 39m 56s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/223b7bca0807492db6f0b6d921e28ed9 : FAILURE in 1h 04m 10s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/f70bd9d8aad74e8ba8ab7df4264655a2 : FAILURE in 1h 10m 54s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/36eb5f43c5e6430ead416e85a0e276fe : SUCCESS in 5m 31s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1205f02c7ff44a74bebd73e31ccaac74 : SUCCESS in 6m 20s\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/e24326e5b2a44eed89c2e2fa16e76708 : SUCCESS in 6m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2770a25b7fbb5b49b39953a69755f14b754f88e1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-25 20:23:23.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2dd2df1ab3b9b88eab95ae77dd4ab934cb73c050","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-03-25 21:23:10.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/59fcf76ada8c4f18a481dfb56c5565c9 : SUCCESS in 2h 45m 57s","accounts_in_message":[],"_revision_number":1},{"id":"55b83b8a41a77e2ef8d0a0a4e3adc97d45dd4252","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-25 22:01:44.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9f256085bffa40588e2ddedce3c7a7bb : SUCCESS in 4m 08s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/97b9ca037de9457a8bf11c311d8f0325 : SUCCESS in 5m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6649a83517c7470bb389c5b39dd03514 : SUCCESS in 4m 37s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/78f33f2149e64d70b0347c3006861511 : SUCCESS in 5m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/82187f6d44d44f59bb53260e3fdde67e : SUCCESS in 6m 30s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1bf8d66b29f24c88a5c9f2e48e3ff3df : SUCCESS in 4m 18s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/b609c19dedfc4cb599544b6570058926 : SUCCESS in 1h 07m 24s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/d2d1025cabe0445ea5c8451b78cf603d : SUCCESS in 1h 06m 56s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/8262996dd10a460b8ed9b73432f286ec : SUCCESS in 1h 03m 25s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/ead539d524da40378d397e4d81a34da7 : SUCCESS in 1h 01m 31s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/8de7316133cf4070b5735c818650f35e : SUCCESS in 1h 33m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1f1155f5cf70411593238b1a312ef2ed : SUCCESS in 5m 34s","accounts_in_message":[],"_revision_number":1},{"id":"af4d84bcb13cfa5f93bdbbaeb635e05455e52793","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-25 22:01:44.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"d1033ef61a3085f1795edf578bb6fb7a39972260","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-25 22:05:28.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2088d134f7664ee79d24529c08d27893 : SUCCESS in 1m 35s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/09a3d5249c2849d08973eca2c6c5d264 : SUCCESS in 1m 07s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1d418816d14ec922a0741d1b00d3641302e8d52a","revisions":{"1d418816d14ec922a0741d1b00d3641302e8d52a":{"kind":"REWORK","_number":1,"created":"2020-03-25 18:36:18.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/24/715024/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/24/715024/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/24/715024/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/24/715024/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/24/715024/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/24/715024/1"}}},"commit":{"parents":[{"commit":"8b2ace33a238d2f53fb5771d4d7e501ff0b91a2f","subject":"Rescan devices before performing uefi checks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8b2ace33a238d2f53fb5771d4d7e501ff0b91a2f"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2020-03-23 14:46:48.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2020-03-25 18:36:18.000000000","tz":0},"subject":"Return false for MBR bootloader check on UEFI machines","message":"Return false for MBR bootloader check on UEFI machines\n\nSomewhat common are dual boot images that have both a MBR loader\nand the contents required for a UEFI boot, as largely the pointer\nto where to begin reading the rest of the boot loader occurs in\nthe first few hundred bytes on disk which redirects the disk to\nbegin reading from a known address.\n\nThis goes sideways on UEFI machines where this method of booting\nis not recognized nor supported. Thus we need to return false when\nwe encounter this state.\n\nChange-Id: I8c0b42bb71b9e26ed7fec8894e21ce7fc06b94a1\nStory: 2007455\nTask: 39133\n(cherry picked from commit 81137d40459a7cafb04279acb079b2e004dc97f7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1d418816d14ec922a0741d1b00d3641302e8d52a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1d418816d14ec922a0741d1b00d3641302e8d52a"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}