)]}'
{"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac4ed0c5b2b4f72c2eb57430e939ed708486aeb4","unresolved":false,"context_lines":[{"line_number":360,"context_line":"    :param device: the softraid device path"},{"line_number":361,"context_line":"    :param holders: the softraid drive members"},{"line_number":362,"context_line":"    :param efi_part: when relevant the efi partition coming from the image"},{"line_number":363,"context_line":"     deployed on softraid device, can be/is often None"},{"line_number":364,"context_line":"    :param target_boot_mode: target boot mode can be bios/uefi/None"},{"line_number":365,"context_line":"     or anything else for unspecified"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_f344d81b","line":363,"updated":"2020-04-07 11:07:13.000000000","message":"nit: please use 4 spaces for indentation","commit_id":"66c32784afb505fe6c5f5b8824f92fba7b905b52"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a5f7f1ae0fb337a0bcc95217a441479b53ba8e01","unresolved":false,"context_lines":[{"line_number":1571,"context_line":"            # 2. Just leave space"},{"line_number":1572,"context_line":"            # 3. Do nothing: rely on the caller to specify target_raid_config"},{"line_number":1573,"context_line":"            # correctly according to what they intend to do (e.g. not set MAX"},{"line_number":1574,"context_line":"            # if they know they will need some space for bios boot or efi"},{"line_number":1575,"context_line":"            # parts). Best option imo, if we accept that the target volume"},{"line_number":1576,"context_line":"            # granularity is GiB, so you lose up to 1GiB just for a bios boot"},{"line_number":1577,"context_line":"            # partition..."}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_f9267f16","line":1574,"range":{"start_line":1574,"start_character":70,"end_line":1574,"end_character":73},"updated":"2020-04-07 07:26:56.000000000","message":"nit: EFI","commit_id":"66c32784afb505fe6c5f5b8824f92fba7b905b52"}]}
