)]}'
{"id":"openstack%2Fironic-python-agent~718489","triplet_id":"openstack%2Fironic-python-agent~master~I81f912d0dc0ad138d8cc776cdb4ee3b5251ec3ba","project":"openstack/ironic-python-agent","branch":"master","topic":"more-raid-utils","hashtags":[],"change_id":"I81f912d0dc0ad138d8cc776cdb4ee3b5251ec3ba","subject":"Move logic for raid start sector to raid_utils","status":"MERGED","created":"2020-04-08 15:24:02.000000000","updated":"2020-04-09 12:34:06.000000000","submitted":"2020-04-09 12:31:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"718489-1586435489227-9e742fff","meta_rev_id":"9232f78aafb0626e1ff01fed598d0d5f73baac5b","_number":718489,"virtual_id_number":718489,"owner":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-09 12:31:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-04-08 19:14:04.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"all":[{"value":2,"date":"2020-04-09 09:13:51.000000000","_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-04-09 08:35:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"all":[{"value":1,"date":"2020-04-09 09:13:51.000000000","_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-08 19:14:04.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-04-09 08:35:34.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-04-09 09:13:51.000000000","updated_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"reviewer":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"state":"REVIEWER"},{"updated":"2020-04-09 12:31:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e0d2344148dc2d98256ef9b290d4905e5e77d99c","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-04-08 15:24:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5c2e5ea0b87378167e45aa151ee1344b63724792","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-04-08 15:32:48.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ec3cf8364eb8e16f061b87a67431c7571f451a6e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-08 17:29:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d63f85b8b8084557a7663eb00cf1ce11 : SUCCESS in 6m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/54cee35d99e144f5bd15cb10e79af404 : SUCCESS in 5m 14s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/04dfd7b96c754245802593c6607184d5 : SUCCESS in 7m 45s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/aa650fb897594b88a933fd49217437a9 : SUCCESS in 7m 23s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bf844bf7e929420188bc85f29281e8c7 : SUCCESS in 5m 48s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/82d381ef3eba4c99bbda53c3c5235fbe : SUCCESS in 5m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ccf96e7acdd2468db29dadf17ee276c1 : SUCCESS in 9m 04s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/b8ef599ff71c4612a60c13a905682b5e : SUCCESS in 1h 03m 44s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/019896ffbf044d8c8d22aeafd508f166 : SUCCESS in 1h 03m 26s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/8e68283780784f5e9d11ba25fb112fc6 : SUCCESS in 1h 05m 46s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/5f9be6193b504fa3bea773fc3bb6424c : SUCCESS in 1h 00m 52s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/2c9875eee77548a785550f9da3a9edb1 : SUCCESS in 1h 48m 04s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/c6442a3a8b58445192d362226982b7c4 : SUCCESS in 1h 44m 00s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/c26e906b342c4d7498979f5a5e78a944 : SUCCESS in 16m 49s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/6bf65bce775d403f89a95d7d2cd85fba : SUCCESS in 11m 48s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/cda972343fad4c3bbb0546276c92e0b3 : SUCCESS in 1h 44m 47s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/b53ea2d5f34d443fa5aeed0cc1b1d99b : FAILURE in 1h 24m 59s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/f445332995f94479a292908d01731a13 : SUCCESS in 1h 31m 07s (non-voting)\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/9f4c9a97b51242b791124d741f33dbc3 : SUCCESS in 5m 49s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/b4b90817ced3471fb1fb92f7af700108 : SUCCESS in 4m 46s (non-voting)\n\nWarning:\n  Comments left for invalid file doc/source/contributor/index.rst","accounts_in_message":[],"_revision_number":2},{"id":"5e71e06abdbb21d288a74c9d2366a4c234121adc","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-04-08 19:14:04.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/20a1327640574306bf4592a354fde4a9 : FAILURE in 1h 30m 57s","accounts_in_message":[],"_revision_number":2},{"id":"c3f4e5aa1f6a0583b1f0a5760eba4849dec760e2","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-04-09 08:35:34.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"356f0c3c7fdc6264d41cadc25e47554bf3d1f70c","author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"date":"2020-04-09 09:13:51.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThank you Riccardo.","accounts_in_message":[],"_revision_number":2},{"id":"f1451857419fbaf744afaf9163db62f6d89c6786","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-09 09:14:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"f2a45766541ed24a1e46c52a23a6708e9433d3a1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-09 12:31:29.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/20a2c8ac5006449b9451e2f1343a815e : SUCCESS in 6m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3c001b0a5643436d9ee2bebb25c5f5fe : SUCCESS in 6m 47s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ceb2ca2c4ad24f26a8ea0584e212fdb3 : SUCCESS in 6m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fed3469148af40e2ae438223a968190d : SUCCESS in 6m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dda3f48d6746434ab5bc2d3d46151e78 : SUCCESS in 12m 37s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/8d6e5e642956421ebc1164939df97e59 : SUCCESS in 1h 04m 10s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/55c36a3c49f743b9baeaf7029fcf65da : SUCCESS in 1h 02m 42s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/3de39891366c41e2ae4bbba754c9e0a9 : SUCCESS in 1h 03m 31s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/fc200b34a9cd4713830626723a3524f0 : SUCCESS in 1h 05m 52s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/5a348088fbba4c2fa125a064e591c7ff : SUCCESS in 1h 46m 36s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/68839b1db3ba4106989804c859d7a459 : SUCCESS in 1h 49m 59s","accounts_in_message":[],"_revision_number":2},{"id":"efb9c583c8fc6a83270d9469eaaf3d880eb580a9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-09 12:31:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"1e373101fc7316e2a049a573de0cebd0a638abca","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-09 12:34:06.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2323cc06440845449188842e9ec32017 : SUCCESS in 2m 11s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f32a4a2b29df01cb100b6fdda59dac5d964a1107","revisions":{"a1556bff25554b5cddd17a5f38e9ccb177126c04":{"kind":"REWORK","_number":1,"created":"2020-04-08 15:24:02.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/89/718489/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/89/718489/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/89/718489/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/89/718489/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/89/718489/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/89/718489/1"}}},"commit":{"parents":[{"commit":"bdc5e9448decaa8e4ebc9e1d6b62508cba967ad4","subject":"Merge \"Editing follow-up for UEFI Software RAID support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/bdc5e9448decaa8e4ebc9e1d6b62508cba967ad4"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-04-08 15:22:47.000000000","tz":120},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-04-08 15:22:47.000000000","tz":120},"subject":"Move logic for raid start sector to raid_utils","message":"Move logic for raid start sector to raid_utils\n\nA starting tentative in reducing size of raid related functions.\n\nChange-Id: I81f912d0dc0ad138d8cc776cdb4ee3b5251ec3ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a1556bff25554b5cddd17a5f38e9ccb177126c04"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a1556bff25554b5cddd17a5f38e9ccb177126c04"}]},"branch":"refs/heads/master"},"f32a4a2b29df01cb100b6fdda59dac5d964a1107":{"kind":"REWORK","_number":2,"created":"2020-04-08 15:32:48.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/89/718489/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/89/718489/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/89/718489/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/89/718489/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/89/718489/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/89/718489/2"}}},"commit":{"parents":[{"commit":"bdc5e9448decaa8e4ebc9e1d6b62508cba967ad4","subject":"Merge \"Editing follow-up for UEFI Software RAID support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/bdc5e9448decaa8e4ebc9e1d6b62508cba967ad4"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-04-08 15:22:47.000000000","tz":120},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-04-08 15:32:38.000000000","tz":120},"subject":"Move logic for raid start sector to raid_utils","message":"Move logic for raid start sector to raid_utils\n\nA starting tentative in reducing size of raid related functions.\n\nChange-Id: I81f912d0dc0ad138d8cc776cdb4ee3b5251ec3ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f32a4a2b29df01cb100b6fdda59dac5d964a1107"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f32a4a2b29df01cb100b6fdda59dac5d964a1107"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}