)]}'
{"id":"openstack%2Fironic-python-agent~720549","triplet_id":"openstack%2Fironic-python-agent~stable%2Ftrain~I5f57535e5a89528c38d0879177b59db6c0f5c06e","project":"openstack/ironic-python-agent","branch":"stable/train","hashtags":[],"change_id":"I5f57535e5a89528c38d0879177b59db6c0f5c06e","subject":"A boot partition on a GPT disk should be considered an EFI partition","status":"MERGED","created":"2020-04-16 16:31:29.000000000","updated":"2020-04-17 09:36:52.000000000","submitted":"2020-04-17 09:34:10.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"720549-1587116050909-b16e9fe7","meta_rev_id":"d8a58ea6440c94aa3a9361c1f5699a34c7021a85","_number":720549,"virtual_id_number":720549,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-17 09:34:10.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-04-16 19:13:47.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2020-04-17 07:57:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2020-04-17 07:57:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-16 19:13:47.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-04-17 07:57:46.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-04-17 09:34:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0df3fab924de67101f3f207cdeaba7d8a06ede5d","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-04-16 16:31:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d18a3488c003e42b0c778ce45bc399b824afbb52","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-16 18:32:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f8f917baf8484fd1a35b1362d7e8595b : SUCCESS in 4m 01s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/71090991d6464c23a7cabe7ad079f880 : SUCCESS in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b891825dc61c4d9782f631e6a1893106 : SUCCESS in 5m 12s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/bd1593bb8a8145308a291ce1e0bdfebe : SUCCESS in 5m 01s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8fadaaeb8fed48c49e21eec54c890d77 : SUCCESS in 6m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b53f3f4e858d4a809e72929b0de42dff : SUCCESS in 6m 52s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9cb7905a6b6142dfb4ffa8a62481e804 : SUCCESS in 3m 37s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/02c582745ede4fa58999a057cd991646 : SUCCESS in 1h 03m 12s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/2ab9cba47d064717aa9d2998f32cc37d : SUCCESS in 57m 50s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/183dee14d1d34b698e16653b6d6164b9 : SUCCESS in 1h 05m 48s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/57bafb14e1c240abab950f5a12ae6969 : SUCCESS in 1h 57m 35s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/33dfb084df5c43e2a5507dfbf120d1e0 : SUCCESS in 1h 37m 39s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/95a8ad08800c4827983d0597ea1a8f9e : SUCCESS in 17m 49s (non-voting)\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/6f40fbae9efd4032888e75d21c0a9f64 : SUCCESS in 12m 15s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/f1c60f3902bc4b06b6ccd980137c9310 : SUCCESS in 1h 35m 25s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/c06e6394cc4646e88de924710b5c9ff1 : FAILURE in 45m 32s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/32dca343391d4c9c8f1694b407307c0a : FAILURE in 37m 58s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/8b1e6dbea511403089286b7b11129f35 : SUCCESS in 4m 28s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bde42cca1da04a6798efb8fa9d8c16c9 : SUCCESS in 5m 07s\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/eea06beb413b4a9cadc0ae3032ea3d8d : SUCCESS in 3m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8f338d1bd053f36b5a07f57081dc134cb1d23fd2","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-04-16 19:13:47.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/4c770a6cdd614c86871922b04afa806a : SUCCESS in 2h 39m 40s\n- tripleo-rhel-8-buildimage-overcloud-full-train https://review.rdoproject.org/zuul/build/dcc7c3a249f645dab34ac65517ee5f7d : SUCCESS in 21m 14s\n- tripleo-rhel-8-buildimage-ironic-python-agent-train https://review.rdoproject.org/zuul/build/4a2484df5b4346209acc605d8336932b : SUCCESS in 16m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a8ae0f9a1f701f2be90f72384af038b1b6df178f","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-04-17 07:57:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8ea2facbebf538d881eebd20dd3fa521bc8b07b3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 07:57:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e2d2d4d836ad851e1c6c6b7ed42cf4539b2d842e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 09:34:10.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"fbbb18363ed58fef46380ced1db36dec35f8346a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 09:34:10.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1e029ce11aed451396f260320456e2d8 : SUCCESS in 5m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5d9131ff7803421698c15ad44445431a : SUCCESS in 6m 19s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f008cb3ac03448919dac025aeafdfffc : SUCCESS in 7m 20s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5a88b1b0644f40dfb0b1fe870c886e18 : SUCCESS in 7m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7fe13a7903054a3f88e2933f3dcea2b6 : SUCCESS in 10m 51s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5b5f09671dc847e6a6b7865af7817d9c : SUCCESS in 5m 37s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/fe12831712184daab04e0bd0059ffec6 : SUCCESS in 1h 16m 27s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/b170221d54ec49cba31412a982fa4f51 : SUCCESS in 1h 12m 33s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/ef6b8828c08f45e890252646306a2230 : SUCCESS in 1h 13m 59s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/2224db705f274814b788a009e176f209 : SUCCESS in 1h 12m 39s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/ee4d3b0305734c569a33032759e8c3e2 : SUCCESS in 1h 22m 43s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/924ff0ccf28446a3874ad4aa88ab65f1 : SUCCESS in 5m 20s","accounts_in_message":[],"_revision_number":1},{"id":"d8a58ea6440c94aa3a9361c1f5699a34c7021a85","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 09:36:52.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/af95ac709e95463697cd82969b1e1202 : SUCCESS in 2m 19s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1953f6c425d1487dbfa41ef09502b287 : SUCCESS in 1m 56s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"53bab6ce44c1b6dfbe718aa4a7adea5c03eee551","revisions":{"53bab6ce44c1b6dfbe718aa4a7adea5c03eee551":{"kind":"REWORK","_number":1,"created":"2020-04-16 16:31:29.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/49/720549/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/49/720549/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/49/720549/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/49/720549/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/49/720549/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/49/720549/1"}}},"commit":{"parents":[{"commit":"1d418816d14ec922a0741d1b00d3641302e8d52a","subject":"Return false for MBR bootloader check on UEFI machines","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1d418816d14ec922a0741d1b00d3641302e8d52a"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-04-15 10:44:37.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-04-16 16:30:50.000000000","tz":120},"subject":"A boot partition on a GPT disk should be considered an EFI partition","message":"A boot partition on a GPT disk should be considered an EFI partition\n\nDIB builds instance images with EFI partitions that only have the boot\nflag, but not esp. According to parted documentation, boot is an alias\nfor esp on GPT, so accept it as well.\n\nTo avoid complexities when parsing parted output, the implementation\nis switched to existing utils and ironic-lib functions.\n\nConflicts:\n\tironic_python_agent/tests/unit/test_utils.py\n\tironic_python_agent/utils.py\n\nChange-Id: I5f57535e5a89528c38d0879177b59db6c0f5c06e\nStory: #2007455\nTask: #39423\n(cherry picked from commit ff49b04e28b74d89a5fa6334411c56628f502bee)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/53bab6ce44c1b6dfbe718aa4a7adea5c03eee551"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/53bab6ce44c1b6dfbe718aa4a7adea5c03eee551"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}