)]}'
{"ironic_python_agent/extensions/deploy.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e4df73ddd2b6c3e78c138762f3d02afeec92570c","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @base.async_command(\u0027execute_deploy_step\u0027)"},{"line_number":50,"context_line":"    def execute_deploy_step(self, step, node, ports, deploy_version\u003dNone,"},{"line_number":51,"context_line":"                            **kwargs):"},{"line_number":52,"context_line":"        \"\"\"Execute a deploy step."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :param step: A deploy step with \u0027step\u0027, \u0027priority\u0027 and \u0027interface\u0027 keys"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_0ddcf372","line":51,"range":{"start_line":51,"start_character":30,"end_line":51,"end_character":36},"updated":"2020-04-21 09:56:09.000000000","message":"I wonder if they should be passed in this way? Doesn\u0027t really matter.","commit_id":"c0502649bae086a87d52fba0bda1af489b08b49d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e4df73ddd2b6c3e78c138762f3d02afeec92570c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                            **kwargs):"},{"line_number":52,"context_line":"        \"\"\"Execute a deploy step."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :param step: A deploy step with \u0027step\u0027, \u0027priority\u0027 and \u0027interface\u0027 keys"},{"line_number":55,"context_line":"        :param node: A dict representation of a node"},{"line_number":56,"context_line":"        :param ports: A dict representation of ports attached to node"},{"line_number":57,"context_line":"        :param deploy_version: The deploy version as returned by"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_ed3707e3","line":54,"range":{"start_line":54,"start_character":21,"end_line":54,"end_character":79},"updated":"2020-04-21 09:56:09.000000000","message":"And args?","commit_id":"c0502649bae086a87d52fba0bda1af489b08b49d"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e4df73ddd2b6c3e78c138762f3d02afeec92570c","unresolved":false,"context_lines":[{"line_number":1537,"context_line":"    def get_deploy_steps(self, node, ports):"},{"line_number":1538,"context_line":"        return ["},{"line_number":1539,"context_line":"            {"},{"line_number":1540,"context_line":"                \u0027step\u0027: \u0027delete_configuration\u0027,"},{"line_number":1541,"context_line":"                \u0027priority\u0027: 0,"},{"line_number":1542,"context_line":"                \u0027interface\u0027: \u0027raid\u0027,"},{"line_number":1543,"context_line":"                \u0027reboot_requested\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_893f58d5","side":"PARENT","line":1540,"range":{"start_line":1540,"start_character":25,"end_line":1540,"end_character":45},"updated":"2020-04-21 09:56:09.000000000","message":"No delete configuration? This is a separate step out of band. I guess it\u0027s not strictly necessary.","commit_id":"6035771676ba6dcda2227161ab616a32e52c2cb0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"10cfdda0c7d24f05cc7950fadc6132fa0e84fbcd","unresolved":false,"context_lines":[{"line_number":1537,"context_line":"    def get_deploy_steps(self, node, ports):"},{"line_number":1538,"context_line":"        return ["},{"line_number":1539,"context_line":"            {"},{"line_number":1540,"context_line":"                \u0027step\u0027: \u0027delete_configuration\u0027,"},{"line_number":1541,"context_line":"                \u0027priority\u0027: 0,"},{"line_number":1542,"context_line":"                \u0027interface\u0027: \u0027raid\u0027,"},{"line_number":1543,"context_line":"                \u0027reboot_requested\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_ad2cdf47","side":"PARENT","line":1540,"range":{"start_line":1540,"start_character":25,"end_line":1540,"end_character":45},"in_reply_to":"1f493fa4_893f58d5","updated":"2020-04-21 10:02:51.000000000","message":"It\u0027s done the same way for OOB RAID. Only clean steps are separate.","commit_id":"6035771676ba6dcda2227161ab616a32e52c2cb0"}]}