)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"57681fcece6b12f2f4430bb5f43e4d524af1a1e6","unresolved":false,"context_lines":[{"line_number":971,"context_line":"                   architecture\u003dcpu_info.get(\u0027architecture\u0027),"},{"line_number":972,"context_line":"                   flags\u003dflags)"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"    def _calc_memory(self, sys_dict):"},{"line_number":975,"context_line":"        physical \u003d 0"},{"line_number":976,"context_line":"        for sys_child in sys_dict[\u0027children\u0027]:"},{"line_number":977,"context_line":"            if sys_child[\u0027id\u0027] \u003d\u003d \u0027core\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_56ff5133","line":974,"updated":"2020-04-24 16:32:41.000000000","message":"self is not used, move to a standalone function?","commit_id":"4755226d622ec12dd90b8e9baa8d454a82b2db49"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7c71efd72972198cf4c95fdaa16ee1c18df32a51","unresolved":false,"context_lines":[{"line_number":971,"context_line":"                   architecture\u003dcpu_info.get(\u0027architecture\u0027),"},{"line_number":972,"context_line":"                   flags\u003dflags)"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"    def _calc_memory(self, sys_dict):"},{"line_number":975,"context_line":"        physical \u003d 0"},{"line_number":976,"context_line":"        for sys_child in sys_dict[\u0027children\u0027]:"},{"line_number":977,"context_line":"            if sys_child[\u0027id\u0027] \u003d\u003d \u0027core\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_65fd5ab0","line":974,"in_reply_to":"1f493fa4_56ff5133","updated":"2020-04-27 08:56:34.000000000","message":"makes sense","commit_id":"4755226d622ec12dd90b8e9baa8d454a82b2db49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"57681fcece6b12f2f4430bb5f43e4d524af1a1e6","unresolved":false,"context_lines":[{"line_number":974,"context_line":"    def _calc_memory(self, sys_dict):"},{"line_number":975,"context_line":"        physical \u003d 0"},{"line_number":976,"context_line":"        for sys_child in sys_dict[\u0027children\u0027]:"},{"line_number":977,"context_line":"            if sys_child[\u0027id\u0027] \u003d\u003d \u0027core\u0027:"},{"line_number":978,"context_line":"                for core_child in sys_child[\u0027children\u0027]:"},{"line_number":979,"context_line":"                    if _MEMORY_ID_RE.match(core_child[\u0027id\u0027]):"},{"line_number":980,"context_line":"                        if (not core_child.get(\"children\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_b6fe9534","line":977,"updated":"2020-04-24 16:32:41.000000000","message":"while you\u0027re here:\n\n if sys_child[\u0027id\u0027] !\u003d \u0027core\u0027:\n     continue","commit_id":"4755226d622ec12dd90b8e9baa8d454a82b2db49"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7c71efd72972198cf4c95fdaa16ee1c18df32a51","unresolved":false,"context_lines":[{"line_number":974,"context_line":"    def _calc_memory(self, sys_dict):"},{"line_number":975,"context_line":"        physical \u003d 0"},{"line_number":976,"context_line":"        for sys_child in sys_dict[\u0027children\u0027]:"},{"line_number":977,"context_line":"            if sys_child[\u0027id\u0027] \u003d\u003d \u0027core\u0027:"},{"line_number":978,"context_line":"                for core_child in sys_child[\u0027children\u0027]:"},{"line_number":979,"context_line":"                    if _MEMORY_ID_RE.match(core_child[\u0027id\u0027]):"},{"line_number":980,"context_line":"                        if (not core_child.get(\"children\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_a5348294","line":977,"in_reply_to":"1f493fa4_b6fe9534","updated":"2020-04-27 08:56:34.000000000","message":"done","commit_id":"4755226d622ec12dd90b8e9baa8d454a82b2db49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"57681fcece6b12f2f4430bb5f43e4d524af1a1e6","unresolved":false,"context_lines":[{"line_number":976,"context_line":"        for sys_child in sys_dict[\u0027children\u0027]:"},{"line_number":977,"context_line":"            if sys_child[\u0027id\u0027] \u003d\u003d \u0027core\u0027:"},{"line_number":978,"context_line":"                for core_child in sys_child[\u0027children\u0027]:"},{"line_number":979,"context_line":"                    if _MEMORY_ID_RE.match(core_child[\u0027id\u0027]):"},{"line_number":980,"context_line":"                        if (not core_child.get(\"children\")"},{"line_number":981,"context_line":"                                and core_child.get(\u0027size\u0027)):"},{"line_number":982,"context_line":"                            value \u003d (\"%(size)s %(units)s\" % core_child)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_96f9d94e","line":979,"updated":"2020-04-24 16:32:41.000000000","message":"similarly here","commit_id":"4755226d622ec12dd90b8e9baa8d454a82b2db49"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7c71efd72972198cf4c95fdaa16ee1c18df32a51","unresolved":false,"context_lines":[{"line_number":976,"context_line":"        for sys_child in sys_dict[\u0027children\u0027]:"},{"line_number":977,"context_line":"            if sys_child[\u0027id\u0027] \u003d\u003d \u0027core\u0027:"},{"line_number":978,"context_line":"                for core_child in sys_child[\u0027children\u0027]:"},{"line_number":979,"context_line":"                    if _MEMORY_ID_RE.match(core_child[\u0027id\u0027]):"},{"line_number":980,"context_line":"                        if (not core_child.get(\"children\")"},{"line_number":981,"context_line":"                                and core_child.get(\u0027size\u0027)):"},{"line_number":982,"context_line":"                            value \u003d (\"%(size)s %(units)s\" % core_child)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_e52a0a2a","line":979,"in_reply_to":"1f493fa4_96f9d94e","updated":"2020-04-27 08:56:34.000000000","message":"done","commit_id":"4755226d622ec12dd90b8e9baa8d454a82b2db49"}]}