)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f755dad4981e9c16080b47ac9a3d3ebe42b1b5ce","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"            LOG.warning(\u0027Could not get real physical RAM from lshw: %s\u0027, e)"},{"line_number":1010,"context_line":"            physical \u003d None"},{"line_number":1011,"context_line":"        else:"},{"line_number":1012,"context_line":"            physical \u003d _calc_memory(sys_dict)"},{"line_number":1013,"context_line":"            try:"},{"line_number":1014,"context_line":"                physical \u003d _calc_memory(sys_dict)"},{"line_number":1015,"context_line":"            except TypeError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_170da7e7","line":1012,"updated":"2020-04-27 10:52:24.000000000","message":"Remove?","commit_id":"df187988087eae90f8dd98b2dc4b4e8ef798ff1c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1b99cb5d469df7cbd496c09e2e17830d77bf0ee7","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"            LOG.warning(\u0027Could not get real physical RAM from lshw: %s\u0027, e)"},{"line_number":1010,"context_line":"            physical \u003d None"},{"line_number":1011,"context_line":"        else:"},{"line_number":1012,"context_line":"            physical \u003d _calc_memory(sys_dict)"},{"line_number":1013,"context_line":"            try:"},{"line_number":1014,"context_line":"                physical \u003d _calc_memory(sys_dict)"},{"line_number":1015,"context_line":"            except TypeError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_8816b6f0","line":1012,"in_reply_to":"1f493fa4_170da7e7","updated":"2020-04-27 12:58:49.000000000","message":"yeah, I think I miss this in the rebase, thanks!","commit_id":"df187988087eae90f8dd98b2dc4b4e8ef798ff1c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f755dad4981e9c16080b47ac9a3d3ebe42b1b5ce","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"            physical \u003d _calc_memory(sys_dict)"},{"line_number":1013,"context_line":"            try:"},{"line_number":1014,"context_line":"                physical \u003d _calc_memory(sys_dict)"},{"line_number":1015,"context_line":"            except TypeError:"},{"line_number":1016,"context_line":"                sys_dict \u003d json.loads(sys_dict)"},{"line_number":1017,"context_line":"                physical \u003d _calc_memory(sys_dict)"},{"line_number":1018,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_f7111b06","line":1015,"updated":"2020-04-27 10:52:24.000000000","message":"This risks hiding actual errors in _calc_memory, could you make it more granular? Or even easier, why not\n\n if isinstance(sys_dict, str)\n\n?","commit_id":"df187988087eae90f8dd98b2dc4b4e8ef798ff1c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1b99cb5d469df7cbd496c09e2e17830d77bf0ee7","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"            physical \u003d _calc_memory(sys_dict)"},{"line_number":1013,"context_line":"            try:"},{"line_number":1014,"context_line":"                physical \u003d _calc_memory(sys_dict)"},{"line_number":1015,"context_line":"            except TypeError:"},{"line_number":1016,"context_line":"                sys_dict \u003d json.loads(sys_dict)"},{"line_number":1017,"context_line":"                physical \u003d _calc_memory(sys_dict)"},{"line_number":1018,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_a8c73264","line":1015,"in_reply_to":"1f493fa4_f7111b06","updated":"2020-04-27 12:58:49.000000000","message":"yes, definitely better","commit_id":"df187988087eae90f8dd98b2dc4b4e8ef798ff1c"}]}