)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6259aaffdb4f3b2128bee65116393daa8afe6f0c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In order to ensure grub2 finds all files it needs, mount all"},{"line_number":10,"context_line":"partitions specified in the deployed image."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: #2007618"},{"line_number":13,"context_line":"Change-Id: Ie5b6e0abc3f266409562f9ecb26538126b667056"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_c7175d54","line":12,"updated":"2020-06-10 02:15:44.000000000","message":"Is there a task to go with this? Asking only because it is the task tag that closes out the story.","commit_id":"0d59efd22165a19267c639a35d9932decdb7d1a8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c80d49d127efd4f879dd543006ec7c437477c966","unresolved":false,"context_lines":[{"line_number":10,"context_line":"vfat partitions specified in the deployed image."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: #2007618"},{"line_number":13,"context_line":"Change-Id: Ie5b6e0abc3f266409562f9ecb26538126b667056"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_ee48a02f","line":13,"updated":"2020-06-30 16:28:20.000000000","message":"nit: missing task number","commit_id":"e71cdd07aef503ae1aa9c7f750d05ab37e03555a"}],"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3318b60eaf82e9d7cf31be219c69f9a9168847a1","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        # them might not be inside the root partition (like grub2env)."},{"line_number":546,"context_line":"        LOG.debug(\"Mounting all partitions inside the image ...\")"},{"line_number":547,"context_line":"        utils.execute(\u0027chroot %(path)s /bin/sh -c \"mount -a\"\u0027 %"},{"line_number":548,"context_line":"                      {\u0027path\u0027: path}, shell\u003dTrue,"},{"line_number":549,"context_line":"                      env_variables\u003d{\u0027PATH\u0027: path_variable})"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        if efi_partitions:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_073955f1","line":548,"updated":"2020-06-10 02:15:07.000000000","message":"So... if this mounts, say /tmp/temp.2391/ folders home and var as separate filesystems, when we go to unmount the root filesystem, it won\u0027t unmount because they are nested inside of it.","commit_id":"0d59efd22165a19267c639a35d9932decdb7d1a8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3318b60eaf82e9d7cf31be219c69f9a9168847a1","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        # If umounting the binds succeed then we can try to delete it"},{"line_number":685,"context_line":"        if not umount_binds_fail:"},{"line_number":686,"context_line":"            try:"},{"line_number":687,"context_line":"                utils.execute(\u0027umount\u0027, path, attempts\u003d3, delay_on_retry\u003dTrue)"},{"line_number":688,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":689,"context_line":"                LOG.warning(umount_warn_msg, {\u0027path\u0027: path, \u0027error\u0027: e})"},{"line_number":690,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_271f3971","line":687,"updated":"2020-06-10 02:15:07.000000000","message":"I believe we need to walk the filesystem, unless umount has a \"mount all the nested mounts\" flag these days.","commit_id":"0d59efd22165a19267c639a35d9932decdb7d1a8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"684eb71e3659c9fd5eee6bbd014d679a8fc50b98","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        # If umounting the binds succeed then we can try to delete it"},{"line_number":685,"context_line":"        if not umount_binds_fail:"},{"line_number":686,"context_line":"            try:"},{"line_number":687,"context_line":"                utils.execute(\u0027umount\u0027, path, attempts\u003d3, delay_on_retry\u003dTrue)"},{"line_number":688,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":689,"context_line":"                LOG.warning(umount_warn_msg, {\u0027path\u0027: path, \u0027error\u0027: e})"},{"line_number":690,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a56649c0","line":687,"updated":"2020-06-22 09:08:29.000000000","message":"There seem to be a --recursive flag indeed","commit_id":"0d59efd22165a19267c639a35d9932decdb7d1a8"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"c3c6a8e92a5c9c7f4fe214e4b6bdf8a92e445ca8","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        # If umounting the binds succeed then we can try to delete it"},{"line_number":685,"context_line":"        if not umount_binds_fail:"},{"line_number":686,"context_line":"            try:"},{"line_number":687,"context_line":"                utils.execute(\u0027umount\u0027, path, attempts\u003d3, delay_on_retry\u003dTrue)"},{"line_number":688,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":689,"context_line":"                LOG.warning(umount_warn_msg, {\u0027path\u0027: path, \u0027error\u0027: e})"},{"line_number":690,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e5b841e6","line":687,"in_reply_to":"bf51134e_a56649c0","updated":"2020-06-22 09:15:18.000000000","message":"I think \"-a\" was maybe too aggressive. The use case is a UEFI capable image which needs the EFI partition mounted to run grub in BIOS mode. So, it may be better to specifically mount what we need, rather than everything, and subsequently only umount what we mounted. Limiting to \"-t vfat\" seems like a good option.","commit_id":"0d59efd22165a19267c639a35d9932decdb7d1a8"}]}