)]}'
{"id":"openstack%2Fironic-python-agent~738669","triplet_id":"openstack%2Fironic-python-agent~stable%2Fussuri~If5e798c5461ea3e474a153574b0db2da96f2dfa8","project":"openstack/ironic-python-agent","branch":"stable/ussuri","topic":"retries-stable/ussuri","hashtags":[],"change_id":"If5e798c5461ea3e474a153574b0db2da96f2dfa8","subject":"Fixes minor issues in the read() retries patch","status":"MERGED","created":"2020-06-30 16:45:03.000000000","updated":"2020-07-01 08:13:49.000000000","submitted":"2020-07-01 08:11:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"738669-1593591087456-c88092e0","meta_rev_id":"12135f5ec546e177170691ebeec741d8d546d6ab","_number":738669,"virtual_id_number":738669,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-01 08:11:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-06-30 20:07:51.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2020-07-01 06:42:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2020-06-30 17:04:05.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2020-07-01 06:42:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-30 17:04:05.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"},{"updated":"2020-06-30 20:07:51.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-01 06:42:24.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-07-01 08:11:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"164a914c5ecb131225c4a0917f9199fb15b713a4","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-06-30 16:45:03.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"315733e10c2720cb1e7d1e7b1c38a4f032deb2ac","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2020-06-30 17:04:05.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6e5ff3b2e2d454462a991d6b9e98f5ac81d3c6ae","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-30 18:29:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/858ece12609f48ad9545b59c43772f9a : SUCCESS in 5m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bf81ff837dd644d6ba9ee785ac290a66 : SUCCESS in 11m 48s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5ef6c2597f8c4721a20543f4ddec0768 : SUCCESS in 8m 46s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a7f52f77ba7f479087badcb50f04d912 : SUCCESS in 8m 45s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/359824b5d71d43ab9d2971d8683ad844 : SUCCESS in 8m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9279c572611445a5990ba09c679d3da0 : SUCCESS in 12m 34s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/9e8b0fc3223540918d46139c35fb0050 : SUCCESS in 1h 07m 56s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/5ac497d087c045a0bb4ca8f418024964 : SUCCESS in 1h 11m 00s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/6ec4b0c85e2d4a00ab755209c1b0d80b : SUCCESS in 1h 08m 23s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/57875a591b044eaf83fa955c14113b14 : SUCCESS in 1h 14m 29s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/85488311a6ca41d28d6db447278e0452 : SUCCESS in 1h 21m 15s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/6f897f2eb75046ff857b776313453da0 : SUCCESS in 1h 24m 53s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/8016bd5570654e858f85289ccce39285 : FAILURE in 4m 55s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/e7e35f5bd34245bb8e4dc5f7f2edd97f : FAILURE in 6m 51s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/f1179a49b96443529d38d717266bb4c5 : SUCCESS in 1h 39m 27s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/d2d231a285e2441db08a69e4a9545877 : FAILURE in 37m 31s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/dbb016957ce440a48b9ff5973e18e552 : FAILURE in 33m 49s (non-voting)\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/098d2a14fd4c47e484a727e968d59918 : SUCCESS in 9m 37s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/fa634f29bdf640c089e1f1f3216d95b6 : SUCCESS in 6m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f30e94107dbf75d4b0c1fd9f69086ddbcac8f571","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-06-30 20:07:51.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/6ad3b319c06e4a68b0a5d124b955beec : SUCCESS in 3h 07m 30s","accounts_in_message":[],"_revision_number":1},{"id":"eecaf6b02e97e59a295c9cfcd774216c37f0b22c","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-07-01 06:42:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"99a6437f0ee872ee5022db092be9994eab1a9d2b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 06:42:41.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8b8bd3787c421fdfc8b5ec20118cfbc7b97a58be","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 08:11:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"42b1135b1f987a010a8da0dc8706306508d24b8b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 08:11:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6778db586f5c48608a2714ee4ce23a06 : SUCCESS in 6m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8cf0284ea20b410eb8fbb53b575caa8a : SUCCESS in 8m 39s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/aa6988b9eb454282bdfae1e3df049115 : SUCCESS in 8m 42s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1c221b8a14ec4af883a3d3b463ccc1dd : SUCCESS in 8m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d507caff50924acd8ad1f7ef06dfa1ab : SUCCESS in 11m 36s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/fa6c198082a6463f94a56a9da7567d4e : SUCCESS in 1h 02m 23s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/ed070f2c102844419a896d6088522e18 : SUCCESS in 1h 04m 45s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/d8ba5185f82445edae4055c8870784da : SUCCESS in 1h 06m 26s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/11b723e0905c4f60b51a61d616fac683 : SUCCESS in 1h 01m 01s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/a4db7db0b8874d56afa16ba258ad6e7e : SUCCESS in 1h 12m 32s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/d5159f06773e4b1a95e3b2a7328dee94 : SUCCESS in 1h 27m 00s","accounts_in_message":[],"_revision_number":1},{"id":"1d18fa179b1b398c85e3a230a302621522c2db4d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 08:13:49.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f265a43f0a854f2ab1cfdb0dc008ed7c : SUCCESS in 1m 58s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"aa500ec923adbd2a23528f26ef62ed48ff1b84af","revisions":{"aa500ec923adbd2a23528f26ef62ed48ff1b84af":{"kind":"REWORK","_number":1,"created":"2020-06-30 16:45:03.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/69/738669/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/69/738669/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/69/738669/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/69/738669/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/69/738669/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/69/738669/1"}}},"commit":{"parents":[{"commit":"3d7592c063ae0d3b028c52639efbdac225dc9e55","subject":"Merge \"Fix confusing logging when running asynchronous commands\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3d7592c063ae0d3b028c52639efbdac225dc9e55"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-06-30 08:51:53.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-06-30 16:45:03.000000000","tz":0},"subject":"Fixes minor issues in the read() retries patch","message":"Fixes minor issues in the read() retries patch\n\nFollow-up to commit c5b97eb781cf9851f9abe87a1500b4da55b8bde8.\n\nTwo things slipped through the cracks:\n* ImageDownloadError was instantiated incorrectly, resulting in a wrong\n  error message. This was uncovered by using assertRaisesRegext in tests.\n* We allowed calling write(None). This was uncovered by avoiding sleep(4)\n  in tests and enabling more failed calls before timeout.\n\nChange-Id: If5e798c5461ea3e474a153574b0db2da96f2dfa8\n(cherry picked from commit 00ad03b709275e185ccb5b8e80cb7db4b9071d56)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/aa500ec923adbd2a23528f26ef62ed48ff1b84af"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/aa500ec923adbd2a23528f26ef62ed48ff1b84af"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}