)]}'
{"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9294d221d35731a0b5df5913bacbcbe72a00020f","unresolved":false,"context_lines":[{"line_number":151,"context_line":"def _has_boot_sector(device):"},{"line_number":152,"context_line":"    \"\"\"Check the device for a boot sector indiator.\"\"\""},{"line_number":153,"context_line":"    stdout, stderr \u003d utils.execute(\u0027file\u0027, \u0027-s\u0027, device)"},{"line_number":154,"context_line":"    if \u0027boot sector\u0027 in stdout:"},{"line_number":155,"context_line":"        # Now lets check the signature"},{"line_number":156,"context_line":"        ddout, dderr \u003d utils.execute("},{"line_number":157,"context_line":"            \u0027dd\u0027, \u0027if\u003d%s\u0027 % device, \u0027bs\u003d218\u0027, \u0027count\u003d1\u0027, binary\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_7cc0757d","line":154,"updated":"2020-07-07 07:32:06.000000000","message":"nit:\n\n if \u0027boot sector\u0027 not in stdout:\n    return False","commit_id":"610ddff12c8a90b0026cbfcfa94590f466ded69a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9294d221d35731a0b5df5913bacbcbe72a00020f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"def _find_bootable_device(partitions, dev):"},{"line_number":167,"context_line":"    \"\"\"Find the bootable device, and check the base device"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    and partition for bootloader contents."},{"line_number":170,"context_line":"    \"\"\""},{"line_number":171,"context_line":"    LOG.debug(\u0027Looking for a bootable device in %s\u0027, dev)"},{"line_number":172,"context_line":"    for line in partitions.splitlines():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_dcbf01f9","line":169,"updated":"2020-07-07 07:32:06.000000000","message":"nit: please don\u0027t split it like this","commit_id":"610ddff12c8a90b0026cbfcfa94590f466ded69a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c6e43a95323c9781ab5eb98ba987fff07eea238e","unresolved":false,"context_lines":[{"line_number":166,"context_line":"def _find_bootable_device(partitions, dev):"},{"line_number":167,"context_line":"    \"\"\"Find the bootable device, and check the base device"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    and partition for bootloader contents."},{"line_number":170,"context_line":"    \"\"\""},{"line_number":171,"context_line":"    LOG.debug(\u0027Looking for a bootable device in %s\u0027, dev)"},{"line_number":172,"context_line":"    for line in partitions.splitlines():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_bf5e7f0f","line":169,"in_reply_to":"bf51134e_dcbf01f9","updated":"2020-07-07 08:37:23.000000000","message":"also don\u0027t like it, I will re-submit it","commit_id":"610ddff12c8a90b0026cbfcfa94590f466ded69a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d4d8b582e5d854299e0fafb3901cdfe8a150e40f","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    stdout, stderr \u003d utils.execute(\u0027file\u0027, \u0027-s\u0027, device)"},{"line_number":154,"context_line":"    if \u0027boot sector\u0027 not in stdout:"},{"line_number":155,"context_line":"        return False"},{"line_number":156,"context_line":"    else:"},{"line_number":157,"context_line":"        # Now lets check the signature"},{"line_number":158,"context_line":"        ddout, dderr \u003d utils.execute("},{"line_number":159,"context_line":"            \u0027dd\u0027, \u0027if\u003d%s\u0027 % device, \u0027bs\u003d218\u0027, \u0027count\u003d1\u0027, binary\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_0825a1ab","line":156,"updated":"2020-07-08 08:35:02.000000000","message":"nit: else is not needed after return","commit_id":"9d9a6bce5c246d18d50dc405265e865fb77142eb"}]}