)]}'
{"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c2b333bc1d6590e5acada47c3d957722ce5eff36","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    stdout, stderr \u003d utils.execute(\u0027file\u0027, \u0027-\u0027, process_input\u003dddout)"},{"line_number":160,"context_line":"    # The bytes recovered by dd show as a \"dos executable\" when"},{"line_number":161,"context_line":"    # examined with file. In other words, the bootloader is present."},{"line_number":162,"context_line":"    if \u0027executable\u0027 in stdout:"},{"line_number":163,"context_line":"        return True"},{"line_number":164,"context_line":"    return False"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0d781af6","line":162,"updated":"2020-07-23 16:08:03.000000000","message":"nit:\n\n return \u0027executable\u0027 in stdout","commit_id":"05860cb9204fee0674af631bcecb33f24955d182"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c2b333bc1d6590e5acada47c3d957722ce5eff36","unresolved":false,"context_lines":[{"line_number":485,"context_line":"            umount_binds_fail \u003d True"},{"line_number":486,"context_line":"            LOG.warning(umount_warn_msg, {\u0027path\u0027: path + fs, \u0027error\u0027: e})"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    return umount_binds_fail"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"def _install_grub2(device, root_uuid, efi_system_part_uuid\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ed7a06ee","line":488,"updated":"2020-07-23 16:08:03.000000000","message":"Let\u0027s return True on success not on failure. Otherwise reasoning about it becomes too tricky.","commit_id":"05860cb9204fee0674af631bcecb33f24955d182"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"aa941f46cf240b52e1a7af1c43c069a1e1519809","unresolved":false,"context_lines":[{"line_number":485,"context_line":"            umount_binds_fail \u003d True"},{"line_number":486,"context_line":"            LOG.warning(umount_warn_msg, {\u0027path\u0027: path + fs, \u0027error\u0027: e})"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    return umount_binds_fail"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"def _install_grub2(device, root_uuid, efi_system_part_uuid\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_4bce7083","line":488,"in_reply_to":"bf51134e_ed7a06ee","updated":"2020-07-24 08:17:36.000000000","message":"yes, will do","commit_id":"05860cb9204fee0674af631bcecb33f24955d182"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eca1ac523faad947e5b02608fdfb6670078a90b9","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                          delay_on_retry\u003dTrue)"},{"line_number":481,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":482,"context_line":"            LOG.warning(umount_warn_msg, {\u0027path\u0027: path + fs, \u0027error\u0027: e})"},{"line_number":483,"context_line":"            return False"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    return True"},{"line_number":486,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_6e16e24b","line":483,"updated":"2020-07-24 09:02:45.000000000","message":"Do you really want to return here? I think the idea was to try umounting all of them, and returning False if at least one fails.","commit_id":"d386ac2d2d33e640b7a37742d652d2a0727bfc2c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1751c23d70597d902a226976619a7d76f4009543","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                          delay_on_retry\u003dTrue)"},{"line_number":481,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":482,"context_line":"            LOG.warning(umount_warn_msg, {\u0027path\u0027: path + fs, \u0027error\u0027: e})"},{"line_number":483,"context_line":"            return False"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    return True"},{"line_number":486,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_1f778e3d","line":483,"in_reply_to":"bf51134e_6e16e24b","updated":"2020-07-24 12:31:51.000000000","message":"yea, I ignored the loop....","commit_id":"d386ac2d2d33e640b7a37742d652d2a0727bfc2c"}]}