)]}'
{"id":"openstack%2Fironic-python-agent~743550","triplet_id":"openstack%2Fironic-python-agent~stable%2Ftrain~Id3b1ae5e59282f4109f6246d5614d44c93aefa7c","project":"openstack/ironic-python-agent","branch":"stable/train","hashtags":[],"change_id":"Id3b1ae5e59282f4109f6246d5614d44c93aefa7c","subject":"Prevent un-needed iscsi cleanup","status":"MERGED","created":"2020-07-28 14:17:09.000000000","updated":"2020-08-09 12:14:38.000000000","submitted":"2020-08-09 12:12:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"743550-1596975149012-62d8eb97","meta_rev_id":"58616fa323f8ea658888a1b8d1ed362642d135b8","_number":743550,"virtual_id_number":743550,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-08-04 18:19:58.000000000","_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-09 12:12:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-08-04 21:11:53.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-08-09 10:34:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2020-08-09 10:34:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-04 21:11:53.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-09 10:34:44.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-08-09 12:12:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"09f9ea8b043474cbc2d70182ce95d94abd1ec7c2","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-07-28 14:17:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fd141db23846f67c458d6904596b2f54fdfd09f6","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-07-28 14:17:37.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 53d53290c357ecace4872b4fd71f0516e82e700c","accounts_in_message":[],"_revision_number":1},{"id":"8e233813c3b9ccad23efdf048a15b8b7bdad8af3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-28 16:50:33.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d356f2a7a1f74616b136cb1b6ebfb110 : SUCCESS in 8m 01s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0c370fb145904b2184eb81f86f584017 : SUCCESS in 6m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3482c6917be9408fafb170ed3cfdcbcf : SUCCESS in 7m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/af7ceb0450f44735b1e6bf77d02ee4cf : SUCCESS in 7m 10s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/975b1c6e968a41b49bc584b730058e7e : SUCCESS in 8m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7d0152e0e768445bb73c0f89ea81a431 : SUCCESS in 10m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cfb08ed46ffc4a1d86b650d8c6497369 : SUCCESS in 4m 59s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/e5dc9ca8d2d2445087868596dbd4e21e : FAILURE in 1h 03m 04s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/de039ad084a54a46958dedcc4db969b2 : FAILURE in 1h 06m 25s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/04fa27289f9b49dca1c2b3664eb5f0ee : FAILURE in 1h 07m 52s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/efcc410dc95840b5942a466ceb834ff8 : FAILURE in 1h 06m 37s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/76ce73617b3549039a48cbbac9733664 : SUCCESS in 1h 10m 21s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/b765e06c5fa640e78c2b4548cadf38da : SUCCESS in 16m 37s (non-voting)\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/09d6b70cef6e4a80a29431896be0c1c0 : SUCCESS in 13m 50s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/ad240d68a2e94dac947311cfc33a7823 : SUCCESS in 1h 58m 21s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/cbed8b6e3b0e42558c9406e7f5544b2c : RETRY_LIMIT in 39m 54s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/a9577100441044d0b6c1d60f84bd8a54 : FAILURE in 32m 48s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/89d03f9679fb4ae6acff9efd14756c42 : SUCCESS in 5m 12s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/94997451d44f40f2beda3f9bffb62668 : SUCCESS in 6m 33s\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/344cc7b754d249389ea37eb04c596abf : SUCCESS in 6m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"40cb0d2a8b5c1a27b12eecc540e519eb79a8db90","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-07-28 17:04:32.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/2dedb167463946a8b92954a2cdb295ff : SUCCESS in 2h 46m 38s\n- tripleo-rhel-8-buildimage-overcloud-full-train https://review.rdoproject.org/zuul/build/0b7a9003128540b49d0b2a9c19886a4d : RETRY_LIMIT in 6m 03s\n- tripleo-rhel-8-buildimage-ironic-python-agent-train https://review.rdoproject.org/zuul/build/9131b940529b4a7289b6ad02fdc434cc : RETRY_LIMIT in 6m 15s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"595cfd40e971ab56476fbfe5815031ed5c75cd7d","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-08-04 18:19:58.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"fa2755294fad75c410be04a4eb8209db09eb9e8d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-04 20:37:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c51a62e0933b41789cde726e41991467 : SUCCESS in 3m 54s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f068b25cca0741e6ae8e3ec56cbff1bb : SUCCESS in 4m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/faa649311afb4605a63872cdc157bbfb : SUCCESS in 6m 27s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/bb3f076452f94d36925680c759eff1f0 : SUCCESS in 5m 09s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/aafb2f6985144b5fa105e1ae42ea3976 : SUCCESS in 5m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6fe29cf34cc54c15ba7ca1d593585ddd : SUCCESS in 6m 43s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d09e367b70074248aefbc20c79f1be95 : SUCCESS in 3m 27s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/ce6a23f364e34a11b4b70a29959ad5f8 : SUCCESS in 1h 03m 10s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/33af2851360542ebbc658d9caa98cd8a : SUCCESS in 1h 09m 51s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/5d3d06369296493aa4245dcb0542366c : SUCCESS in 1h 03m 42s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/cc19c6f15d4d4ae4906c4e523fa45c40 : SUCCESS in 1h 05m 21s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/2e7df1bb396a468ab4ccff3baed3a60f : SUCCESS in 1h 14m 34s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/f52ea16c58a74ebc8dcbdb0635d283fc : SUCCESS in 21m 54s (non-voting)\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/93a4ce6ad7be4eb2a0a0fc483b44c50c : SUCCESS in 11m 21s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/b8e5fecd94984b0f9e101b64d7a9170c : SUCCESS in 1h 45m 50s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/bc389aae384341828842774cac7ca2d9 : RETRY_LIMIT in 46m 55s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/2a5e137edb5341f4b2031aa7bb014504 : FAILURE in 1h 10m 44s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/5168444557e34b9bb9c0a809b73062e8 : SUCCESS in 4m 49s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e3da756d16c54dafa94f0ce4fe14ebfe : SUCCESS in 4m 18s\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/194a809b2f2f4bf99980a1aaed98502e : SUCCESS in 4m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6a6b53abc2ff2b03e68e4cdf7def000773637865","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-08-04 21:11:53.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/7c75eb4fa25941e4aaad8049da88366b : SUCCESS in 2h 50m 03s","accounts_in_message":[],"_revision_number":1},{"id":"0233c219932e8c7a3c74239c945fc892d2bdbeb1","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-08-09 10:34:44.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"89b4f0360be2320f086a705de042dcfb2b72dde9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-09 10:34:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"53e4aa00d352c809c04e3e0f0460e1a8b49b9183","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-09 12:12:28.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/810c357f039740d3968ae5e2c553b4c7 : SUCCESS in 3m 39s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/ca4183a2613344839e54e4ab00164aba : SUCCESS in 3m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d75828fb26964ab0ae35004cd105115f : SUCCESS in 4m 48s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/87b6faf7f0e347e492f0a62d0401665e : SUCCESS in 4m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/92f636192a9440de9a13d3a84c1e5f00 : SUCCESS in 7m 05s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3a516ed353f14c268095802248499806 : SUCCESS in 3m 05s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/b93f5e3906844deb9b0064b01f860efb : SUCCESS in 46m 03s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/58c7167e2f0f43e0a4ced38165168a19 : SUCCESS in 1h 02m 42s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/c96d4b1355b74561b034b197a785c02a : SUCCESS in 1h 05m 26s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/cf501a77a0434023aafe77a4588703f7 : SUCCESS in 1h 02m 59s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/1d87b116ca244213b92c4cb3916a0679 : SUCCESS in 1h 12m 32s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ef340f99b6874586b96b4eb7da28d3a5 : SUCCESS in 4m 41s","accounts_in_message":[],"_revision_number":1},{"id":"a458466be91f20dff1085fa44106c0f486f0a024","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-09 12:12:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"58616fa323f8ea658888a1b8d1ed362642d135b8","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-09 12:14:38.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/847229b891c24988a3522cee100f9340 : SUCCESS in 50s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e0537f398b0d4919904870e3f67218a2 : SUCCESS in 49s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0b7c31841e4d3ec6e8027b837229d08b4562e5f7","revisions":{"0b7c31841e4d3ec6e8027b837229d08b4562e5f7":{"kind":"REWORK","_number":1,"created":"2020-07-28 14:17:09.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/50/743550/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/50/743550/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/743550/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/743550/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/743550/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/743550/1"}}},"commit":{"parents":[{"commit":"46759750e0d34296c218a71c78cc7b60115693ef","subject":"Merge \"Fix serializing ironic-lib exceptions\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/46759750e0d34296c218a71c78cc7b60115693ef"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2020-07-20 21:24:06.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2020-07-28 14:16:47.000000000","tz":-420},"subject":"Prevent un-needed iscsi cleanup","message":"Prevent un-needed iscsi cleanup\n\nWhen we added software raid support, we started calling bootloader\ninstallation. As time went on, we ehnanced that code path for non\nRAID cases in order to ensure that UEFI nvram was setup\nfor the instance to boot properly.\n\nSomewhere in this process, we missed a possible failure case where\nthe iscsi client tgtadm may return failures. Obviously, the correct\npath is to not call iscsi teardown if we don\u0027t need to.\n\nSince it was always semi-opportunistic teardown, we can\u0027t blindly\ncatch any error, and if we started iSCSI and failed to tear the\nconnection down, we might want to still fail, so this change\nmoves the logic over to use a flag on the agent object which\none extension to set the flag and the other to read it and take\naction based upon that.\n\nChange-Id: Id3b1ae5e59282f4109f6246d5614d44c93aefa7c\nStory: 2007937\nTask: 40395\n(cherry picked from commit 2a56ee03b6ffb2d8c8f5ff553e90ecf6ee07f9af)\n(cherry picked from commit 4746f09b3dfa765684e6e20cf4b9742e1bb3bd62)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0b7c31841e4d3ec6e8027b837229d08b4562e5f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0b7c31841e4d3ec6e8027b837229d08b4562e5f7"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}