)]}'
{"id":"openstack%2Fironic-python-agent~743552","triplet_id":"openstack%2Fironic-python-agent~stable%2Fstein~Id3b1ae5e59282f4109f6246d5614d44c93aefa7c","project":"openstack/ironic-python-agent","branch":"stable/stein","hashtags":[],"change_id":"Id3b1ae5e59282f4109f6246d5614d44c93aefa7c","subject":"Prevent un-needed iscsi cleanup","status":"MERGED","created":"2020-07-28 14:17:37.000000000","updated":"2020-08-09 12:14:30.000000000","submitted":"2020-08-09 12:12:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"743552-1596975152965-480d4010","meta_rev_id":"8fa5e4ec42b7e6309f90b63c47a4d230f034a3cb","_number":743552,"virtual_id_number":743552,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-08-04 18:21:07.000000000","_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-09 12:12:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-08-04 21:17:56.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-08-09 10:35:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2020-08-09 10:35:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-04 21:17:56.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-09 10:35:17.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-08-09 12:12:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"27272904a53d4adedf86410693b0abdfd9f57dfc","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-07-28 14:17:37.000000000","message":"Patch Set 1: Cherry Picked from branch stable/train.","accounts_in_message":[],"_revision_number":1},{"id":"a58fad87fbc5617cdc597ee8af907dbbd4e0193e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-28 16:36:01.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/602f99ffa0394fc39247118f52ed80c3 : SUCCESS in 5m 31s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0d92d99bcf75422b93a5610229a4e897 : SUCCESS in 5m 15s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/1aedcaf664da4221b01f0cab99d9a845 : SUCCESS in 9m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/785da8f240e34e25849adf92c6721ca1 : SUCCESS in 4m 48s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/89100550d13a4fe1b152caef7a3500b0 : SUCCESS in 5m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2fbde8f8680547c680d72cefbd7fcc97 : SUCCESS in 6m 07s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6f46ad6dc4464217aa14ebf5b5f297b9 : SUCCESS in 6m 39s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/5dd34ed582a745ba8e9f407c89b1a3e5 : SUCCESS in 1h 21m 10s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/b4f76580a7cf45eaa04ae823d6e04226 : FAILURE in 1h 06m 21s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/564aa7c394274aeb800cae90ebd73c29 : SUCCESS in 1h 13m 56s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/010a1a31d7c84eb690ff87426dfae522 : FAILURE in 1h 15m 12s\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/7719c70a35e5403e97840fb862683776 : FAILURE in 2h 08m 31s (non-voting)\n- ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-coreos-src https://zuul.opendev.org/t/openstack/build/e6543aa2c1ad48769cc6f3f63691c72a : FAILURE in 35m 09s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/73b0a5178ecb4c8ea80c304394ea3a07 : POST_FAILURE in 14m 01s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/06e455408dc649658a419f67a8d2e424 : SUCCESS in 5m 15s","accounts_in_message":[],"_revision_number":1},{"id":"cbc765237081c4ee1526f7a49fe33c76181768a3","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-07-28 17:11:32.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/a5deca49770e4184910faa91bdd85eb8 : SUCCESS in 2h 52m 16s","accounts_in_message":[],"_revision_number":1},{"id":"037d8b73a359bfc742549fc5486e769ba9ec1043","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-08-04 18:21:07.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"5f4a2de9657c5ac58f821b9b01d36dd6fb917de1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-04 20:28:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/be6a075d318340288169bcc38d841755 : SUCCESS in 4m 00s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/fa14f041c3964435a959a7e36d025970 : SUCCESS in 4m 00s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/4696c769ec7c406bb5587d129f87f4a9 : SUCCESS in 4m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e6c5b4679e354f5db910a31fb8c2eb87 : SUCCESS in 4m 11s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/735615eebcd24987af33e3df26bd003e : SUCCESS in 4m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d94e59f8949f4451a5eff3094b51f25a : SUCCESS in 6m 06s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3992162ed8d240bfb38f2921f69668e5 : SUCCESS in 6m 11s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/22269668142d474bab2f689a8a77e47c : SUCCESS in 1h 05m 30s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/ae569495d8734910933934c1f8aabb05 : SUCCESS in 1h 02m 26s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/932cbdb718d74a49a2d557baf6cd572c : SUCCESS in 1h 31m 16s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/26660f472a4c4579bbfbc55747cdaa77 : SUCCESS in 1h 12m 19s\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/904c99fe923448fa8da61bb6985d912f : FAILURE in 2h 05m 18s (non-voting)\n- ipa-tempest-dsvm-wholedisk-bios-ipmi-direct-coreos-src https://zuul.opendev.org/t/openstack/build/35203a19850d4d8badf93bd08204f11b : FAILURE in 43m 52s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/6510f293bdd9422492746571564b1322 : SUCCESS in 4m 12s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/98e0707c26914223abc006d7d632e3ca : SUCCESS in 4m 51s","accounts_in_message":[],"_revision_number":1},{"id":"e816e283a4bcda0cb3d037640fe93932e0221435","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-08-04 21:17:56.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/5060529c1c9547e6814d3c2dc84a3e62 : SUCCESS in 2h 54m 44s","accounts_in_message":[],"_revision_number":1},{"id":"1f9ea8cbb70482e53f0aa849214cdca7f6ad5a49","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-08-09 10:35:17.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"346176b92353d005dd07c8bfbbd76883db7a73cc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-09 10:35:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2f606fcb5b344198ef67d2184c17909ea048805e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-09 12:12:32.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"360a735572bce6a06c20c46cd5919ed7ee9a4618","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-09 12:12:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/56cd9787eb0a45c89c8a7b51a1f03d11 : SUCCESS in 4m 02s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/38ccc3cc907844a59fe7bfd442a73bee : SUCCESS in 4m 08s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/05dd3b2c70354e748e0c8269a1fe4891 : SUCCESS in 4m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ebb6348c268d417b919e4e071efdc5f0 : SUCCESS in 4m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9bfd8a4c59694f989d87b220198fffbc : SUCCESS in 4m 19s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/32c1ca37aac24b019ff52bb53bb4e6bd : SUCCESS in 3m 37s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/67fcfdbc640a4b5c87d4b377a7bfe9ff : SUCCESS in 57m 05s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/aaeb2495141f4c3dbe517aabed740d9a : SUCCESS in 1h 00m 09s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/ec2ec799349d4e8592a131c7bf59db47 : SUCCESS in 55m 29s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/36fa6d8cb9ec4eba9806d4a47647010d : SUCCESS in 1h 00m 03s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/075d496ba96f40dcbf1ce3caecdbbef4 : SUCCESS in 4m 05s","accounts_in_message":[],"_revision_number":1},{"id":"8fa5e4ec42b7e6309f90b63c47a4d230f034a3cb","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-09 12:14:30.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5434771be3d040ee865c9945edae815a : SUCCESS in 44s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3a2b7e5b37254668a6f5f3c2809b149d : SUCCESS in 47s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"53d53290c357ecace4872b4fd71f0516e82e700c","revisions":{"53d53290c357ecace4872b4fd71f0516e82e700c":{"kind":"REWORK","_number":1,"created":"2020-07-28 14:17:37.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/52/743552/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/52/743552/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/52/743552/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/52/743552/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/52/743552/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/52/743552/1"}}},"commit":{"parents":[{"commit":"0819e416b029939f403a0b736ef302a02a01dfac","subject":"Rescan devices before performing uefi checks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0819e416b029939f403a0b736ef302a02a01dfac"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2020-07-20 21:24:06.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2020-07-28 14:17:37.000000000","tz":0},"subject":"Prevent un-needed iscsi cleanup","message":"Prevent un-needed iscsi cleanup\n\nWhen we added software raid support, we started calling bootloader\ninstallation. As time went on, we ehnanced that code path for non\nRAID cases in order to ensure that UEFI nvram was setup\nfor the instance to boot properly.\n\nSomewhere in this process, we missed a possible failure case where\nthe iscsi client tgtadm may return failures. Obviously, the correct\npath is to not call iscsi teardown if we don\u0027t need to.\n\nSince it was always semi-opportunistic teardown, we can\u0027t blindly\ncatch any error, and if we started iSCSI and failed to tear the\nconnection down, we might want to still fail, so this change\nmoves the logic over to use a flag on the agent object which\none extension to set the flag and the other to read it and take\naction based upon that.\n\nChange-Id: Id3b1ae5e59282f4109f6246d5614d44c93aefa7c\nStory: 2007937\nTask: 40395\n(cherry picked from commit 2a56ee03b6ffb2d8c8f5ff553e90ecf6ee07f9af)\n(cherry picked from commit 4746f09b3dfa765684e6e20cf4b9742e1bb3bd62)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/53d53290c357ecace4872b4fd71f0516e82e700c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/53d53290c357ecace4872b4fd71f0516e82e700c"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}