)]}'
{"ironic_python_agent/inspector.py":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"d9b909d84f97441843976e9284c9a175b85ca8f3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                failures.add(exc)"},{"line_number":97,"context_line":"                call_inspector(data, failures)"},{"line_number":98,"context_line":"        except TypeError:"},{"line_number":99,"context_line":"            LOG.error(\u0027The agent encountered a failure a failure while \u0027"},{"line_number":100,"context_line":"                      \u0027loading plugins and an additional exception while \u0027"},{"line_number":101,"context_line":"                      \u0027attempting to log this failure.\u0027)"},{"line_number":102,"context_line":"            LOG.error(\u0027Fatal Error loading collectors: %s\u0027, str(exc))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d4b8a42b","line":99,"range":{"start_line":99,"start_character":45,"end_line":99,"end_character":64},"updated":"2020-07-28 19:02:22.000000000","message":"Duplicate text.","commit_id":"512ce2e8edc331143b5722d2af4ddac391412e35"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"636990ed0a22d6b6db986bdf17e9ba4537b9bb0b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                failures.add(exc)"},{"line_number":97,"context_line":"                call_inspector(data, failures)"},{"line_number":98,"context_line":"        except TypeError:"},{"line_number":99,"context_line":"            LOG.error(\u0027The agent encountered a failure a failure while \u0027"},{"line_number":100,"context_line":"                      \u0027loading plugins and an additional exception while \u0027"},{"line_number":101,"context_line":"                      \u0027attempting to log this failure.\u0027)"},{"line_number":102,"context_line":"            LOG.error(\u0027Fatal Error loading collectors: %s\u0027, str(exc))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7424380e","line":99,"range":{"start_line":99,"start_character":45,"end_line":99,"end_character":64},"in_reply_to":"9f560f44_d4b8a42b","updated":"2020-07-28 19:28:05.000000000","message":"woot!","commit_id":"512ce2e8edc331143b5722d2af4ddac391412e35"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3fb20411493ba84791daf663d2fc20f7eb152ce1","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                failures.add(exc)"},{"line_number":97,"context_line":"                call_inspector(data, failures)"},{"line_number":98,"context_line":"        except TypeError:"},{"line_number":99,"context_line":"            LOG.error(\u0027The agent encountered a failure while loading\u0027"},{"line_number":100,"context_line":"                      \u0027plugins and an additional exception while \u0027"},{"line_number":101,"context_line":"                      \u0027attempting to log this failure.\u0027)"},{"line_number":102,"context_line":"            LOG.error(\u0027Fatal Error loading collectors: %s\u0027, str(exc))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_451a047d","line":99,"updated":"2020-07-30 10:04:41.000000000","message":"missing space in the end","commit_id":"6186a3fdeb4fcd2f30fee848dc974bab62b0c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3fb20411493ba84791daf663d2fc20f7eb152ce1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        except TypeError:"},{"line_number":99,"context_line":"            LOG.error(\u0027The agent encountered a failure while loading\u0027"},{"line_number":100,"context_line":"                      \u0027plugins and an additional exception while \u0027"},{"line_number":101,"context_line":"                      \u0027attempting to log this failure.\u0027)"},{"line_number":102,"context_line":"            LOG.error(\u0027Fatal Error loading collectors: %s\u0027, str(exc))"},{"line_number":103,"context_line":"            raise exc"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_251d5073","line":101,"updated":"2020-07-30 10:04:41.000000000","message":"TypeError can happen for numerous reasons, let\u0027s at least log it in addition to exc","commit_id":"6186a3fdeb4fcd2f30fee848dc974bab62b0c874"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c6c131a8830a19cadd5b89b82be4696b0142e17e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        except TypeError:"},{"line_number":99,"context_line":"            LOG.error(\u0027The agent encountered a failure while loading\u0027"},{"line_number":100,"context_line":"                      \u0027plugins and an additional exception while \u0027"},{"line_number":101,"context_line":"                      \u0027attempting to log this failure.\u0027)"},{"line_number":102,"context_line":"            LOG.error(\u0027Fatal Error loading collectors: %s\u0027, str(exc))"},{"line_number":103,"context_line":"            raise exc"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_7a9b5ec8","line":101,"in_reply_to":"9f560f44_251d5073","updated":"2020-07-30 13:25:30.000000000","message":"The TypeError is coming from journald in trying to handle the original exception. Which means we may need a TypeError catch to catch the possible second logging failure. My whole thought there was try to avoid making the same mistake oslo_utils.excutils is making. And I\u0027m not suggesting an actual mistake, but it is a point in which the entire thing goes sideways.","commit_id":"6186a3fdeb4fcd2f30fee848dc974bab62b0c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3fb20411493ba84791daf663d2fc20f7eb152ce1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            LOG.error(\u0027The agent encountered a failure while loading\u0027"},{"line_number":100,"context_line":"                      \u0027plugins and an additional exception while \u0027"},{"line_number":101,"context_line":"                      \u0027attempting to log this failure.\u0027)"},{"line_number":102,"context_line":"            LOG.error(\u0027Fatal Error loading collectors: %s\u0027, str(exc))"},{"line_number":103,"context_line":"            raise exc"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    for name, collector in collectors:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_85141c50","line":102,"updated":"2020-07-30 10:04:41.000000000","message":"Please use only one logging record to avoid confusion\n\nalso str() is unnecessary","commit_id":"6186a3fdeb4fcd2f30fee848dc974bab62b0c874"}]}