)]}'
{"ironic_python_agent/inspector.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"003e20b6273b0b0d273d51810a71bd0daed5859b","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                pci_class \u003d vendor_device.read().strip().split(\u0027x\u0027)[1]"},{"line_number":321,"context_line":"            with open(os.path.join(pci_devices_path, subdir,"},{"line_number":322,"context_line":"                                   \u0027revision\u0027)) as vendor_device:"},{"line_number":323,"context_line":"                rev \u003d vendor_device.read().strip().split(\u0027x\u0027)[1]"},{"line_number":324,"context_line":"        except IOError as exc:"},{"line_number":325,"context_line":"            LOG.warning(\u0027Failed to gather vendor id, product id, pci class \u0027"},{"line_number":326,"context_line":"                        \u0027or revision from PCI device %s: %s\u0027, subdir, exc)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7b7cc01e","line":323,"updated":"2020-08-04 10:44:06.000000000","message":"I assume these two files are always present?","commit_id":"0c85761f759f5790d20f26554e777bbc8a00a3f3"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"28311f72cee75fbfc3ba5bde206346fc39ab75c7","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                pci_class \u003d vendor_device.read().strip().split(\u0027x\u0027)[1]"},{"line_number":321,"context_line":"            with open(os.path.join(pci_devices_path, subdir,"},{"line_number":322,"context_line":"                                   \u0027revision\u0027)) as vendor_device:"},{"line_number":323,"context_line":"                rev \u003d vendor_device.read().strip().split(\u0027x\u0027)[1]"},{"line_number":324,"context_line":"        except IOError as exc:"},{"line_number":325,"context_line":"            LOG.warning(\u0027Failed to gather vendor id, product id, pci class \u0027"},{"line_number":326,"context_line":"                        \u0027or revision from PCI device %s: %s\u0027, subdir, exc)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ac7bc0bb","line":323,"in_reply_to":"9f560f44_7b7cc01e","updated":"2020-08-04 14:17:09.000000000","message":"Tested today, sadly not, pci class should be available, but revision depends on kernel version, I guess we need to have a check before reading. On the other hand the revision doesn\u0027t have much use and can also be simply removed.","commit_id":"0c85761f759f5790d20f26554e777bbc8a00a3f3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ef3404964e31035d396de92a73c4580a01063ee7","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                pci_class \u003d vendor_device.read().strip().split(\u0027x\u0027)[1]"},{"line_number":321,"context_line":"            with open(os.path.join(pci_devices_path, subdir,"},{"line_number":322,"context_line":"                                   \u0027revision\u0027)) as vendor_device:"},{"line_number":323,"context_line":"                rev \u003d vendor_device.read().strip().split(\u0027x\u0027)[1]"},{"line_number":324,"context_line":"        except IOError as exc:"},{"line_number":325,"context_line":"            LOG.warning(\u0027Failed to gather vendor id, product id, pci class \u0027"},{"line_number":326,"context_line":"                        \u0027or revision from PCI device %s: %s\u0027, subdir, exc)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e76673c1","line":323,"in_reply_to":"9f560f44_ac7bc0bb","updated":"2020-08-04 14:31:04.000000000","message":"Okay, let\u0027s move the optional bits out of this try..except block and make sure their absence doesn\u0027t break detection.","commit_id":"0c85761f759f5790d20f26554e777bbc8a00a3f3"}]}