)]}'
{"examples/business-logic/example_business_logic.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ddd2942b427811b0a38669e7070535c9b14afc97","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                       the deploy steps from all the drivers, with the largest"},{"line_number":111,"context_line":"                       priority step being run first. If priority is set to 0,"},{"line_number":112,"context_line":"                       the step will not be run during deployment, but may be"},{"line_number":113,"context_line":"                       run during zapping."},{"line_number":114,"context_line":"           \u0027reboot_requested\u0027: Whether the agent should request Ironic reboots"},{"line_number":115,"context_line":"                               the node via the power driver after the"},{"line_number":116,"context_line":"                               operation completes."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e7ef931b","line":113,"updated":"2020-08-04 14:42:31.000000000","message":"1) I thought zapping \u003d\u003d manual cleaning?\n2) Does this mean I can run any deploy OR cleaning step during manual cleaning?","commit_id":"2a3c21867f13dfa9e09517a49963c66cfeb96091"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9642d0857fec6d6675a92cc50cf6a1e4c0ae7462","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                       the deploy steps from all the drivers, with the largest"},{"line_number":111,"context_line":"                       priority step being run first. If priority is set to 0,"},{"line_number":112,"context_line":"                       the step will not be run during deployment, but may be"},{"line_number":113,"context_line":"                       run during zapping."},{"line_number":114,"context_line":"           \u0027reboot_requested\u0027: Whether the agent should request Ironic reboots"},{"line_number":115,"context_line":"                               the node via the power driver after the"},{"line_number":116,"context_line":"                               operation completes."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_072d67fd","line":113,"in_reply_to":"9f560f44_e7ef931b","updated":"2020-08-04 14:51:30.000000000","message":"Ooops, bad copy pasta. No, you cannot run deploy steps during cleaning.","commit_id":"2a3c21867f13dfa9e09517a49963c66cfeb96091"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ddd2942b427811b0a38669e7070535c9b14afc97","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        # Use dispatch_to_managers to avoid tight coupling between hardware"},{"line_number":178,"context_line":"        # managers. It would make sense even if this hardware manager"},{"line_number":179,"context_line":"        # implemented get_memory, because a more specific hardware managers"},{"line_number":180,"context_line":"        # could do it better."},{"line_number":181,"context_line":"        current \u003d hardware.dispatch_to_managers(\u0027get_memory\u0027)"},{"line_number":182,"context_line":"        if current.physical_mb \u003c expected:"},{"line_number":183,"context_line":"            raise errors.DeploymentError("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_877fb713","line":180,"updated":"2020-08-04 14:42:31.000000000","message":"Perhaps document what this does if it fails? Deployment fails? Sets a last_error? Does node go into maint?","commit_id":"2a3c21867f13dfa9e09517a49963c66cfeb96091"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9642d0857fec6d6675a92cc50cf6a1e4c0ae7462","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        # Use dispatch_to_managers to avoid tight coupling between hardware"},{"line_number":178,"context_line":"        # managers. It would make sense even if this hardware manager"},{"line_number":179,"context_line":"        # implemented get_memory, because a more specific hardware managers"},{"line_number":180,"context_line":"        # could do it better."},{"line_number":181,"context_line":"        current \u003d hardware.dispatch_to_managers(\u0027get_memory\u0027)"},{"line_number":182,"context_line":"        if current.physical_mb \u003c expected:"},{"line_number":183,"context_line":"            raise errors.DeploymentError("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_27386b3b","line":180,"in_reply_to":"9f560f44_877fb713","updated":"2020-08-04 14:51:30.000000000","message":"Done","commit_id":"2a3c21867f13dfa9e09517a49963c66cfeb96091"}]}