)]}'
{"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d47575d24f1f8804064f117fc075e30c79a7f92","unresolved":false,"context_lines":[{"line_number":744,"context_line":""},{"line_number":745,"context_line":"def _append_uefi_to_fstab(fs_path, efi_system_part_uuid):"},{"line_number":746,"context_line":"    fstab_file \u003d fs_path + \u0027/etc/fstab\u0027"},{"line_number":747,"context_line":"    if os.path.exists(fstab_file):"},{"line_number":748,"context_line":"        fstab_string \u003d (\"UUID\u003d%s\\t/boot/efi\\tvfat\\tumask\u003d0077\\t\""},{"line_number":749,"context_line":"                        \"0\\t1\\n\") % efi_system_part_uuid"},{"line_number":750,"context_line":"        fstab \u003d open(fstab_file, \"a\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_494d5a70","line":747,"updated":"2020-09-12 11:05:37.000000000","message":"nit:\n\n if not ...\n     return","commit_id":"de824a60c29f1e8f14d5bf00946adb15329d8f5f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d47575d24f1f8804064f117fc075e30c79a7f92","unresolved":false,"context_lines":[{"line_number":747,"context_line":"    if os.path.exists(fstab_file):"},{"line_number":748,"context_line":"        fstab_string \u003d (\"UUID\u003d%s\\t/boot/efi\\tvfat\\tumask\u003d0077\\t\""},{"line_number":749,"context_line":"                        \"0\\t1\\n\") % efi_system_part_uuid"},{"line_number":750,"context_line":"        fstab \u003d open(fstab_file, \"a\")"},{"line_number":751,"context_line":"        fstab.write(fstab_string)"},{"line_number":752,"context_line":"        fstab.close()"},{"line_number":753,"context_line":"        LOG.debug(\u0027Added entry to /etc/fstab for EFI partition auto-mount \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_2950e609","line":750,"updated":"2020-09-12 11:05:37.000000000","message":"please use `with` instead of open..close..","commit_id":"de824a60c29f1e8f14d5bf00946adb15329d8f5f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5d47575d24f1f8804064f117fc075e30c79a7f92","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        fstab_string \u003d (\"UUID\u003d%s\\t/boot/efi\\tvfat\\tumask\u003d0077\\t\""},{"line_number":749,"context_line":"                        \"0\\t1\\n\") % efi_system_part_uuid"},{"line_number":750,"context_line":"        fstab \u003d open(fstab_file, \"a\")"},{"line_number":751,"context_line":"        fstab.write(fstab_string)"},{"line_number":752,"context_line":"        fstab.close()"},{"line_number":753,"context_line":"        LOG.debug(\u0027Added entry to /etc/fstab for EFI partition auto-mount \u0027"},{"line_number":754,"context_line":"                  \u0027with uuid %s\u0027, efi_system_part_uuid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_8953f215","line":751,"updated":"2020-09-12 11:05:37.000000000","message":"I\u0027d like to see some error handling","commit_id":"de824a60c29f1e8f14d5bf00946adb15329d8f5f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"722ba89587262d4f078e1cc7bfcd43ed126778ad","unresolved":false,"context_lines":[{"line_number":566,"context_line":"            # asset preservation logic at some point since the paths"},{"line_number":567,"context_line":"            # can be a little different, but largely this is JUST for"},{"line_number":568,"context_line":"            # partition images as there _should not_ be a mount"},{"line_number":569,"context_line":"            # point if we have no efi partitions at all. "},{"line_number":570,"context_line":"            efi_preserved \u003d _try_preserve_efi_assets("},{"line_number":571,"context_line":"                device, path, efi_system_part_uuid,"},{"line_number":572,"context_line":"                efi_partitions, efi_partition_mount_point)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_c9afef9a","line":569,"updated":"2020-10-09 21:14:07.000000000","message":"pep8: W291 trailing whitespace","commit_id":"7c11821ae94728d9f1d922f3230657d98fbba63e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8d46d9c9a510a9e631d96a8a00e3301f2df30d07","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                                     \u0027GRUB_DISABLE_OS_PROBER\u0027: \u0027true\u0027},"},{"line_number":695,"context_line":"                      use_standard_locale\u003dTrue)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        LOG.info(\"GRUB2 successfully installed on %s\", device)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        if efi_mounted:"},{"line_number":700,"context_line":"            _append_uefi_to_fstab(path, efi_system_part_uuid)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f65232a_7909b893","line":697,"updated":"2020-10-27 11:27:56.000000000","message":"Let\u0027s move the success logging to the very end","commit_id":"2d2de51e793d3bf7a2c6c2aff77b751c1167e018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"56067bde8030ae6401063fd5b71a3499e7bcec29","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                                     \u0027GRUB_DISABLE_OS_PROBER\u0027: \u0027true\u0027},"},{"line_number":695,"context_line":"                      use_standard_locale\u003dTrue)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        LOG.info(\"GRUB2 successfully installed on %s\", device)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        if efi_mounted:"},{"line_number":700,"context_line":"            _append_uefi_to_fstab(path, efi_system_part_uuid)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f621f24_f018dd1e","line":697,"in_reply_to":"3f65232a_7909b893","updated":"2020-11-18 14:45:17.000000000","message":"Done","commit_id":"2d2de51e793d3bf7a2c6c2aff77b751c1167e018"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8d46d9c9a510a9e631d96a8a00e3301f2df30d07","unresolved":false,"context_lines":[{"line_number":787,"context_line":"    :param fs_path:"},{"line_number":788,"context_line":"    :param efi_system_part_uuid:"},{"line_number":789,"context_line":"    \"\"\""},{"line_number":790,"context_line":"    fstab_file \u003d fs_path + \u0027/etc/fstab\u0027"},{"line_number":791,"context_line":"    if os.path.exists(fstab_file):"},{"line_number":792,"context_line":"        try:"},{"line_number":793,"context_line":"            fstab_string \u003d (\"UUID\u003d%s\\t/boot/efi\\tvfat\\tumask\u003d0077\\t\""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f65232a_d900cc6a","line":790,"updated":"2020-10-27 11:27:56.000000000","message":"nit: os.path.join","commit_id":"2d2de51e793d3bf7a2c6c2aff77b751c1167e018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"56067bde8030ae6401063fd5b71a3499e7bcec29","unresolved":false,"context_lines":[{"line_number":787,"context_line":"    :param fs_path:"},{"line_number":788,"context_line":"    :param efi_system_part_uuid:"},{"line_number":789,"context_line":"    \"\"\""},{"line_number":790,"context_line":"    fstab_file \u003d fs_path + \u0027/etc/fstab\u0027"},{"line_number":791,"context_line":"    if os.path.exists(fstab_file):"},{"line_number":792,"context_line":"        try:"},{"line_number":793,"context_line":"            fstab_string \u003d (\"UUID\u003d%s\\t/boot/efi\\tvfat\\tumask\u003d0077\\t\""}],"source_content_type":"text/x-python","patch_set":15,"id":"1f621f24_50df1139","line":790,"in_reply_to":"3f65232a_d900cc6a","updated":"2020-11-18 14:45:17.000000000","message":"Done","commit_id":"2d2de51e793d3bf7a2c6c2aff77b751c1167e018"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8d46d9c9a510a9e631d96a8a00e3301f2df30d07","unresolved":false,"context_lines":[{"line_number":788,"context_line":"    :param efi_system_part_uuid:"},{"line_number":789,"context_line":"    \"\"\""},{"line_number":790,"context_line":"    fstab_file \u003d fs_path + \u0027/etc/fstab\u0027"},{"line_number":791,"context_line":"    if os.path.exists(fstab_file):"},{"line_number":792,"context_line":"        try:"},{"line_number":793,"context_line":"            fstab_string \u003d (\"UUID\u003d%s\\t/boot/efi\\tvfat\\tumask\u003d0077\\t\""},{"line_number":794,"context_line":"                            \"0\\t1\\n\") % efi_system_part_uuid"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f65232a_b9035073","line":791,"updated":"2020-10-27 11:27:56.000000000","message":"nit:\n\n if not..\n    return","commit_id":"2d2de51e793d3bf7a2c6c2aff77b751c1167e018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"56067bde8030ae6401063fd5b71a3499e7bcec29","unresolved":false,"context_lines":[{"line_number":788,"context_line":"    :param efi_system_part_uuid:"},{"line_number":789,"context_line":"    \"\"\""},{"line_number":790,"context_line":"    fstab_file \u003d fs_path + \u0027/etc/fstab\u0027"},{"line_number":791,"context_line":"    if os.path.exists(fstab_file):"},{"line_number":792,"context_line":"        try:"},{"line_number":793,"context_line":"            fstab_string \u003d (\"UUID\u003d%s\\t/boot/efi\\tvfat\\tumask\u003d0077\\t\""},{"line_number":794,"context_line":"                            \"0\\t1\\n\") % efi_system_part_uuid"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f621f24_b0e78512","line":791,"in_reply_to":"3f65232a_b9035073","updated":"2020-11-18 14:45:17.000000000","message":"Done","commit_id":"2d2de51e793d3bf7a2c6c2aff77b751c1167e018"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8d46d9c9a510a9e631d96a8a00e3301f2df30d07","unresolved":false,"context_lines":[{"line_number":795,"context_line":"            with open(fstab_file, \"r+\") as fstab:"},{"line_number":796,"context_line":"                if efi_system_part_uuid not in fstab.read():"},{"line_number":797,"context_line":"                    fstab.writelines(fstab_string)"},{"line_number":798,"context_line":"        except OSError as exc:"},{"line_number":799,"context_line":"            LOG.debug(\u0027Failed to add entry to /etc/fstab. Error %s\u0027, exc)"},{"line_number":800,"context_line":"        LOG.debug(\u0027Added entry to /etc/fstab for EFI partition auto-mount \u0027"},{"line_number":801,"context_line":"                  \u0027with uuid %s\u0027, efi_system_part_uuid)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f65232a_19fa4474","line":798,"updated":"2020-10-27 11:27:56.000000000","message":"EnvironmentError (you may get IOError as well)","commit_id":"2d2de51e793d3bf7a2c6c2aff77b751c1167e018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"56067bde8030ae6401063fd5b71a3499e7bcec29","unresolved":false,"context_lines":[{"line_number":795,"context_line":"            with open(fstab_file, \"r+\") as fstab:"},{"line_number":796,"context_line":"                if efi_system_part_uuid not in fstab.read():"},{"line_number":797,"context_line":"                    fstab.writelines(fstab_string)"},{"line_number":798,"context_line":"        except OSError as exc:"},{"line_number":799,"context_line":"            LOG.debug(\u0027Failed to add entry to /etc/fstab. Error %s\u0027, exc)"},{"line_number":800,"context_line":"        LOG.debug(\u0027Added entry to /etc/fstab for EFI partition auto-mount \u0027"},{"line_number":801,"context_line":"                  \u0027with uuid %s\u0027, efi_system_part_uuid)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f621f24_90cd2987","line":798,"in_reply_to":"3f65232a_19fa4474","updated":"2020-11-18 14:45:17.000000000","message":"Done","commit_id":"2d2de51e793d3bf7a2c6c2aff77b751c1167e018"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3dbbf7675a16031fc8568f4eaa1ac10ccf07fc22","unresolved":true,"context_lines":[{"line_number":829,"context_line":"def _append_uefi_to_fstab(fs_path, efi_system_part_uuid):"},{"line_number":830,"context_line":"    \"\"\"Append the efi partition id to the filesystem table."},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"    :param fs_path:"},{"line_number":833,"context_line":"    :param efi_system_part_uuid:"},{"line_number":834,"context_line":"    \"\"\""},{"line_number":835,"context_line":"    fstab_file \u003d os.path.join(fs_path, \u0027etc/fstab\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"f720fa9f_ed09056b","line":832,"updated":"2021-03-23 08:28:18.000000000","message":"probably need a follow up to finish this?","commit_id":"a12a5744b66063816af17769f99ec3f03da0a2d5"}]}