)]}'
{"ironic_python_agent/ironic_api_client.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9af3d6100c7a64f2b0fcbbf8e3290a44abd00dc5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def _get_ironic_api_version_header(self, version\u003dNone):"},{"line_number":84,"context_line":"        if version is None:"},{"line_number":85,"context_line":"            ironic_version \u003d self._get_ironic_api_version()"},{"line_number":86,"context_line":"            version \u003d min(ironic_version, AGENT_TOKEN_IRONIC_VERSION)"},{"line_number":87,"context_line":"        return {\u0027X-OpenStack-Ironic-API-Version\u0027: \u0027%d.%d\u0027 % version}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _get_ironic_api_version(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9c660151","line":86,"updated":"2020-09-06 16:13:44.000000000","message":"I seem to remember there was a reason we went down the strictversion route but at this point that never materialized so I guess this is okay.","commit_id":"cf05eff879f50a7176128da2a50cdc2c5a77227f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c8ab1228b40c09e3642f5cd9f134aa9726aa75de","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def _get_ironic_api_version_header(self, version\u003dNone):"},{"line_number":84,"context_line":"        if version is None:"},{"line_number":85,"context_line":"            ironic_version \u003d self._get_ironic_api_version()"},{"line_number":86,"context_line":"            version \u003d min(ironic_version, AGENT_TOKEN_IRONIC_VERSION)"},{"line_number":87,"context_line":"        return {\u0027X-OpenStack-Ironic-API-Version\u0027: \u0027%d.%d\u0027 % version}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _get_ironic_api_version(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b2e1369e","line":86,"in_reply_to":"9f560f44_52c1ba7f","updated":"2020-09-09 21:29:49.000000000","message":"I\u0027m wrong. See https://gist.github.com/jayofdoom/cef64a13595042ca655d1e9fd88fe080","commit_id":"cf05eff879f50a7176128da2a50cdc2c5a77227f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"cee5dac423eb9508e72941eb28e9be5abe182959","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def _get_ironic_api_version_header(self, version\u003dNone):"},{"line_number":84,"context_line":"        if version is None:"},{"line_number":85,"context_line":"            ironic_version \u003d self._get_ironic_api_version()"},{"line_number":86,"context_line":"            version \u003d min(ironic_version, AGENT_TOKEN_IRONIC_VERSION)"},{"line_number":87,"context_line":"        return {\u0027X-OpenStack-Ironic-API-Version\u0027: \u0027%d.%d\u0027 % version}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _get_ironic_api_version(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_52c1ba7f","line":86,"in_reply_to":"9f560f44_9c660151","updated":"2020-09-09 21:04:47.000000000","message":"Unless there\u0027s a compelling reason not to, it seems like a direct downgrade to no longer use StrictVersion. For instance, 1.10 vs 1.9, I think it\u0027d take 1.9 with a min(), correct?","commit_id":"cf05eff879f50a7176128da2a50cdc2c5a77227f"}]}
