)]}'
{"id":"openstack%2Fironic-python-agent~751871","triplet_id":"openstack%2Fironic-python-agent~stable%2Fussuri~I59ecec65707a2f03918b233f1925395ebe59b8c4","project":"openstack/ironic-python-agent","branch":"stable/ussuri","hashtags":[],"change_id":"I59ecec65707a2f03918b233f1925395ebe59b8c4","subject":"Fix backup node lookup","status":"ABANDONED","created":"2020-09-14 17:17:57.000000000","updated":"2020-09-23 18:51:45.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f5941bb764ad062e419e7277395648f1b1a3e400","_number":751871,"virtual_id_number":751871,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2020-09-14 19:22:24.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-09-14 19:17:13.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-14 19:17:13.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-14 19:22:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"99e506f6d964c83c311397764c5096cbc29c1fda","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-09-14 17:17:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"594458b9c8694c60e641b8cd44b276b14123f7b9","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-09-14 19:17:13.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/1481a2290a564f5c8971fe9febf96681 : SUCCESS in 1h 58m 18s","accounts_in_message":[],"_revision_number":1},{"id":"acdaadadeedadfa19ea62c4e36c78e8a07d9a70a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-14 19:22:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e923a23b21c340f2aab060878e90f219 : SUCCESS in 3m 51s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c3df0b679da64ea4838557d86b78ec84 : SUCCESS in 5m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/fa69450850bb441eacfc0b6d1d240415 : SUCCESS in 6m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/056508bc4d6b46858196bb4b0452753f : SUCCESS in 7m 01s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ca12551cf1844ddb84e019357083a986 : SUCCESS in 8m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1f68bd7aa470422db62306869ad2ae53 : SUCCESS in 6m 15s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c13b568e3b024c0d8413592386a00184 : SUCCESS in 5m 24s\n- ipa-tempest-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/bb8a0cd3094d4337a84b2bb354cb1176 : SUCCESS in 1h 23m 31s\n- ipa-tempest-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/6784e6e8a6ea4e9b8d387ab05ecadddb : SUCCESS in 1h 09m 01s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/6f3a19f8ecd5468ebdd975859ea0e59f : SUCCESS in 1h 16m 06s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/7507d3a546ee4ba682789539fbc319a7 : SUCCESS in 1h 16m 33s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/db29762e01734ec98c8182ca6ecaca38 : FAILURE in 3m 45s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/b47f58d02bd045d0bac9fbc461da6751 : SUCCESS in 8m 57s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/fe3b00fff23c449fbc8cb39d41adae2a : SUCCESS in 1h 52m 05s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/4fbf23f68f834544a500bea897ddff40 : SUCCESS in 1h 28m 25s (non-voting)\n- ipa-tempest-partition-bios-ipmi-iscsi-dib-src https://zuul.opendev.org/t/openstack/build/cfd1385c4be24a388a529e09e4887f23 : SUCCESS in 1h 53m 33s (non-voting)\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/7f92cceb03bc44b78088dd9c5c257bff : SUCCESS in 4m 23s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/b0a932f3c7a34bc38cd370e1733cc09d : SUCCESS in 4m 12s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f5941bb764ad062e419e7277395648f1b1a3e400","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-09-23 18:51:45.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6d267724f8ed7555fca7b3a3139a54aac5798f9e","revisions":{"6d267724f8ed7555fca7b3a3139a54aac5798f9e":{"kind":"REWORK","_number":1,"created":"2020-09-14 17:17:57.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/71/751871/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/71/751871/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/71/751871/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/71/751871/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/71/751871/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/71/751871/1"}}},"commit":{"parents":[{"commit":"03abf4e3dea014c06be16416033bd27f03fc1c97","subject":"Update the cache if we don\u0027t have a root device hint","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/03abf4e3dea014c06be16416033bd27f03fc1c97"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2020-09-09 22:14:46.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2020-09-14 17:17:51.000000000","tz":-420},"subject":"Fix backup node lookup","message":"Fix backup node lookup\n\nThe node lookup code added in change\nI27201319f31cdc01605a3c5ae9ef4b4218e4a3f6\nwas slightly broken in that we call a method\nwith a keyword arguemnt which doesn\u0027t exist.\n\nuuid versus node_uuid.\n\nIt happens, it is a quick fix!\n\nSpotted on a metalsmith job:\n\n[-] Agent is requesting to perform an explicit node cache update.\n    This is to pickup any chanages in the cache before deployment.\n[-] Failed to update node cache. Error lookup_node() got an\n    unexpected keyword argument \u0027uuid\u0027\n\nChange-Id: I59ecec65707a2f03918b233f1925395ebe59b8c4\n(cherry picked from commit 3426963552966af9feae2c79c7c53ee770a9523c)\n(cherry picked from commit 6c696e6b7e7f1ef7cbe99a0c5f960b7dea358cf6)\n(cherry picked from commit 3adb19634c4727dbdf78aeb18dc36bafb285c80b)\n(cherry picked from commit 209563559905da552bf60daa248d66afe4c679a9)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6d267724f8ed7555fca7b3a3139a54aac5798f9e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6d267724f8ed7555fca7b3a3139a54aac5798f9e"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
