)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ed9673638a7f7e569959a3d839c99c185253b374","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f560f44_e2cffc88","line":17,"updated":"2020-09-15 18:53:17.000000000","message":"You\u0027ll need to add the Task for the story as well. Storyboard monitors and keys off the task to lose out the pending work on the item.","commit_id":"c2e1aa7c7fd8e04ab1f24b689a88d5ff642ce9a9"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"395f3e9b17e815ae347c629e682b954fe2add041","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: make Intel CNA hardware manager none generic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, InterlCnaHardwareManager inherits GenericHardwareManager"},{"line_number":10,"context_line":"which makes it a new \"GenericHardwareManager\" with \"MAINLINE\" priority."},{"line_number":11,"context_line":"This causes all other hardware-managers with lower priority than"},{"line_number":12,"context_line":"\"MAINLINE\" never be used. To fix this, make InterlCnaHardwareManager"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_385a4ef1","line":9,"updated":"2020-09-22 15:45:16.000000000","message":"nit: s/Interl/Intel/","commit_id":"ead035f0d105aa5822726985927b3a8e82475d08"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"395f3e9b17e815ae347c629e682b954fe2add041","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, InterlCnaHardwareManager inherits GenericHardwareManager"},{"line_number":10,"context_line":"which makes it a new \"GenericHardwareManager\" with \"MAINLINE\" priority."},{"line_number":11,"context_line":"This causes all other hardware-managers with lower priority than"},{"line_number":12,"context_line":"\"MAINLINE\" never be used. To fix this, make InterlCnaHardwareManager"},{"line_number":13,"context_line":"inherit basic HardwareManager."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I28b665d8841b0b2e83b132e1f25df95e03e7ba10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_d8687289","line":12,"updated":"2020-09-22 15:45:16.000000000","message":"same as above","commit_id":"ead035f0d105aa5822726985927b3a8e82475d08"}],"ironic_python_agent/hardware_managers/cna.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"fe802a9b1675614b2b81d9e8fd4d3a58b3ea6ae5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        hardware managers chain."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :param interface_names: list of names of node\u0027s interfaces."},{"line_number":94,"context_line":"        :raises: IncompatibleHardwareMethodError exception after disable"},{"line_number":95,"context_line":"        embedded lldp agent in cna card."},{"line_number":96,"context_line":"        \"\"\""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_93a9387e","line":94,"range":{"start_line":94,"start_character":65,"end_line":94,"end_character":72},"updated":"2020-09-15 14:55:47.000000000","message":"Nit: after disabling the embedded lldp agent in the CNA card","commit_id":"f570402ffb1fec848b5aaa21de89e272aa574374"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"fe802a9b1675614b2b81d9e8fd4d3a58b3ea6ae5","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        _disable_embedded_lldp_agent_in_cna_card()"},{"line_number":99,"context_line":"        # NOTE(Qianbiao.NG): raise error to give other manager a chance to"},{"line_number":100,"context_line":"        # finish the collect lldp data logic. Currently, the collect-lldp-data"},{"line_number":101,"context_line":"        # will be handled by GenericHardwareManager"},{"line_number":102,"context_line":"        message \u003d (\"Re-dispatch collect_lldp_data intent to hardware managers \""},{"line_number":103,"context_line":"                   \"chain after cna card lldp agent is disabled.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_73bf44aa","line":100,"range":{"start_line":100,"start_character":57,"end_line":100,"end_character":78},"updated":"2020-09-15 14:55:47.000000000","message":"Nit: s/the collect-lldp-data/collect_lldp_data/","commit_id":"f570402ffb1fec848b5aaa21de89e272aa574374"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"736209a088924a588a684cf100236f2040cea800","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # will be handled by GenericHardwareManager"},{"line_number":102,"context_line":"        message \u003d (\"Re-dispatch collect_lldp_data intent to hardware managers \""},{"line_number":103,"context_line":"                   \"chain after cna card lldp agent is disabled.\")"},{"line_number":104,"context_line":"        raise errors.IncompatibleHardwareMethodError(message)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_b8519adc","line":104,"range":{"start_line":104,"start_character":21,"end_line":104,"end_character":52},"updated":"2020-09-16 21:07:00.000000000","message":"I can see that this would work but it overrides this exception with a different meaning (calling this manager has a side-effect which needs to happen before the actual collection)\n\nThe message describes what is happening, but it looks like it is never displayed or logged, instead in dispatch_to_all_managers and dispatch_to_managers we have this:\n\n            except errors.IncompatibleHardwareMethodError:\n                LOG.debug(\u0027HardwareManager {} does not support {}\u0027\n                          .format(manager, method))\n\nIf this logging did the following it would be clear what actually happened:\n- included IncompatibleHardwareMethodError.details if it is not empty\n- said something like \"did not action\" instead of \"does not support\"","commit_id":"9f52626e18a5058ced3a0c31602a29ffa941126a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d1d002bfdf0c5cbeebdde79ad387b0c499937d03","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # will be handled by GenericHardwareManager"},{"line_number":102,"context_line":"        message \u003d (\"Re-dispatch collect_lldp_data intent to hardware managers \""},{"line_number":103,"context_line":"                   \"chain after cna card lldp agent is disabled.\")"},{"line_number":104,"context_line":"        raise errors.IncompatibleHardwareMethodError(message)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7c27bfc8","line":104,"range":{"start_line":104,"start_character":21,"end_line":104,"end_character":52},"in_reply_to":"9f560f44_14716a78","updated":"2020-09-20 20:25:58.000000000","message":"My suggestion would be to break out GenericHardwareManager.collect_lldp_data into a standalone function, and have GenericHardwareManager.collect_lldp_data and IntelCnaHardwareManager.collect_lldp_data call it.","commit_id":"9f52626e18a5058ced3a0c31602a29ffa941126a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2fade16f5f2afc2e27f9f476a266fcbd29cf7c58","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # will be handled by GenericHardwareManager"},{"line_number":102,"context_line":"        message \u003d (\"Re-dispatch collect_lldp_data intent to hardware managers \""},{"line_number":103,"context_line":"                   \"chain after cna card lldp agent is disabled.\")"},{"line_number":104,"context_line":"        raise errors.IncompatibleHardwareMethodError(message)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_b914f74e","line":104,"range":{"start_line":104,"start_character":21,"end_line":104,"end_character":52},"in_reply_to":"9f560f44_5f62e33e","updated":"2020-09-17 08:41:58.000000000","message":"We can probably create a new exception with different logging? I\u0027m quite against calling another hardware manager\u0027s method because they\u0027re supposed to be orthogonal and *in theory* the generic one may not be the one providing the actual collect_lldp_data.\n\nA completely different approach would be to handle this logic in evaluate_harware_support and not override any methods at all.","commit_id":"9f52626e18a5058ced3a0c31602a29ffa941126a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2f60e4706925d70e55d3fede2d48f3702c3fdc9a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # will be handled by GenericHardwareManager"},{"line_number":102,"context_line":"        message \u003d (\"Re-dispatch collect_lldp_data intent to hardware managers \""},{"line_number":103,"context_line":"                   \"chain after cna card lldp agent is disabled.\")"},{"line_number":104,"context_line":"        raise errors.IncompatibleHardwareMethodError(message)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_87fb60bc","line":104,"range":{"start_line":104,"start_character":21,"end_line":104,"end_character":52},"in_reply_to":"9f560f44_7c27bfc8","updated":"2020-09-20 23:11:49.000000000","message":"Have you considered putting it in evaluate_hardware_support and then removing this method? e.g.; if _detect_cna_card(); log; disable lldp agent, return. This is not ideal if disabling the lldp agent is a task that takes long, but if it\u0027s nearly free you should just do it there.","commit_id":"9f52626e18a5058ced3a0c31602a29ffa941126a"},{"author":{"_account_id":29702,"name":"QianBiao Ng","email":"iampurse@vip.qq.com","username":"QianBiao.NG"},"change_message_id":"0cf99b30190dabc19187e42559d9076a5c7ebc84","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # will be handled by GenericHardwareManager"},{"line_number":102,"context_line":"        message \u003d (\"Re-dispatch collect_lldp_data intent to hardware managers \""},{"line_number":103,"context_line":"                   \"chain after cna card lldp agent is disabled.\")"},{"line_number":104,"context_line":"        raise errors.IncompatibleHardwareMethodError(message)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_fc61f312","line":104,"range":{"start_line":104,"start_character":21,"end_line":104,"end_character":52},"in_reply_to":"9f560f44_7c27bfc8","updated":"2020-09-22 10:03:04.000000000","message":"yes, call collect_lldp_data can do things right for now too. But thinking about between generic manager and cna manager there has a \"cna2\" manager which need to disable another cna2-inner-lldp-service. Then things is broken again.","commit_id":"9f52626e18a5058ced3a0c31602a29ffa941126a"},{"author":{"_account_id":29702,"name":"QianBiao Ng","email":"iampurse@vip.qq.com","username":"QianBiao.NG"},"change_message_id":"ae99d2d7ef4e88e35856724aeac44a37d74845d3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # will be handled by GenericHardwareManager"},{"line_number":102,"context_line":"        message \u003d (\"Re-dispatch collect_lldp_data intent to hardware managers \""},{"line_number":103,"context_line":"                   \"chain after cna card lldp agent is disabled.\")"},{"line_number":104,"context_line":"        raise errors.IncompatibleHardwareMethodError(message)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3f4d6fc4","line":104,"range":{"start_line":104,"start_character":21,"end_line":104,"end_character":52},"in_reply_to":"9f560f44_7f7367b5","updated":"2020-09-16 23:43:13.000000000","message":"I have a long talk with dtantsur at this too. Basiclly, it\u0027s how the mechanism designed. Think about if between generic manager and cna manager has a new manager which would like to do something when collect_lldp_data too, call it directly will break this mechanism.","commit_id":"9f52626e18a5058ced3a0c31602a29ffa941126a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2998a5272acafa0f7ec8be2829742376a7b5b88c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # will be handled by GenericHardwareManager"},{"line_number":102,"context_line":"        message \u003d (\"Re-dispatch collect_lldp_data intent to hardware managers \""},{"line_number":103,"context_line":"                   \"chain after cna card lldp agent is disabled.\")"},{"line_number":104,"context_line":"        raise errors.IncompatibleHardwareMethodError(message)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7f7367b5","line":104,"range":{"start_line":104,"start_character":21,"end_line":104,"end_character":52},"in_reply_to":"9f560f44_b8519adc","updated":"2020-09-16 22:54:22.000000000","message":"At some point I kind of wonder why we just don\u0027t call the method then. :\\","commit_id":"9f52626e18a5058ced3a0c31602a29ffa941126a"},{"author":{"_account_id":29702,"name":"QianBiao Ng","email":"iampurse@vip.qq.com","username":"QianBiao.NG"},"change_message_id":"ae99d2d7ef4e88e35856724aeac44a37d74845d3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # will be handled by GenericHardwareManager"},{"line_number":102,"context_line":"        message \u003d (\"Re-dispatch collect_lldp_data intent to hardware managers \""},{"line_number":103,"context_line":"                   \"chain after cna card lldp agent is disabled.\")"},{"line_number":104,"context_line":"        raise errors.IncompatibleHardwareMethodError(message)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5f62e33e","line":104,"range":{"start_line":104,"start_character":21,"end_line":104,"end_character":52},"in_reply_to":"9f560f44_b8519adc","updated":"2020-09-16 23:43:13.000000000","message":"Yes, we should log it. And i am concern about raise \"IncompatibleHardwareMethodError\" here too, strictly speaking, it\u0027s not \"incompatible\" here, it\u0027s some kind of not finished, should re-dispatch to manage chain. I am thinking about adding a Boolean return value for those collect_hardware_info functions, True means collected otherwise means should continue and re-dispatch. \n\nwhat do u think about this, @dtantsur.","commit_id":"9f52626e18a5058ced3a0c31602a29ffa941126a"},{"author":{"_account_id":29702,"name":"QianBiao Ng","email":"iampurse@vip.qq.com","username":"QianBiao.NG"},"change_message_id":"719fa64422e2f54aeea724599b673a2fd4b8a8c3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # will be handled by GenericHardwareManager"},{"line_number":102,"context_line":"        message \u003d (\"Re-dispatch collect_lldp_data intent to hardware managers \""},{"line_number":103,"context_line":"                   \"chain after cna card lldp agent is disabled.\")"},{"line_number":104,"context_line":"        raise errors.IncompatibleHardwareMethodError(message)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_14716a78","line":104,"range":{"start_line":104,"start_character":21,"end_line":104,"end_character":52},"in_reply_to":"9f560f44_b914f74e","updated":"2020-09-17 09:05:39.000000000","message":"I am agree with Dmitry. The first idea come to my head is adding something like \"ReDispatchRequiredError\" exception too. And the return value has been used. So, return boolean value is not possible here.","commit_id":"9f52626e18a5058ced3a0c31602a29ffa941126a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0bf13f736f82b7541a02552d275d047bfd6a51be","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":"from oslo_log import log"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic_python_agent import errors"},{"line_number":22,"context_line":"from ironic_python_agent import hardware"},{"line_number":23,"context_line":"from ironic_python_agent import utils"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_45b8ff73","line":21,"updated":"2020-09-22 15:22:01.000000000","message":"pep8: F401 \u0027ironic_python_agent.errors\u0027 imported but unused","commit_id":"4914d1e36ca40fb0f8914e68c01a324e2e4a5998"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c052ee0307a376142a374297bd3cfc2d7e496227","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            # card, needs to be turned off."},{"line_number":83,"context_line":"            if CONF.collect_lldp:"},{"line_number":84,"context_line":"                LOG.info(\u0027Disable CNA network card embedded lldp agent now\u0027)"},{"line_number":85,"context_line":"                _disable_embedded_lldp_agent_in_cna_card()"},{"line_number":86,"context_line":"            return hardware.HardwareSupport.MAINLINE"},{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            LOG.debug(\u0027No Intel CNA network card found\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_a2a11198","line":85,"updated":"2020-09-22 14:35:59.000000000","message":"Great, this is what I was suggesting. It\u0027s a little bit of stretch but for hardware managers, the idea is you have to do any hardware initialization here -- e.g. loading drivers -- in order to know if you have the hardware inside you\u0027re trying to support.\n\nDisabling the LLDP agent is *kinda* an initialization activity, so I think it fits.\n\n+1","commit_id":"4914d1e36ca40fb0f8914e68c01a324e2e4a5998"}],"ironic_python_agent/tests/unit/hardware_managers/test_cna.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6c8dc9afa481a5fc092797d2d61626096afae580","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                \"chain after cna card lldp agent is disabled.\")"},{"line_number":147,"context_line":"            self.assertRaisesRegex("},{"line_number":148,"context_line":"                errors.IncompatibleHardwareMethodError, message,"},{"line_number":149,"context_line":"                self.hardware.collect_lldp_data, iface_names)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7407181f","line":149,"updated":"2020-09-16 14:04:47.000000000","message":"Since the raise of the exception is a bit of a style and mechanics change, I\u0027d highly prefer we add a test to somehow ensure that when invoked and the exception is raise that the generic hardware manager is dispatched to do lldp data collection. If this is already tested, then disregard my comment and just let me know to +2 this change.","commit_id":"9f52626e18a5058ced3a0c31602a29ffa941126a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0bf13f736f82b7541a02552d275d047bfd6a51be","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_concurrency import processutils"},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic_python_agent import errors"},{"line_number":22,"context_line":"from ironic_python_agent import hardware"},{"line_number":23,"context_line":"from ironic_python_agent.hardware_managers import cna"},{"line_number":24,"context_line":"from ironic_python_agent.tests.unit import base"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_65b3839b","line":21,"updated":"2020-09-22 15:22:01.000000000","message":"pep8: F401 \u0027ironic_python_agent.errors\u0027 imported but unused","commit_id":"4914d1e36ca40fb0f8914e68c01a324e2e4a5998"}],"releasenotes/notes/fix-mlnx-hardware-mgr-never-run-72072580be4d6e7a.yaml":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"bf9d2a16e1955122cab78729923d20557fa7208f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"  Currently, IntelCnaHardwareManager inherits GenericHardwareManager"},{"line_number":5,"context_line":"  which makes it a new \"GenericHardwareManager\" with \"MAINLINE\" priority."},{"line_number":6,"context_line":"  This causes all other hardware-managers with lower priority than"},{"line_number":7,"context_line":"  \"MAINLINE\" never be used. For example, on a server has both Mellanox"},{"line_number":8,"context_line":"  InfiniBand interface and Intel CNA card, MellanoxDeviceHardwareManager will"},{"line_number":9,"context_line":"  not be used to handle mellanox InfiniBand interfaces. To fix this, let"},{"line_number":10,"context_line":"  IntelCnaHardwareManager inherit basic HardwareManager. And in this patch,"},{"line_number":11,"context_line":"  the \"_disable_embedded_lldp_agent_in_cna_card\" function is moved to"},{"line_number":12,"context_line":"  IntelCnaHardwareManager\u0027s evaluate_hardware_support when \"collect_lldp\" is"},{"line_number":13,"context_line":"  enabled, the collect_lldp_data intent will be dispatched throught the"},{"line_number":14,"context_line":"  hardware manager chain and finially handled by GenericHardwareManage."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_fdf9dbc4","line":14,"range":{"start_line":4,"start_character":0,"end_line":14,"end_character":71},"updated":"2020-09-23 07:30:17.000000000","message":"Apologies for being picky, but this is a long reno :)\n\nHow about sth shorter like:\n\n\"Fixes an issue with the IntelCnaHardwareManager which prevented hardware managers with lower priority to be executed and therefore may blocked the initialization of hardware these managers are supposed to take care of.\"","commit_id":"de465428a24934d22ef471e6a3385edbec47f663"},{"author":{"_account_id":29702,"name":"QianBiao Ng","email":"iampurse@vip.qq.com","username":"QianBiao.NG"},"change_message_id":"28b3f9cf3b5be2f3838aab7cafe6a41d92b813e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"  Currently, IntelCnaHardwareManager inherits GenericHardwareManager"},{"line_number":5,"context_line":"  which makes it a new \"GenericHardwareManager\" with \"MAINLINE\" priority."},{"line_number":6,"context_line":"  This causes all other hardware-managers with lower priority than"},{"line_number":7,"context_line":"  \"MAINLINE\" never be used. For example, on a server has both Mellanox"},{"line_number":8,"context_line":"  InfiniBand interface and Intel CNA card, MellanoxDeviceHardwareManager will"},{"line_number":9,"context_line":"  not be used to handle mellanox InfiniBand interfaces. To fix this, let"},{"line_number":10,"context_line":"  IntelCnaHardwareManager inherit basic HardwareManager. And in this patch,"},{"line_number":11,"context_line":"  the \"_disable_embedded_lldp_agent_in_cna_card\" function is moved to"},{"line_number":12,"context_line":"  IntelCnaHardwareManager\u0027s evaluate_hardware_support when \"collect_lldp\" is"},{"line_number":13,"context_line":"  enabled, the collect_lldp_data intent will be dispatched throught the"},{"line_number":14,"context_line":"  hardware manager chain and finially handled by GenericHardwareManage."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_5d9f2764","line":14,"range":{"start_line":4,"start_character":0,"end_line":14,"end_character":71},"in_reply_to":"9f560f44_fdf9dbc4","updated":"2020-09-23 07:34:59.000000000","message":"You are my writing teacher :), thanks.","commit_id":"de465428a24934d22ef471e6a3385edbec47f663"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"22e4367457195e1c39757b1f23f00c7abf6c2c2c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"  Fixes an issue with the IntelCnaHardwareManager which prevented hardware"},{"line_number":5,"context_line":"  managers with lower priority to be executed and therefore may blocked the"},{"line_number":6,"context_line":"  initialization and collection of hardware these managers are supposed to take"},{"line_number":7,"context_line":"  care of."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_ef70000c","line":4,"updated":"2020-09-23 10:15:44.000000000","message":"This fails the release notes build. I think the line should start at the same level as |\n\n fixes:\n   - |\n     Fixes ....","commit_id":"782a366c80242bf652fe3aec5ad461e3cd562f05"}]}