)]}'
{"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"71860c4e64ab9a3d0359d4cd24bb585ecb9dcada","unresolved":false,"context_lines":[{"line_number":666,"context_line":"            # There is no real point in trying to fallback with"},{"line_number":667,"context_line":"            # grub1 since the option nevere existed. At worst here"},{"line_number":668,"context_line":"            # we try again, and then fail as we would have."},{"line_number":669,"context_line":"            fallback_grub_cmd \u003d grub_cmd"},{"line_number":670,"context_line":"        # Generate the grub configuration file"},{"line_number":671,"context_line":"        try:"},{"line_number":672,"context_line":"            utils.execute(\u0027chroot %(path)s /bin/sh -c \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_1dd38103","line":669,"updated":"2020-09-29 14:23:55.000000000","message":"nit: I\u0027d rather set this to None and check for None on line 679","commit_id":"bcb9cab7b1e337235e9fb449cee164193069c132"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"71860c4e64ab9a3d0359d4cd24bb585ecb9dcada","unresolved":false,"context_lines":[{"line_number":674,"context_line":"                          \u0027/boot/%(bin)s/grub.cfg\"\u0027 %"},{"line_number":675,"context_line":"                          {\u0027path\u0027: path, \u0027bin\u0027: binary_name,"},{"line_number":676,"context_line":"                           \u0027grub_cmd\u0027: grub_cmd}, shell\u003dTrue,"},{"line_number":677,"context_line":"                          env_variables\u003d{\u0027PATH\u0027: path_variable})"},{"line_number":678,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":679,"context_line":"            if \u0027Unrecognized option\u0027 in str(e):"},{"line_number":680,"context_line":"                utils.execute(\u0027chroot %(path)s /bin/sh -c \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_7d01dd6d","line":677,"updated":"2020-09-29 14:23:55.000000000","message":"nit: use_standard_locale\u003dTrue. I hope nobody runs IPA in a non-English locale, but who knows..","commit_id":"bcb9cab7b1e337235e9fb449cee164193069c132"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9e912bbd5491956c72a30c8d6ce0a52cbf059507","unresolved":false,"context_lines":[{"line_number":660,"context_line":"                           contents))"},{"line_number":661,"context_line":"        if binary_name \u003d\u003d \u0027grub2\u0027:"},{"line_number":662,"context_line":"            grub_cmd \u003d \u0027%s-mkconfig --no-grubenv-update\u0027 % binary_name"},{"line_number":663,"context_line":"            fallback_grub_cmd \u003d \u0027%s-mkconfig\u0027 % binary_name"},{"line_number":664,"context_line":"        else:"},{"line_number":665,"context_line":"            grub_cmd \u003d \u0027%s-mkconfig\u0027 % binary_name"},{"line_number":666,"context_line":"            # There is no real point in trying to fallback with"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_48299d35","line":663,"updated":"2020-10-01 01:56:23.000000000","message":"Another approach to detecting whether this grub2-mkconfig supports --no-grubenv-update would be to run \u0027grub2-mkconfig --help\u0027 and check for --no-grubenv-update in the output.\n\nI don\u0027t have a particular objection to this approach though","commit_id":"fefd87e91bde1f1974c2ea2c9415c0b5cc0e7240"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6cb338fc81782b523fc9128355450c165ebff685","unresolved":false,"context_lines":[{"line_number":660,"context_line":"                           contents))"},{"line_number":661,"context_line":"        if binary_name \u003d\u003d \u0027grub2\u0027:"},{"line_number":662,"context_line":"            grub_cmd \u003d \u0027%s-mkconfig --no-grubenv-update\u0027 % binary_name"},{"line_number":663,"context_line":"            fallback_grub_cmd \u003d \u0027%s-mkconfig\u0027 % binary_name"},{"line_number":664,"context_line":"        else:"},{"line_number":665,"context_line":"            grub_cmd \u003d \u0027%s-mkconfig\u0027 % binary_name"},{"line_number":666,"context_line":"            # There is no real point in trying to fallback with"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_f4130c58","line":663,"in_reply_to":"9f560f44_48299d35","updated":"2020-10-02 20:03:43.000000000","message":"I think I pulled the latest help/man page and it was undocumented, but there are so many different versions out there :\\","commit_id":"fefd87e91bde1f1974c2ea2c9415c0b5cc0e7240"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f4bfbd4b0898d3a07cb3ebac21051e4dd5494755","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        else:"},{"line_number":665,"context_line":"            grub_cmd \u003d \u0027%s-mkconfig\u0027 % binary_name"},{"line_number":666,"context_line":"            # There is no real point in trying to fallback with"},{"line_number":667,"context_line":"            # grub1 since the option nevere existed. At worst here"},{"line_number":668,"context_line":"            # we try again, and then fail as we would have."},{"line_number":669,"context_line":"            fallback_grub_cmd \u003d None"},{"line_number":670,"context_line":"        # Generate the grub configuration file"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_092e4caa","line":667,"range":{"start_line":667,"start_character":37,"end_line":667,"end_character":43},"updated":"2020-10-06 09:40:27.000000000","message":"nit: never","commit_id":"fefd87e91bde1f1974c2ea2c9415c0b5cc0e7240"}],"releasenotes/notes/fixes-centos-fedora-grub2-mkconfig-hang-fe22cde231994044.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"71860c4e64ab9a3d0359d4cd24bb585ecb9dcada","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    take an extended period of time to evaluate additional unrelated"},{"line_number":9,"context_line":"    devices for dual-boot scenarios. Since operators are not dual"},{"line_number":10,"context_line":"    booting thier machines enrolled in ironic, it seems like an"},{"line_number":11,"context_line":"    un-necessary scan and has thus been disabled."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_5d069987","line":11,"updated":"2020-09-29 14:23:55.000000000","message":"At some point we should start documenting our assumptions.. This is a reasonable one though.","commit_id":"bcb9cab7b1e337235e9fb449cee164193069c132"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f4bfbd4b0898d3a07cb3ebac21051e4dd5494755","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    because ``grub2-mkconfig`` triggers ``os-prober`` which can"},{"line_number":8,"context_line":"    take an extended period of time to evaluate additional unrelated"},{"line_number":9,"context_line":"    devices for dual-boot scenarios. Since operators are not dual"},{"line_number":10,"context_line":"    booting thier machines enrolled in ironic, it seems like an"},{"line_number":11,"context_line":"    un-necessary scan and has thus been disabled."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_8921bcb8","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":17},"updated":"2020-10-06 09:40:27.000000000","message":"nit: their","commit_id":"fefd87e91bde1f1974c2ea2c9415c0b5cc0e7240"}],"zuul.d/ironic-python-agent-jobs.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c2c04d05e1e77190f089ebef861e3f69fdb8b71b","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        IRONIC_BUILD_DEPLOY_RAMDISK: True"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"# This job will superceed the above centos7 metalsmith integration job"},{"line_number":158,"context_line":"- job:"},{"line_number":159,"context_line":"    name: metalsmith-integration-ipa-src-uefi"},{"line_number":160,"context_line":"    parent: metalsmith-integration-glance-localboot-centos8"},{"line_number":161,"context_line":"    required-projects:"},{"line_number":162,"context_line":"      - openstack/ironic-python-agent"},{"line_number":163,"context_line":"      - openstack/ironic-python-agent-builder"},{"line_number":164,"context_line":"      - openstack/ironic-lib"},{"line_number":165,"context_line":"    vars:"},{"line_number":166,"context_line":"      devstack_localrc:"},{"line_number":167,"context_line":"        # Don\u0027t waste time on cleaning, it\u0027s checked everywhere else"},{"line_number":168,"context_line":"        IRONIC_AUTOMATED_CLEAN_ENABLED: False"},{"line_number":169,"context_line":"        IRONIC_BUILD_DEPLOY_RAMDISK: True"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# used by ironic-python-agent-builder"},{"line_number":172,"context_line":"- job:"},{"line_number":173,"context_line":"    name: ipa-tempest-bios-ipmi-direct-tinyipa-src"},{"line_number":174,"context_line":"    parent: ipa-tempest-bios-ipmi-direct-src"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_696eb5c8","line":171,"range":{"start_line":158,"start_character":2,"end_line":171,"end_character":0},"updated":"2020-10-08 20:50:11.000000000","message":"Job metalsmith-integration-glance-localboot-centos8 not defined","commit_id":"3da5ab5fa17008024eefe6fe22a90404ddb05985"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"942edda97ff22b56a6812a2ec6096198dd1704bf","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        IRONIC_BUILD_DEPLOY_RAMDISK: True"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"# This job will superceed the above centos7 metalsmith integration job"},{"line_number":158,"context_line":"- job:"},{"line_number":159,"context_line":"    name: metalsmith-integration-ipa-src-uefi"},{"line_number":160,"context_line":"    parent: metalsmith-integration-glance-localboot-centos8"},{"line_number":161,"context_line":"    required-projects:"},{"line_number":162,"context_line":"      - openstack/ironic-python-agent"},{"line_number":163,"context_line":"      - openstack/ironic-python-agent-builder"},{"line_number":164,"context_line":"      - openstack/ironic-lib"},{"line_number":165,"context_line":"    vars:"},{"line_number":166,"context_line":"      devstack_localrc:"},{"line_number":167,"context_line":"        # Don\u0027t waste time on cleaning, it\u0027s checked everywhere else"},{"line_number":168,"context_line":"        IRONIC_AUTOMATED_CLEAN_ENABLED: False"},{"line_number":169,"context_line":"        IRONIC_BUILD_DEPLOY_RAMDISK: True"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# used by ironic-python-agent-builder"},{"line_number":172,"context_line":"- job:"},{"line_number":173,"context_line":"    name: ipa-tempest-bios-ipmi-direct-tinyipa-src"},{"line_number":174,"context_line":"    parent: ipa-tempest-bios-ipmi-direct-src"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_095d7915","line":171,"range":{"start_line":158,"start_character":2,"end_line":171,"end_character":0},"updated":"2020-10-08 20:50:35.000000000","message":"Job metalsmith-integration-glance-localboot-centos8 not defined","commit_id":"7ad10ee3764c5133e080d2336ab1a4b51d55a579"}]}