)]}'
{"ironic_python_agent/config.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"06e30c6ef876e15589dadda3743783b0b0a636c1","unresolved":false,"context_lines":[{"line_number":286,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-ironic-api-version\u0027, None),"},{"line_number":287,"context_line":"               help\u003d\u0027Ironic API version in format \"x.x\". If not set, version \u0027"},{"line_number":288,"context_line":"                    \u0027will be auto-detected. This is not a recommended \u0027"},{"line_number":289,"context_line":"                    \u0027configuration.\u0027)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"]"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_7288f11e","line":289,"updated":"2020-10-28 16:44:36.000000000","message":"From the text is not clear what \"This\" is referring to: setting the variable or auto-detection. Maybe \"It is recommended to leave it unset\"?","commit_id":"80575566b1f5d9d70e203c4a30753f3dd16544db"}],"ironic_python_agent/ironic_api_client.py":[{"author":{"_account_id":32592,"name":"Zachary Buhman","email":"zachary.buhman@verizonmedia.com"},"change_message_id":"d0f84f98fdb2265b77694d280b3e8cd6e94162b5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                              \"the ironic_api_version. Will fall back to \""},{"line_number":102,"context_line":"                              \"auto-detection\")"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if not self._ironic_api_version:"},{"line_number":105,"context_line":"            try:"},{"line_number":106,"context_line":"                response \u003d self._request(\u0027GET\u0027, \u0027/\u0027)"},{"line_number":107,"context_line":"                data \u003d jsonutils.loads(response.content)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_a98e7e2b","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":8},"updated":"2020-10-23 15:37:27.000000000","message":"The if statement on line 104 is redundant due line 91. I think it would be a minor readability improvement if line 104 were removed and the following block reindented.","commit_id":"1d1d4bb60d517c365dd28133e025f2d58dfac576"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"423a33c8211ad7dc52784723a3f5f396f8c647a4","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                              \"the ironic_api_version. Will fall back to \""},{"line_number":102,"context_line":"                              \"auto-detection\")"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if not self._ironic_api_version:"},{"line_number":105,"context_line":"            try:"},{"line_number":106,"context_line":"                response \u003d self._request(\u0027GET\u0027, \u0027/\u0027)"},{"line_number":107,"context_line":"                data \u003d jsonutils.loads(response.content)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_e99d165a","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":8},"in_reply_to":"3f65232a_a98e7e2b","updated":"2020-10-23 15:38:26.000000000","message":"fixed, ty","commit_id":"1d1d4bb60d517c365dd28133e025f2d58dfac576"}],"releasenotes/notes/manually-configure-ironic-api-version-517afd0a423036ad.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"06e30c6ef876e15589dadda3743783b0b0a636c1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deployers in highly-secure environments can now manually set Ironic API"},{"line_number":5,"context_line":"    version instead of relying on unauthentication autodetection via"},{"line_number":6,"context_line":"    ipa-ironic-api-version on the kernel command line. This is not a"},{"line_number":7,"context_line":"    reccomended configuration."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f621f24_d27c6522","line":6,"updated":"2020-10-28 16:44:36.000000000","message":"nit: ``ipa-ironic-api-version``","commit_id":"80575566b1f5d9d70e203c4a30753f3dd16544db"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"06e30c6ef876e15589dadda3743783b0b0a636c1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Deployers in highly-secure environments can now manually set Ironic API"},{"line_number":5,"context_line":"    version instead of relying on unauthentication autodetection via"},{"line_number":6,"context_line":"    ipa-ironic-api-version on the kernel command line. This is not a"},{"line_number":7,"context_line":"    reccomended configuration."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f621f24_b279e930","line":7,"updated":"2020-10-28 16:44:36.000000000","message":"nit: recommended","commit_id":"80575566b1f5d9d70e203c4a30753f3dd16544db"}]}