)]}'
{"ironic_python_agent/config.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122fdb4093ad87f6e5ea4f9019185329489634ab","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                    \u0027be useful if the environment requires API version \u0027"},{"line_number":293,"context_line":"                    \u0027auto-detection to be disabled or blocked.\u0027),"},{"line_number":294,"context_line":"    cfg.StrOpt(\u0027inspection_vlan_interfaces\u0027,"},{"line_number":295,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-vlan-interfaces\u0027, \u0027\u0027),"},{"line_number":296,"context_line":"               help\u003d\u0027Comma-separated list of vlan interfaces to enable, \u0027"},{"line_number":297,"context_line":"                    \u0027in the format \"interface.vlan\".  If only an \u0027"},{"line_number":298,"context_line":"                    \u0027interface is provided, then IPA should attempt to \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_4dbdc1d6","line":295,"updated":"2020-11-10 10:56:44.000000000","message":"should be ipa-inspection-vlan-interfaces for consistency, but see further comments","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"38ba91d9e4247aa6810dcc74f43245a650846ff4","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                    \u0027be useful if the environment requires API version \u0027"},{"line_number":293,"context_line":"                    \u0027auto-detection to be disabled or blocked.\u0027),"},{"line_number":294,"context_line":"    cfg.StrOpt(\u0027inspection_vlan_interfaces\u0027,"},{"line_number":295,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-vlan-interfaces\u0027, \u0027\u0027),"},{"line_number":296,"context_line":"               help\u003d\u0027Comma-separated list of vlan interfaces to enable, \u0027"},{"line_number":297,"context_line":"                    \u0027in the format \"interface.vlan\".  If only an \u0027"},{"line_number":298,"context_line":"                    \u0027interface is provided, then IPA should attempt to \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_dc417d3b","line":295,"in_reply_to":"1f621f24_4dbdc1d6","updated":"2020-11-10 15:19:19.000000000","message":"Done","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122fdb4093ad87f6e5ea4f9019185329489634ab","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                    \u0027auto-detection to be disabled or blocked.\u0027),"},{"line_number":294,"context_line":"    cfg.StrOpt(\u0027inspection_vlan_interfaces\u0027,"},{"line_number":295,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-vlan-interfaces\u0027, \u0027\u0027),"},{"line_number":296,"context_line":"               help\u003d\u0027Comma-separated list of vlan interfaces to enable, \u0027"},{"line_number":297,"context_line":"                    \u0027in the format \"interface.vlan\".  If only an \u0027"},{"line_number":298,"context_line":"                    \u0027interface is provided, then IPA should attempt to \u0027"},{"line_number":299,"context_line":"                    \u0027bring up all vlans on that interface detected \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_2dc2055a","line":296,"updated":"2020-11-10 10:56:44.000000000","message":"nit: keep VLAN capitalized here","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"38ba91d9e4247aa6810dcc74f43245a650846ff4","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                    \u0027auto-detection to be disabled or blocked.\u0027),"},{"line_number":294,"context_line":"    cfg.StrOpt(\u0027inspection_vlan_interfaces\u0027,"},{"line_number":295,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-vlan-interfaces\u0027, \u0027\u0027),"},{"line_number":296,"context_line":"               help\u003d\u0027Comma-separated list of vlan interfaces to enable, \u0027"},{"line_number":297,"context_line":"                    \u0027in the format \"interface.vlan\".  If only an \u0027"},{"line_number":298,"context_line":"                    \u0027interface is provided, then IPA should attempt to \u0027"},{"line_number":299,"context_line":"                    \u0027bring up all vlans on that interface detected \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_1c48155a","line":296,"in_reply_to":"1f621f24_2dc2055a","updated":"2020-11-10 15:19:19.000000000","message":"Done","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"40efa05d24ad1cb6f60c677cccdb331cedfdb5ca","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        try:"},{"line_number":1130,"context_line":"            LOG.info(\u0027Adding vlan interface %s\u0027, vlan_name)"},{"line_number":1131,"context_line":"            # Add the interface"},{"line_number":1132,"context_line":"            utils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027add\u0027, \u0027link\u0027, interface, \u0027name\u0027,"},{"line_number":1133,"context_line":"                          vlan_name, \u0027type\u0027, \u0027vlan\u0027, \u0027id\u0027, vlan)"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"            # Bring up interface"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_0f567d5d","line":1132,"updated":"2020-11-02 16:34:39.000000000","message":"we probably need a check here to see if the link already exists, as we may go over this code multiple times.\n\u003e Command: ip link add link enp1s0 name enp1s0.100 type vlan id 100","commit_id":"767da2d2a30e2f1bb06ee1291c492f49124ec9af"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"d952bc59d08c18fa2890c82e0d83875b8bd1d61a","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        try:"},{"line_number":1130,"context_line":"            LOG.info(\u0027Adding vlan interface %s\u0027, vlan_name)"},{"line_number":1131,"context_line":"            # Add the interface"},{"line_number":1132,"context_line":"            utils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027add\u0027, \u0027link\u0027, interface, \u0027name\u0027,"},{"line_number":1133,"context_line":"                          vlan_name, \u0027type\u0027, \u0027vlan\u0027, \u0027id\u0027, vlan)"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"            # Bring up interface"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_2fe09996","line":1132,"in_reply_to":"1f621f24_0f567d5d","updated":"2020-11-02 16:36:06.000000000","message":"pasted the wrong line\n\n\u003e Stderr: \u0027RTNETLINK answers: File exists\\n\u0027: oslo_concurrency.processutils.ProcessExecutionError: Unexpected error while running command.","commit_id":"767da2d2a30e2f1bb06ee1291c492f49124ec9af"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"4dbaa56cde4aab4ad57ce2d2137c2c757d2ffe0b","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        try:"},{"line_number":1130,"context_line":"            LOG.info(\u0027Adding vlan interface %s\u0027, vlan_name)"},{"line_number":1131,"context_line":"            # Add the interface"},{"line_number":1132,"context_line":"            utils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027add\u0027, \u0027link\u0027, interface, \u0027name\u0027,"},{"line_number":1133,"context_line":"                          vlan_name, \u0027type\u0027, \u0027vlan\u0027, \u0027id\u0027, vlan)"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"            # Bring up interface"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_ea3b2fc5","line":1132,"in_reply_to":"1f621f24_2fe09996","updated":"2020-11-04 02:19:18.000000000","message":"I thought the check at line 1125 would catch this, since all interfaces are included in the interfaces_list.  Not sure why it would return the \"File exists\" error, but I will add a check.","commit_id":"767da2d2a30e2f1bb06ee1291c492f49124ec9af"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122fdb4093ad87f6e5ea4f9019185329489634ab","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"        global WARN_BIOSDEVNAME_NOT_FOUND"},{"line_number":1067,"context_line":""},{"line_number":1068,"context_line":"        if self._is_vlan(interface_name):"},{"line_number":1069,"context_line":"            LOG.debug(\u0027Interface is vlan, biosdevname not called\u0027)"},{"line_number":1070,"context_line":"            return"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_8db3590a","line":1069,"updated":"2020-11-10 10:56:44.000000000","message":"nit: log the interface name","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"38ba91d9e4247aa6810dcc74f43245a650846ff4","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"        global WARN_BIOSDEVNAME_NOT_FOUND"},{"line_number":1067,"context_line":""},{"line_number":1068,"context_line":"        if self._is_vlan(interface_name):"},{"line_number":1069,"context_line":"            LOG.debug(\u0027Interface is vlan, biosdevname not called\u0027)"},{"line_number":1070,"context_line":"            return"},{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_fc443949","line":1069,"in_reply_to":"1f621f24_8db3590a","updated":"2020-11-10 15:19:19.000000000","message":"Done","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122fdb4093ad87f6e5ea4f9019185329489634ab","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"        # A vlan interface does not have /device, check naming convention"},{"line_number":1096,"context_line":"        # used when adding vlan interface"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"        return \u0027.\u0027 in interface_name"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"    def list_network_interfaces(self):"},{"line_number":1101,"context_line":"        network_interfaces_list \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_6db87de4","line":1098,"updated":"2020-11-10 10:56:44.000000000","message":"nit: maybe check that the 2nd part if a number?","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"38ba91d9e4247aa6810dcc74f43245a650846ff4","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"        # A vlan interface does not have /device, check naming convention"},{"line_number":1096,"context_line":"        # used when adding vlan interface"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"        return \u0027.\u0027 in interface_name"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"    def list_network_interfaces(self):"},{"line_number":1101,"context_line":"        network_interfaces_list \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_3c7cf181","line":1098,"in_reply_to":"1f621f24_6db87de4","updated":"2020-11-10 15:19:19.000000000","message":"Done","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122fdb4093ad87f6e5ea4f9019185329489634ab","unresolved":false,"context_lines":[{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"        # If configured, bring up vlan interfaces. If the actual vlans aren\u0027t"},{"line_number":1117,"context_line":"        # defined they are derived from LLDP data"},{"line_number":1118,"context_line":"        if CONF.inspection_vlan_interfaces:"},{"line_number":1119,"context_line":"            vlan_iface_names \u003d self._bring_up_vlan_interfaces("},{"line_number":1120,"context_line":"                network_interfaces_list)"},{"line_number":1121,"context_line":"            for vlan_iface_name in vlan_iface_names:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_cdd0b122","line":1118,"updated":"2020-11-10 10:56:44.000000000","message":"This function is not inspection-specific, so we should probably rename the option OR move the implementation to a collector.","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"38ba91d9e4247aa6810dcc74f43245a650846ff4","unresolved":false,"context_lines":[{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"        # If configured, bring up vlan interfaces. If the actual vlans aren\u0027t"},{"line_number":1117,"context_line":"        # defined they are derived from LLDP data"},{"line_number":1118,"context_line":"        if CONF.inspection_vlan_interfaces:"},{"line_number":1119,"context_line":"            vlan_iface_names \u003d self._bring_up_vlan_interfaces("},{"line_number":1120,"context_line":"                network_interfaces_list)"},{"line_number":1121,"context_line":"            for vlan_iface_name in vlan_iface_names:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_9c6d45ce","line":1118,"in_reply_to":"1f621f24_cdd0b122","updated":"2020-11-10 15:19:19.000000000","message":"Done","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122fdb4093ad87f6e5ea4f9019185329489634ab","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        return [x.strip() for x in CONF.inspection_vlan_interfaces.split(\u0027,\u0027)"},{"line_number":1130,"context_line":"                if x.strip()]"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"    def _add_vlan_interface(self, interface, vlan, interfaces_list):"},{"line_number":1133,"context_line":""},{"line_number":1134,"context_line":"        vlan_name \u003d interface + \u0027.\u0027 + vlan"},{"line_number":1135,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_adcd7586","line":1132,"updated":"2020-11-10 10:56:44.000000000","message":"nit: move this to netutils.py to keep similar code in the same place","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"38ba91d9e4247aa6810dcc74f43245a650846ff4","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        return [x.strip() for x in CONF.inspection_vlan_interfaces.split(\u0027,\u0027)"},{"line_number":1130,"context_line":"                if x.strip()]"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"    def _add_vlan_interface(self, interface, vlan, interfaces_list):"},{"line_number":1133,"context_line":""},{"line_number":1134,"context_line":"        vlan_name \u003d interface + \u0027.\u0027 + vlan"},{"line_number":1135,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_7c72e9ae","line":1132,"in_reply_to":"1f621f24_adcd7586","updated":"2020-11-10 15:19:19.000000000","message":"Done","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122fdb4093ad87f6e5ea4f9019185329489634ab","unresolved":false,"context_lines":[{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"        return vlan_name"},{"line_number":1157,"context_line":""},{"line_number":1158,"context_line":"    def _add_vlans_from_lldp(self, lldp, interface, interfaces_list):"},{"line_number":1159,"context_line":"        interfaces \u003d []"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"        # Get the lldp packets received on this interface"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_0dc74966","line":1158,"updated":"2020-11-10 10:56:44.000000000","message":"ditto (especially since there already is LLDP code in netutils)","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"38ba91d9e4247aa6810dcc74f43245a650846ff4","unresolved":false,"context_lines":[{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"        return vlan_name"},{"line_number":1157,"context_line":""},{"line_number":1158,"context_line":"    def _add_vlans_from_lldp(self, lldp, interface, interfaces_list):"},{"line_number":1159,"context_line":"        interfaces \u003d []"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"        # Get the lldp packets received on this interface"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_dc6a1db1","line":1158,"in_reply_to":"1f621f24_0dc74966","updated":"2020-11-10 15:19:19.000000000","message":"Done","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122fdb4093ad87f6e5ea4f9019185329489634ab","unresolved":false,"context_lines":[{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        return interfaces"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"    def _bring_up_vlan_interfaces(self, interfaces_list):"},{"line_number":1178,"context_line":"        interfaces \u003d []"},{"line_number":1179,"context_line":"        vlan_interfaces \u003d self._get_configured_vlans()"},{"line_number":1180,"context_line":"        for vlan_int in vlan_interfaces:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_edc3ed55","line":1177,"updated":"2020-11-10 10:56:44.000000000","message":"ditto","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"38ba91d9e4247aa6810dcc74f43245a650846ff4","unresolved":false,"context_lines":[{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        return interfaces"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"    def _bring_up_vlan_interfaces(self, interfaces_list):"},{"line_number":1178,"context_line":"        interfaces \u003d []"},{"line_number":1179,"context_line":"        vlan_interfaces \u003d self._get_configured_vlans()"},{"line_number":1180,"context_line":"        for vlan_int in vlan_interfaces:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_1c6135d4","line":1177,"in_reply_to":"1f621f24_edc3ed55","updated":"2020-11-10 15:19:19.000000000","message":"Done","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122fdb4093ad87f6e5ea4f9019185329489634ab","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"                    if name:"},{"line_number":1189,"context_line":"                        interfaces.append(name)"},{"line_number":1190,"context_line":"                else:"},{"line_number":1191,"context_line":"                    LOG.info(\u0027Provided vlan interface %s does not exist\u0027,"},{"line_number":1192,"context_line":"                             interface)"},{"line_number":1193,"context_line":"            elif CONF.collect_lldp:"},{"line_number":1194,"context_line":"                # Get the vlans from lldp info"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_4da2e1af","line":1191,"updated":"2020-11-10 10:56:44.000000000","message":"warning?","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"38ba91d9e4247aa6810dcc74f43245a650846ff4","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"                    if name:"},{"line_number":1189,"context_line":"                        interfaces.append(name)"},{"line_number":1190,"context_line":"                else:"},{"line_number":1191,"context_line":"                    LOG.info(\u0027Provided vlan interface %s does not exist\u0027,"},{"line_number":1192,"context_line":"                             interface)"},{"line_number":1193,"context_line":"            elif CONF.collect_lldp:"},{"line_number":1194,"context_line":"                # Get the vlans from lldp info"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_fc5d5915","line":1191,"in_reply_to":"1f621f24_4da2e1af","updated":"2020-11-10 15:19:19.000000000","message":"Done","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122fdb4093ad87f6e5ea4f9019185329489634ab","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"                            iface.lldp, iface.name, interfaces_list)"},{"line_number":1208,"context_line":"                        if names:"},{"line_number":1209,"context_line":"                            interfaces.extend(names)"},{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"        return interfaces"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"    def get_cpus(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_2da7a5bf","line":1210,"updated":"2020-11-10 10:56:44.000000000","message":"What if \u0027.\u0027 is not present and collect_lldp is False? at least log a warning maybe?","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"38ba91d9e4247aa6810dcc74f43245a650846ff4","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"                            iface.lldp, iface.name, interfaces_list)"},{"line_number":1208,"context_line":"                        if names:"},{"line_number":1209,"context_line":"                            interfaces.extend(names)"},{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"        return interfaces"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"    def get_cpus(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_5c9c4dbf","line":1210,"in_reply_to":"1f621f24_2da7a5bf","updated":"2020-11-10 15:19:19.000000000","message":"Done","commit_id":"319d5849834a3dcf7209f46cdad62b3d3694ee43"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a033e05761884a015307bcdad2e7dceed1363432","unresolved":false,"context_lines":[{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"        return network_interfaces_list"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"    def _get_configured_vlans(self):"},{"line_number":1124,"context_line":"        return [x.strip() for x in CONF.enable_vlan_interfaces.split(\u0027,\u0027)"},{"line_number":1125,"context_line":"                if x.strip()]"},{"line_number":1126,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fffc6b78_1d038644","line":1123,"updated":"2020-11-20 11:44:50.000000000","message":"Unused now?","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"b2d69f7837838239702f83c259cac64e512254d1","unresolved":false,"context_lines":[{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"        return network_interfaces_list"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"    def _get_configured_vlans(self):"},{"line_number":1124,"context_line":"        return [x.strip() for x in CONF.enable_vlan_interfaces.split(\u0027,\u0027)"},{"line_number":1125,"context_line":"                if x.strip()]"},{"line_number":1126,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fffc6b78_76ed8f24","line":1123,"in_reply_to":"fffc6b78_1d038644","updated":"2020-11-23 13:17:44.000000000","message":"Done","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"}],"ironic_python_agent/netutils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a033e05761884a015307bcdad2e7dceed1363432","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    return interfaces"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"def bring_up_vlan_interfaces(interfaces_list):"},{"line_number":326,"context_line":"    interfaces \u003d []"},{"line_number":327,"context_line":"    vlan_interfaces \u003d _get_configured_vlans()"},{"line_number":328,"context_line":"    for vlan_int in vlan_interfaces:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fffc6b78_fdffa231","line":325,"updated":"2020-11-20 11:44:50.000000000","message":"Please add a docstring","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"b2d69f7837838239702f83c259cac64e512254d1","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    return interfaces"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"def bring_up_vlan_interfaces(interfaces_list):"},{"line_number":326,"context_line":"    interfaces \u003d []"},{"line_number":327,"context_line":"    vlan_interfaces \u003d _get_configured_vlans()"},{"line_number":328,"context_line":"    for vlan_int in vlan_interfaces:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fffc6b78_3bf01291","line":325,"in_reply_to":"fffc6b78_fdffa231","updated":"2020-11-23 13:17:44.000000000","message":"Done","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a033e05761884a015307bcdad2e7dceed1363432","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                        iface.lldp, iface.name, interfaces_list)"},{"line_number":356,"context_line":"                    if names:"},{"line_number":357,"context_line":"                        interfaces.extend(names)"},{"line_number":358,"context_line":"        else:"},{"line_number":359,"context_line":"            LOG.warning(\u0027Attempting to add VLAN interfaces but specific \u0027"},{"line_number":360,"context_line":"                        \u0027interface not provided and LLDP not enabled\u0027)"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fffc6b78_5dfd0e39","line":358,"updated":"2020-11-20 11:44:50.000000000","message":"maybe explicitly fail on values other than \u0027all\u0027?","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"b2d69f7837838239702f83c259cac64e512254d1","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                        iface.lldp, iface.name, interfaces_list)"},{"line_number":356,"context_line":"                    if names:"},{"line_number":357,"context_line":"                        interfaces.extend(names)"},{"line_number":358,"context_line":"        else:"},{"line_number":359,"context_line":"            LOG.warning(\u0027Attempting to add VLAN interfaces but specific \u0027"},{"line_number":360,"context_line":"                        \u0027interface not provided and LLDP not enabled\u0027)"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fffc6b78_769f4fb4","line":358,"in_reply_to":"fffc6b78_5dfd0e39","updated":"2020-11-23 13:17:44.000000000","message":"Done","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"}],"ironic_python_agent/tests/unit/test_hardware.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5fbcf90e6ffe70346ae34afe18ae3b7876fe2147","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"            (0, b\u0027\u0027),"},{"line_number":1444,"context_line":"            (127, b\u0027\\x00\\x80\\xc2\\x03\\x00d\\x08vlan-100\u0027),"},{"line_number":1445,"context_line":"            (127, b\u0027\\x00\\x80\\xc2\\x03\\x00e\\x08vlan-101\u0027)],"},{"line_number":1446,"context_line":"        \u0027eth1\u0027: ["},{"line_number":1447,"context_line":"            (0, b\u0027\u0027),"},{"line_number":1448,"context_line":"            (127, b\u0027\\x00\\x80\\xc2\\x03\\x00f\\x08vlan-102\u0027),"},{"line_number":1449,"context_line":"            (127, b\u0027\\x00\\x80\\xc2\\x03\\x00g\\x08vlan-103\u0027)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_0af9344c","line":1446,"updated":"2020-11-04 04:35:46.000000000","message":"pep8: E122 continuation line missing indentation or outdented","commit_id":"41499fde8abf3f32e81830f441fc761143c1297d"}],"releasenotes/notes/add-vlan-interfaces-cdfeb39d0f3d444d.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a033e05761884a015307bcdad2e7dceed1363432","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add the ability to bring up VLAN interfaces and include them in the"},{"line_number":5,"context_line":"    introspection report.  A new configuration field is added -"},{"line_number":6,"context_line":"    ``ipa-enable-vlan-interfaces``, which defines either the VLAN interface"},{"line_number":7,"context_line":"    to enable, the interface to use, or \u0027all\u0027 - which indicates all"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fffc6b78_3dfaca41","line":4,"updated":"2020-11-20 11:44:50.000000000","message":"nit: Adds","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"b2d69f7837838239702f83c259cac64e512254d1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add the ability to bring up VLAN interfaces and include them in the"},{"line_number":5,"context_line":"    introspection report.  A new configuration field is added -"},{"line_number":6,"context_line":"    ``ipa-enable-vlan-interfaces``, which defines either the VLAN interface"},{"line_number":7,"context_line":"    to enable, the interface to use, or \u0027all\u0027 - which indicates all"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fffc6b78_d67d5b6f","line":4,"in_reply_to":"fffc6b78_3dfaca41","updated":"2020-11-23 13:17:44.000000000","message":"Done","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a033e05761884a015307bcdad2e7dceed1363432","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add the ability to bring up VLAN interfaces and include them in the"},{"line_number":5,"context_line":"    introspection report.  A new configuration field is added -"},{"line_number":6,"context_line":"    ``ipa-enable-vlan-interfaces``, which defines either the VLAN interface"},{"line_number":7,"context_line":"    to enable, the interface to use, or \u0027all\u0027 - which indicates all"},{"line_number":8,"context_line":"    interfaces.  If the particular VLAN is not provided, IPA will"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fffc6b78_9d9496ea","line":5,"updated":"2020-11-20 11:44:50.000000000","message":"s/configuration field/kernel params/","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"b2d69f7837838239702f83c259cac64e512254d1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add the ability to bring up VLAN interfaces and include them in the"},{"line_number":5,"context_line":"    introspection report.  A new configuration field is added -"},{"line_number":6,"context_line":"    ``ipa-enable-vlan-interfaces``, which defines either the VLAN interface"},{"line_number":7,"context_line":"    to enable, the interface to use, or \u0027all\u0027 - which indicates all"},{"line_number":8,"context_line":"    interfaces.  If the particular VLAN is not provided, IPA will"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fffc6b78_b682574e","line":5,"in_reply_to":"fffc6b78_9d9496ea","updated":"2020-11-23 13:17:44.000000000","message":"Done","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a033e05761884a015307bcdad2e7dceed1363432","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ``ipa-enable-vlan-interfaces``, which defines either the VLAN interface"},{"line_number":7,"context_line":"    to enable, the interface to use, or \u0027all\u0027 - which indicates all"},{"line_number":8,"context_line":"    interfaces.  If the particular VLAN is not provided, IPA will"},{"line_number":9,"context_line":"    use the lldp info for the interface to determine which VLANs should"},{"line_number":10,"context_line":"    be enabled. See"},{"line_number":11,"context_line":"    `story 2008298 \u003chttps://storyboard.openstack.org/#!/story/2008298\u003e`."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fffc6b78_7d99f21d","line":9,"updated":"2020-11-20 11:44:50.000000000","message":"nit: LLDP information","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"b2d69f7837838239702f83c259cac64e512254d1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ``ipa-enable-vlan-interfaces``, which defines either the VLAN interface"},{"line_number":7,"context_line":"    to enable, the interface to use, or \u0027all\u0027 - which indicates all"},{"line_number":8,"context_line":"    interfaces.  If the particular VLAN is not provided, IPA will"},{"line_number":9,"context_line":"    use the lldp info for the interface to determine which VLANs should"},{"line_number":10,"context_line":"    be enabled. See"},{"line_number":11,"context_line":"    `story 2008298 \u003chttps://storyboard.openstack.org/#!/story/2008298\u003e`."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fffc6b78_1697e392","line":9,"in_reply_to":"fffc6b78_7d99f21d","updated":"2020-11-23 13:17:44.000000000","message":"Done","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a033e05761884a015307bcdad2e7dceed1363432","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    interfaces.  If the particular VLAN is not provided, IPA will"},{"line_number":9,"context_line":"    use the lldp info for the interface to determine which VLANs should"},{"line_number":10,"context_line":"    be enabled. See"},{"line_number":11,"context_line":"    `story 2008298 \u003chttps://storyboard.openstack.org/#!/story/2008298\u003e`."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fffc6b78_dd9e1e06","line":11,"updated":"2020-11-20 11:44:50.000000000","message":"missing _ after the last ` (the syntax is `name \u003curl\u003e`_)","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"b2d69f7837838239702f83c259cac64e512254d1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    interfaces.  If the particular VLAN is not provided, IPA will"},{"line_number":9,"context_line":"    use the lldp info for the interface to determine which VLANs should"},{"line_number":10,"context_line":"    be enabled. See"},{"line_number":11,"context_line":"    `story 2008298 \u003chttps://storyboard.openstack.org/#!/story/2008298\u003e`."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fffc6b78_f6933fa2","line":11,"in_reply_to":"fffc6b78_dd9e1e06","updated":"2020-11-23 13:17:44.000000000","message":"Done","commit_id":"2e491e9c9b6cf283f76c422625f5c0673d16be79"}]}