)]}'
{"id":"openstack%2Fironic-python-agent~762850","triplet_id":"openstack%2Fironic-python-agent~master~Ia1c2c2e6a32c76ac0249e6a46e4cced18d6093a9","project":"openstack/ironic-python-agent","branch":"master","topic":"fix-lshw-2","hashtags":[],"change_id":"Ia1c2c2e6a32c76ac0249e6a46e4cced18d6093a9","subject":"Fix vendor info retrieval for some versions of lshw","status":"MERGED","created":"2020-11-16 14:25:42.000000000","updated":"2020-11-19 16:31:54.000000000","submitted":"2020-11-18 17:27:07.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"762850-1605720427449-61663776","meta_rev_id":"79fa0410b74c5479d4208e500d0c26f2c422ac08","_number":762850,"virtual_id_number":762850,"owner":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-11-16 14:26:37.000000000","_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-18 17:27:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-11-16 16:34:43.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":2,"date":"2020-11-18 15:55:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2020-11-17 13:41:11.000000000","_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":1,"date":"2020-11-18 15:55:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-16 16:34:43.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-11-17 13:41:11.000000000","updated_by":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"reviewer":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"state":"REVIEWER"},{"updated":"2020-11-18 15:55:52.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2020-11-18 17:27:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f5c463282ad0c1c042677595ac0b5c9307227e17","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2020-11-16 14:25:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d4937eca67a68da6f7213947da07a978b1231ebe","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2020-11-16 14:26:37.000000000","message":"Patch Set 1:\n\nApologies for not getting it from the first time, now all the places are covered by the change","accounts_in_message":[],"_revision_number":1},{"id":"e4af7bec572279e1fa68c280aa5b6b1d0776e45c","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-11-16 16:34:43.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/d08ad32a9d8845c196b9a58bba130f23 : SUCCESS in 2h 08m 04s","accounts_in_message":[],"_revision_number":1},{"id":"810b329bb2649e069876fc8782b3da8b202033f0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-16 16:41:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b8531d5c11414da1ac482d5f772db65b : SUCCESS in 4m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/317e22a83e4544388f3b29b8178e89ea : SUCCESS in 5m 35s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f726b8b234564036a40faba735a8176a : SUCCESS in 5m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/36c0716ca0e34c44948b448494a04a24 : SUCCESS in 5m 39s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4ff493eb5d7b4603972a5fcabc9237ac : SUCCESS in 4m 28s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c78d79feb6844b638d611e00ea2f778e : SUCCESS in 5m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/569bb55b3ed147a1925fc022132f3b5f : SUCCESS in 6m 42s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/4262c2d8511c4e8f9560839c68a855b0 : SUCCESS in 5m 05s\n- ipa-tox-examples https://zuul.opendev.org/t/openstack/build/b8e3a32ef2fd444db3f47172f981c810 : SUCCESS in 4m 29s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/0fed0448f7bc4697b0582ec60ed406ff : SUCCESS in 1h 18m 35s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/61b7a34a415644978b8c08364667dbe2 : SUCCESS in 1h 20m 30s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/eed36e03bd7f4ba195feac26c7691560 : SUCCESS in 1h 11m 37s (non-voting)\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/513b9c4083dd4017b5d6e5125db57a37 : SUCCESS in 1h 23m 38s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/e066105aef54475e9da2e2b21c28e4d2 : SUCCESS in 1h 27m 04s (non-voting)\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/9c5c5189e34f44bbb9715b706c649528 : SUCCESS in 16m 02s (non-voting)\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/653895f3843d4b6b9210a71c2cf977b4 : SUCCESS in 13m 09s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/c66be9aa6e9d45a1b3cd1e066caf0e48 : SUCCESS in 2h 05m 46s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/41296595cf5d4adca0b6f2b1cfe90758 : SUCCESS in 5m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e3f67e0437f15087768c217efee7d0e0b4a81d9d","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2020-11-17 13:41:11.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks, Vladyslav!","accounts_in_message":[],"_revision_number":1},{"id":"bab394185c8288b08ccd0b5beb8f37515a6880a5","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-11-18 15:55:52.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"9078d68e1ed58fa15bfc3244f9280a72bd3ab117","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-18 15:56:17.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"39ff0e46e8f68ab36aaf51e00f87b7684bb2c117","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-18 17:27:07.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"c93dd1fd42967928814ffbbfd6e04db62c9ee9a2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-18 17:27:07.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fc981934f0b0429985ffe5a6d77f9a5d : SUCCESS in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e566e749bf8e4709b648e0d999d644d7 : SUCCESS in 4m 25s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8d0d0d51a4c942169b34607f1d32b379 : SUCCESS in 5m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3228c2fc08d644eca403b24d58bf1bdb : SUCCESS in 4m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2d7d0396ec5445898143f944e190935e : SUCCESS in 6m 06s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/d89901b464414881846f627180d669fc : SUCCESS in 4m 29s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/59734c046a9a4ef486170541d829d996 : SUCCESS in 1h 20m 40s\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/614b58bb0a5c4c10a9bac0fa92cce7c9 : SUCCESS in 1h 20m 52s\n- metalsmith-integration-ipa-src https://zuul.opendev.org/t/openstack/build/886ebc5620744b7c9d9053181f024a55 : SUCCESS in 1h 18m 29s","accounts_in_message":[],"_revision_number":1},{"id":"9d50c88851cc9f1152858882a4aff3ba9151737f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-18 17:29:38.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fb03071128f24b51a21d96cb07c86453 : SUCCESS in 1m 21s","accounts_in_message":[],"_revision_number":1},{"id":"a2ed243584a99aabf33dcc832e62d2997800a469","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2020-11-19 16:31:54.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/victoria as commit 31e9d0db8c1ea3f8f7dfe1328f7ab0b19325a363","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3761a448009467dd342bc0cb3ca3b182969def42","revisions":{"3761a448009467dd342bc0cb3ca3b182969def42":{"kind":"REWORK","_number":1,"created":"2020-11-16 14:25:42.000000000","uploader":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"ref":"refs/changes/50/762850/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/50/762850/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/762850/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/762850/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/762850/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/762850/1"}}},"commit":{"parents":[{"commit":"37dc11fcc1056dd367f9ae36897e01e37f97fccf","subject":"Merge \"Log configuration options on start-up\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/37dc11fcc1056dd367f9ae36897e01e37f97fccf"}]}],"author":{"name":"Vladyslav Drok","email":"vdrok@mirantis.com","date":"2020-11-16 13:51:53.000000000","tz":60},"committer":{"name":"Vladyslav Drok","email":"vdrok@mirantis.com","date":"2020-11-16 14:25:12.000000000","tz":60},"subject":"Fix vendor info retrieval for some versions of lshw","message":"Fix vendor info retrieval for some versions of lshw\n\nThere is one more place that relies on lshw json output being a dict,\nso let\u0027s fix the function that gets the dict rather than places it is\nbeing used in.\n\nChange-Id: Ia1c2c2e6a32c76ac0249e6a46e4cced18d6093a9\nTask: 39527\nStory: 2007588\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3761a448009467dd342bc0cb3ca3b182969def42"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3761a448009467dd342bc0cb3ca3b182969def42"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
